From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3C431C6FD20 for ; Fri, 24 Mar 2023 17:58:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=suTqfsBrVnXPh0ngbZfgRqWTpc8MucRCKjVSaehkDRw=; b=BgZNpjwq5sc9tL rredqyvPFuJpiIiqToqCgR31E/TGuQFaJK5c1IwWx2P0mbASFaShtR5n50p1XL/we/mGAw24yhCyh 9hem+Qo4OfQofj/Bf90izmVXxOf5DpSVhZTmlKvrIxDaBjupZkQ3BJhfTLski0hNu+bCq2PptDJf9 h2Z69Y0/vIURiiur/yxw07Wd6UNZYvqeXhuhXVgJ6em7HqbqYtFDB+5nl1X0Y/mJ8I2SJnYs1/qQg 6CD3bhPdMJJWoxmG5ZxqxE7hZISuzZb8DRdQwgKIZE0IqoewUP0CNeIs7bzSI8ynNJmq7+TQVjBg4 gh4In+HBWyIV6Y2BkFXA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pflfu-005CU1-1E; Fri, 24 Mar 2023 17:58:02 +0000 Received: from mail-dm6nam11on2060c.outbound.protection.outlook.com ([2a01:111:f400:7eaa::60c] helo=NAM11-DM6-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pfldi-005Af0-12 for linux-arm-kernel@lists.infradead.org; Fri, 24 Mar 2023 17:55:52 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R6Oe2S8FoI6bTmVQXjgRKj+AbVG+C5/KOr7HH4XgjPoBqoZdtqa4yQKsRwOqd6SJcQdGFcqunxOko6s2Hq2jddLVP7W8X4Jqixp2LgE5Ywe5dUoDlK+GF/L/1Awbd9ZfjLGRhJVUpN8AVqbon4duieqbM3EYeHGcLFAJUsNuljIG1j3G7V8URnGiNWu+XoEDHYUSTS8tLKn0LqWDAgBawgHxptIQFXdObB/7oS3JjHwBTGUmQhMI27up84nFjTi7sgx++g8q//1bevd5Z9AJGagI/5ucYmiUfeXYTgpOJswTJqOSkYZENYPwlkY4BfcPwAvLBdtohP69KtSJd0F0rA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SKpVwj0GCYlG+krAa5Brt8JnHB9XjRp9le+tjEGnQhw=; b=IY4rF3Ug7/WZpd1W7bV/nMJaRmut4JN8Kyb1VVsIbkMfJo8AZkmeR4ixZDmEBoiVi2jkrEVIfSEdZPpISu19zs/vRNrzzeHQMkZ2ObGyvQTGyt4YJdkAXXXpjXmWTXLZ/8YlV/+zjBJx7MVfx0YLxTn818AU8AQEIh26MHO/uxRDTuJqMk8AD5uwYJjWFk8L7fuH6L/jHniGXfMNGLiRsMx3mM/T0g6sf3IkCiTg4I8nvu3g9Bh5pYPgvY8pOp2d9A07hZLKZSDVK8nQaI0WBi3q0EN8pBP57pWKImaZanR56G++By4KjhLMrDAYyD3N3pGlATikTenqkhTDr4yhGQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=redhat.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SKpVwj0GCYlG+krAa5Brt8JnHB9XjRp9le+tjEGnQhw=; b=ZWvfw0JVRGxtaL0H+TaChcNIJiU+tesH1C4M1B+LuM7ySSFUaSis3xsEUFRwV+9yJWCltHRw+ssUqLdKUM3rs+7knUm9Heo55iRxyvrUY5GxoNofpanN3m3+j75P3gv35HzqflAhRgN1cRlExCrtvi4TuJlVWpCGeFJhTWCeZG+xwh+u5cadzav4XhrMnzcTtdb98ChQeP+55VtnK6E8I3K4HfhRAOwKz4WLY0I4DrqqWCRcum0COVl340ZU8lwhbou2XYzB8MSNac+IwtkjahKFEMpefJGv1v+7U9Qla3pYsQPrSUpOeMWn68176kMvXIJ8+cF4lXa/2PsIGb+I+Q== Received: from DM6PR03CA0086.namprd03.prod.outlook.com (2603:10b6:5:333::19) by CH0PR12MB5091.namprd12.prod.outlook.com (2603:10b6:610:be::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.38; Fri, 24 Mar 2023 17:55:42 +0000 Received: from DS1PEPF0000E62F.namprd02.prod.outlook.com (2603:10b6:5:333:cafe::fa) by DM6PR03CA0086.outlook.office365.com (2603:10b6:5:333::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.38 via Frontend Transport; Fri, 24 Mar 2023 17:55:42 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by DS1PEPF0000E62F.mail.protection.outlook.com (10.167.17.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.30 via Frontend Transport; Fri, 24 Mar 2023 17:55:42 +0000 Received: from rnnvmail204.nvidia.com (10.129.68.6) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Fri, 24 Mar 2023 10:55:30 -0700 Received: from rnnvmail203.nvidia.com (10.129.68.9) by rnnvmail204.nvidia.com (10.129.68.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Fri, 24 Mar 2023 10:55:30 -0700 Received: from Asurada-Nvidia (10.127.8.9) by mail.nvidia.com (10.129.68.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5 via Frontend Transport; Fri, 24 Mar 2023 10:55:29 -0700 Date: Fri, 24 Mar 2023 10:55:27 -0700 From: Nicolin Chen To: Jason Gunthorpe CC: Eric Auger , , , , , , , , , , Subject: Re: [PATCH v1 12/14] iommu/arm-smmu-v3: Support IOMMU_DOMAIN_NESTED type of allocations Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF0000E62F:EE_|CH0PR12MB5091:EE_ X-MS-Office365-Filtering-Correlation-Id: 7b2eeeb9-9030-4a29-547f-08db2c90fc84 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YxKSiEK/gPm0kpZM0nDYRkH+/I+lvzkDhk7YYQesDzVw9iIMXSQyaxQJS9H5ea10YmIXxaB8YKnfhvDFVnUSi7cZFxXkUtJYTn/J/roiEFChiFUji9+1kbvLS9Eiy663NlShuXpjv0dRimxKYZXo1baGznzQ6uH6ckZq8/lolQW9twieZX+qoDJE/Umwik9WAKTHUvYFtSg62DNnZla+sOA6UlbmckOjvMT47wjA3hg02fpA65jEI1aU+Qs9+v5c8zLHgjkysWxIceWJAnK++dNxDBnOrOXhIxioBFgyrdzrV2QNeWqHQ+LMlZh59PA7Wk0TuG/FndKAPKGw0WB0ME0gywn219WE1fOKh6Gk8Gpi5c738G/VMmGeiquxCXeAegfpWBL7eZJvdRhZbOoEhiCPSoQ5ue8/Y2av7gCLYhsle3WaVW5358+6+mfTDa04ByHvLFMS5J4H3M5hv1KwWHTYWwtwpE0rBG0k0/RmQafj6wS551RvAWL+IPxfZwfnb1TLCNp/oJwDoizpAjchLMxacaOjx3KWo+nMXXSBKCO/UyOd0BPAiDsUe5gvtfT5Tc7t4hxDm8WoGZGLJcWTGdVvYzvA8oJ+e7RsLxXxIO6/ifdTQ5BElQ6cOBJD/lBKNAyC/DtZm9o36n3d6L9FIVkejv4fqO2chi3OSvAgObhbd4TcTKSX9C7TBldKSEfNg7NrKxjsPbWCI0wtghZxMHs6A3M643dkbeEkDW3QTbkbeh2UTTw7ux791UTeFJxy X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230028)(4636009)(346002)(136003)(39860400002)(376002)(396003)(451199021)(40470700004)(46966006)(36840700001)(5660300002)(8676002)(41300700001)(33716001)(6862004)(70206006)(26005)(82310400005)(40480700001)(47076005)(55016003)(8936002)(316002)(478600001)(70586007)(6636002)(336012)(186003)(9686003)(426003)(54906003)(356005)(86362001)(7636003)(2906002)(40460700003)(36860700001)(82740400003)(4326008)(7416002);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2023 17:55:42.5094 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7b2eeeb9-9030-4a29-547f-08db2c90fc84 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF0000E62F.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5091 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230324_105546_383918_967902DA X-CRM114-Status: GOOD ( 18.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Mar 24, 2023 at 02:51:45PM -0300, Jason Gunthorpe wrote: > On Fri, Mar 24, 2023 at 10:50:34AM -0700, Nicolin Chen wrote: > > On Fri, Mar 24, 2023 at 04:44:58PM +0100, Eric Auger wrote: > > > > @@ -2923,8 +2949,16 @@ arm_smmu_domain_alloc_user(struct device *dev, struct iommu_domain *parent, > > > > const struct iommu_hwpt_arm_smmuv3 *user_cfg = user_data; > > > > struct arm_smmu_master *master = dev_iommu_priv_get(dev); > > > > unsigned type = IOMMU_DOMAIN_UNMANAGED; > > > > + struct arm_smmu_domain *s2 = NULL; > > > > + > > > > + if (parent) { > > > > + if (parent->ops != arm_smmu_ops.default_domain_ops) > > > > + return NULL; > > > > + type = IOMMU_DOMAIN_NESTED; > > > > + s2 = to_smmu_domain(parent); > > > > + } > > > Please can you explain the (use) case where !parent. This creates an > > > unmanaged S1? > > > > It creates an unmanaged type of a domain. The decision to mark > > it as an unmanaged S1 or an unmanaged S2 domain, is done in the > > finalise() function that it checks the S2 flag and set a stage > > accordingly. > > This also needs to be fixed up, the alloc_user should not return > incompletely initialized domains. The finalise() is called at the end of __arm_smmu_domain_alloc() so alloc_user passing a dev pointer completes the initialization actually. Thanks Nicolin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel