From: Baoquan He <bhe@redhat.com>
To: "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
linux-kernel@vger.kernel.org, horms@kernel.org,
John.p.donnelly@oracle.com, will@kernel.org,
kexec@lists.infradead.org, ardb@kernel.org, rppt@kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 0/3] arm64: kdump : take off the protection on crashkernel memory region
Date: Sat, 25 Mar 2023 11:00:11 +0800 [thread overview]
Message-ID: <ZB5ju+xxCwZ7DDA5@MiWiFi-R3L-srv> (raw)
In-Reply-To: <9ca6f729-989d-654a-83e6-c89d8f65c69d@huawei.com>
On 03/25/23 at 10:14am, Leizhen (ThunderTown) wrote:
>
>
> On 2023/3/25 1:11, Catalin Marinas wrote:
> > On Fri, Mar 24, 2023 at 09:18:35PM +0800, Baoquan He wrote:
> >> Baoquan He (3):
> >> arm64: kdump : take off the protection on crashkernel memory region
> >> arm64: kdump: do not map crashkernel region specifically
> >> arm64: kdump: defer the crashkernel reservation for platforms with no
> >> DMA memory zones
> >>
> >> arch/arm64/include/asm/kexec.h | 6 -----
> >> arch/arm64/include/asm/memory.h | 5 ----
> >> arch/arm64/kernel/machine_kexec.c | 20 --------------
> >> arch/arm64/mm/init.c | 6 +----
> >> arch/arm64/mm/mmu.c | 43 -------------------------------
> >> 5 files changed, 1 insertion(+), 79 deletions(-)
> >
> > This series works for me and it has a negative diffstat as well (though
> > I'm sure people will try to bring it back ;)).
>
> After the write protection is removed, it is recommended that crc32 check
> be added. However, it can be added later.
That's a great catch. We have calculated the checusum with sha256 in
user space and kernel, and verify it in purgatory in user space.
However, arm64 seems to not do the verifying in kernel if
kexec_file_load is used. Please see kexec_calculate_store_digests().
If stamping happened, the checksum verification can help us spot it.
Yes, this can be added later. Thanks for raising that.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-03-25 3:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-24 13:18 [PATCH 0/3] arm64: kdump : take off the protection on crashkernel memory region Baoquan He
2023-03-24 13:18 ` [PATCH 1/3] " Baoquan He
2023-03-25 1:56 ` Leizhen (ThunderTown)
2023-03-24 13:18 ` [PATCH 2/3] arm64: kdump: do not map crashkernel region specifically Baoquan He
2023-03-25 1:57 ` Leizhen (ThunderTown)
2023-03-24 13:18 ` [PATCH 3/3] arm64: kdump: defer the crashkernel reservation for platforms with no DMA memory zones Baoquan He
2023-03-25 2:04 ` Leizhen (ThunderTown)
2023-03-26 13:10 ` Baoquan He
2023-03-26 13:02 ` [PATCH v2 " Baoquan He
2023-03-27 1:26 ` Leizhen (ThunderTown)
2023-03-24 17:11 ` [PATCH 0/3] arm64: kdump : take off the protection on crashkernel memory region Catalin Marinas
2023-03-25 2:14 ` Leizhen (ThunderTown)
2023-03-25 3:00 ` Baoquan He [this message]
2023-03-25 6:02 ` Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZB5ju+xxCwZ7DDA5@MiWiFi-R3L-srv \
--to=bhe@redhat.com \
--cc=John.p.donnelly@oracle.com \
--cc=ardb@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=horms@kernel.org \
--cc=kexec@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rppt@kernel.org \
--cc=thunder.leizhen@huawei.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).