From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 20C6BC74A44 for ; Tue, 14 Mar 2023 18:44:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XlnTUsxV+atJbQt3fhm9odAGGoR1zwvXYrUMVXaC6kM=; b=hrig1o9kJJr/Ts SCI+2kk9P/jvwQzzIJcudXUA0bSWPEyWWVqgpRtEXYScqE1L7R5WrlYN6JQ+nfOV73J4ZkVrsslgb W4ASHLcY41tr1kwcTQpH9io/1nZBaV1AVLsJ+1+7H6rDNlZ1yM3loEfhNCMCcg/s3YrwUN74LOVZc UA8xbo+DZmb0bPrAjO0ADUcQVvHa9ftZ8GzeouyKvVShvCs5wR6owB2qYNuzEJjveuT9pipeqiuoa cPvrU+tAHB/nr1f8cXI5mhodSo5SDisXKVe5yL9OjlFvBxgKGzDHQp2HsE8uYEMkWf3Ve3Uz2JhYo lgzKzsjBmVQmwuh1vxsg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pc9cd-00BEWJ-2B; Tue, 14 Mar 2023 18:43:43 +0000 Received: from mga01.intel.com ([192.55.52.88]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pc9ca-00BEVA-2M for linux-arm-kernel@lists.infradead.org; Tue, 14 Mar 2023 18:43:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1678819420; x=1710355420; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=HcDoA6lnkNndAAvLyrmktLzn4ToTWYKaGtwl/HFFUFk=; b=UktC0TMTICYs2x/9ZrAa1GjF7LKx8IOHkk0xaqq7MUG1Hj/V60+IQ43v FXhQc2Lkt0T4MHwpfFnmeYtismGwRq1tFAYS98Dxwnk/kU5gR0Pz669AZ fT3DJ6qHRmVAqaMiN9C9sP0vw5ALKUThll7uUXXr9K/4wIH/eSeN/w6OZ wgJd2cfw09UtwgKawYSUztMZNFgKtvoZ/pD8JRUxyoWqwipJuuLcmHPk1 rVm9l9M34dDU3BG1Imh9TYyId7fJUwQEKg9F7bUWMXkpb6oMoCz9AwHzs MjyFySE3zGDwVBp7wE7ntpo1FI706Ok4JPvmt0ErfrKlGKVI8q88RMt4J w==; X-IronPort-AV: E=McAfee;i="6500,9779,10649"; a="365185417" X-IronPort-AV: E=Sophos;i="5.98,260,1673942400"; d="scan'208";a="365185417" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Mar 2023 11:43:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10649"; a="802973476" X-IronPort-AV: E=Sophos;i="5.98,260,1673942400"; d="scan'208";a="802973476" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga004.jf.intel.com with ESMTP; 14 Mar 2023 11:43:32 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1pc9cO-003NLi-0Q; Tue, 14 Mar 2023 20:43:28 +0200 Date: Tue, 14 Mar 2023 20:43:27 +0200 From: Andy Shevchenko To: Dan Carpenter Cc: oe-kbuild@lists.linux.dev, =?iso-8859-1?Q?Micka=EBl_Sala=FCn?= , Mika Westerberg , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Michael Ellerman , Randy Dunlap , Arnd Bergmann , Bjorn Helgaas , "Rafael J. Wysocki" , Niklas Schnelle , Pali =?iso-8859-1?Q?Roh=E1r?= , "Maciej W. Rozycki" , Juergen Gross , Dominik Brodowski , linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-pci@vger.kernel.org, xen-devel@lists.xenproject.org, linux-acpi@vger.kernel.org, lkp@intel.com, oe-kbuild-all@lists.linux.dev, Miguel Ojeda , Richard Henderson , Ivan Kokshaysky , Matt Turner , Russell King , Andrew Lunn Subject: Re: [PATCH v4 1/4] PCI: Introduce pci_dev_for_each_resource() Message-ID: References: <20230310171416.23356-2-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230314_114340_780010_1132D3FC X-CRM114-Status: GOOD ( 10.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Mar 11, 2023 at 04:54:32PM +0300, Dan Carpenter wrote: > 059b4a086017fb Mika Westerberg 2023-03-10 246 unsigned long type = resource_type(r); > 999ed65ad12e37 Rene Herman 2008-07-25 247 > 059b4a086017fb Mika Westerberg 2023-03-10 @248 if (type != IORESOURCE_IO || type != IORESOURCE_MEM || > ^^ > This || needs to be &&. This loop will always hit the continue path > without doing anything. > > 059b4a086017fb Mika Westerberg 2023-03-10 249 resource_size(r) == 0) > 0509ad5e1a7d92 Bjorn Helgaas 2008-03-11 250 continue; Thanks, I'll fix in v5. -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel