From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C6549C6FD1D for ; Wed, 15 Mar 2023 15:30:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=//SdMlhpuMa/aBpUUBYJ/DZ3YkEjVAxk/hoCS/1wnlw=; b=XHXiWiGrGu7ys9 JCEt8vlSwpqxtG9BoLtsEUwET394l0S+y2jpto8w7OyDMSz3jHHsqPuT30+rrAETJrjZwTyfFy0Yc 4LZ2XFmAQiHC6rbVtSbiBzWUarK8w17T0ZTWUt4FCBBiqntfpC/AwOywoko4qGL7bzqPm4FyeNJOC a+J32RypDNWipj0Qzm607h+rLKl0G71hsGQsJVeLFdMJDmKlwmnDVgNJOCQZsSDv/O0d7qhwEuKix NfcOcWAMW77YW2KiPaZttqAymEkS2ITPwBaeyPE6uPTgux/GZs0ptSGVr12/Vj2Krcab191fmGQbs Ia8aIBaSwWjkCp0LzMqg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pcT4O-00DtqD-0d; Wed, 15 Mar 2023 15:29:40 +0000 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pcT4K-00DtpG-17 for linux-arm-kernel@lists.infradead.org; Wed, 15 Mar 2023 15:29:38 +0000 Received: by mail-wr1-x42f.google.com with SMTP id j2so17668667wrh.9 for ; Wed, 15 Mar 2023 08:29:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20210112.gappssmtp.com; s=20210112; t=1678894172; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=XYhBeu/notvz82UgfkzH+YbK5CCJXB0MnLkpf5cNHAI=; b=kRTHqzm153zu/Zc9NERe8ET2dWnkhROx09XiOifwd5oZvospmfGhysr6lgkUn1JFDn OKTe/gvetQCDLDIePfi+W3lqVQUjhwlG9sYj9vX2lGl4M4O9IgXC66Iq9vJkTnN0daVu OEmOT4sZkVH5whFbyf6o9UYCjHHTX7AeqahToseLy3ew/rQdWT2WtAdi3DUoNTjviJha HUSZ+xeXwGN4MTDX5XRAnbijQw19nax8wTq8qyGQkrhBESKAgRgLuaog2UnPxqNMruat FppK/AXaWfEStCKJlFEs2BuHGv+z5urycEjATQC0Zc5W+boeOQ5hHdFRFIbq1l/waU7k bGrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678894172; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XYhBeu/notvz82UgfkzH+YbK5CCJXB0MnLkpf5cNHAI=; b=ztFvS9vQMqjc+d/t7I4NhllDC85cDtqiMjU5F5Qcgape/9t+Gsf8LPo6jIPOSDROGy ItIh+st5rmkVlgI/DHOGR3IBiz/jrchXcJIMpMloDWEl9YZkvL1jRaIjVjIhLNKGBgjp viQqyTaKsdgrYWh1ZLBQw1P3fzzl6yelSwe9qJIb/d2bt6cvU2mcl2G/Z9gI77E+asOf L2vyr9qAvbcqQQQZnwek0I06PcMz50LLQ8dxh3S4tVZYwzE3M50JGcpRQ/5pS+vBtdA/ cklAirFV2Mv+ITv8OyRzWh6gLRnRCn23Ips2zumbwZGc9DQQUT7S8tJDzPsy7yPlGUcT gSFQ== X-Gm-Message-State: AO0yUKWbFire31gfF84UosqQ4cQ0axY8gZ4oJE8zni5zvN0kouc1Jkrg 1ZcyzcD1lxqMtU04eV/acXes7Q== X-Google-Smtp-Source: AK7set8qri9bTR6kXZCDIDLsIRR7ZhcP+VRrtZ/y7MfYtf3hUI4jwn6GWBEtEAhFV/gvCoQZxvPD1g== X-Received: by 2002:a5d:448c:0:b0:2d0:bba8:3901 with SMTP id j12-20020a5d448c000000b002d0bba83901mr1647969wrq.62.1678894172494; Wed, 15 Mar 2023 08:29:32 -0700 (PDT) Received: from localhost (host-213-179-129-39.customer.m-online.net. [213.179.129.39]) by smtp.gmail.com with ESMTPSA id z4-20020a5d6544000000b002c56013c07fsm4931457wrv.109.2023.03.15.08.29.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Mar 2023 08:29:31 -0700 (PDT) Date: Wed, 15 Mar 2023 16:29:30 +0100 From: Jiri Pirko To: Vadim Fedorenko Cc: Jakub Kicinski , Arkadiusz Kubalewski , Jonathan Lemon , Paolo Abeni , Vadim Fedorenko , poros@redhat.com, mschmidt@redhat.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, Milena Olech , Michal Michalik Subject: Re: [PATCH RFC v6 2/6] dpll: Add DPLL framework base functions Message-ID: References: <20230312022807.278528-1-vadfed@meta.com> <20230312022807.278528-3-vadfed@meta.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230312022807.278528-3-vadfed@meta.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230315_082936_379641_C0E5C2CC X-CRM114-Status: UNSURE ( 6.77 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Sun, Mar 12, 2023 at 03:28:03AM CET, vadfed@meta.com wrote: [...] >+struct dpll_device >+*dpll_device_get(u64 clock_id, u32 dev_driver_id, struct module *module); [...] >+struct dpll_pin >+*dpll_pin_get(u64 clock_id, u32 dev_driver_id, struct module *module, >+ const struct dpll_pin_properties *pin_prop); Small tweak, please use the same trick as shown for example here: /* pci_register_driver() must be a macro so KBUILD_MODNAME can be expanded */ #define pci_register_driver(driver) \ __pci_register_driver(driver, THIS_MODULE, KBUILD_MODNAME) The driver calls header helper which fills up the "THIS_MODULE" for it. Thanks! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel