From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 61841C6FD1D for ; Wed, 15 Mar 2023 15:35:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KDKaMGxhGO5GCG34JTzSAE6ss7L8cdRBHm06pHmPeS4=; b=qwpBSIIHGz+FyG KaJRfV9pRi/6qlXykPXBnNn+rX7tv72up1UhhG2n6iaxnf/GVgKvUaSlIUv8qfiEQZjraqDCx4s9x UXrQ7TjBo/EmwPtx7KWBViLpRtwHUeCTAyhvW+mHk5xuglLbeIU4ADLpaZMG7a1CJHwWCc5lXCRZF AKBAWt+aYZJAZdGJkmJqPdPycI2D8cWogs0a689JgFDSukz0u2b7FATPmduB9CvK0CEwRy8I6pFGS KX49C3omjTin+wy6qwzKXQfVl92eA/Nlr9uyfpslbijw4HcCaKFXNp3MLwTghsA8hLvChDlk30jLJ Qmh0qiN9Yf/pezABcedA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pcT9C-00DuWt-1m; Wed, 15 Mar 2023 15:34:38 +0000 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pcT9A-00DuWD-1R for linux-arm-kernel@lists.infradead.org; Wed, 15 Mar 2023 15:34:37 +0000 Received: by mail-wm1-x32c.google.com with SMTP id k25-20020a7bc419000000b003ed23114fa7so1334241wmi.4 for ; Wed, 15 Mar 2023 08:34:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20210112.gappssmtp.com; s=20210112; t=1678894474; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=iSn5kfdhykvLhyEuzFDrK08azEwQSSmZ1qquAFvnjIQ=; b=BToH7Z3bKMbzK2RjYie+EhidShhg+xhjJZAE5+GlddA9dzbs0n1hStJfanyTI1tNUU 8E1aha0lNNN3OjR7fF0Nc/0gKastWb83+rZhAadJO1UCkOyQ9F0oMhQbLabowqy2pg8u XEJoo3m4hk9F4wwPsYf2rgKizCMsCzYthDZW1cKkVyXuIFrXms8mWqKNhLHLcBrwoCB3 dOGWuiSQLGKOQhqryeEpVAWL2t/cpc6J7AnbuxyStvtNbCbDyxHrrGLlJh40OdBNEO+Z fwQ4p2pCV2/u6guFFwurxcdXBRJGd+4gx3RM0/eHNNxjXt2KRUAtY6Yl/nN1yyVsK1F4 MBqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678894474; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=iSn5kfdhykvLhyEuzFDrK08azEwQSSmZ1qquAFvnjIQ=; b=HO+4qJVdNM+E3JvGBIxI8hOsDaTHns51j+3jLg27xkKn4Zlin3tAorKodqWEsiRs/L 5gKAIjrU27zUtYHFh8rMWx1D5+/5nLUXDaQCOcilTrEtPcAC99xcWSVfcVLNtygjmyZB XILa7Cp/YYYjw4BGxRbifDxDNjhejcsq/QnFMy70X52+jF02LKIgcAXlCkJ3FLPXDFhT 5mfbAfhlwcfStUSsesckfpEh6psii98tYRVsfIib/XUdx5RftfKLq+49E42JAVbUPDDU sjz5zT8JMM0WFax0bMksIfjIddPDrHA+ZSjEBCToxHp3xcSI5Cct/o51y/zKlGRyH+rK FIuw== X-Gm-Message-State: AO0yUKVnbax8zkle5GqpBXROV7+pVOIebZhQS16ESClDtYTnsX/weEW/ Ikm9PWaBLWUQLGATfuQ2qFZYJw== X-Google-Smtp-Source: AK7set8Yoa8+IOiarZ3IfL/VWla0xR5U0UapuEedg4o2wA11yz28lAI5nnin9ac7ZaYZUjGvpdwgrg== X-Received: by 2002:a05:600c:3c9e:b0:3e1:f8af:8772 with SMTP id bg30-20020a05600c3c9e00b003e1f8af8772mr18006250wmb.9.1678894474641; Wed, 15 Mar 2023 08:34:34 -0700 (PDT) Received: from localhost (host-213-179-129-39.customer.m-online.net. [213.179.129.39]) by smtp.gmail.com with ESMTPSA id o23-20020a05600c511700b003ed29b332b8sm2643610wms.35.2023.03.15.08.34.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Mar 2023 08:34:33 -0700 (PDT) Date: Wed, 15 Mar 2023 16:34:32 +0100 From: Jiri Pirko To: Vadim Fedorenko Cc: Jakub Kicinski , Arkadiusz Kubalewski , Jonathan Lemon , Paolo Abeni , Vadim Fedorenko , poros@redhat.com, mschmidt@redhat.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org Subject: Re: [PATCH RFC v6 6/6] ptp_ocp: implement DPLL ops Message-ID: References: <20230312022807.278528-1-vadfed@meta.com> <20230312022807.278528-7-vadfed@meta.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230312022807.278528-7-vadfed@meta.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230315_083436_483646_0276F0B7 X-CRM114-Status: UNSURE ( 7.45 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Sun, Mar 12, 2023 at 03:28:07AM CET, vadfed@meta.com wrote: [...] >@@ -4226,8 +4377,44 @@ ptp_ocp_probe(struct pci_dev *pdev, const struct pci_device_id *id) > > ptp_ocp_info(bp); > devlink_register(devlink); >- return 0; > >+ clkid = pci_get_dsn(pdev); >+ bp->dpll = dpll_device_get(clkid, 0, THIS_MODULE); >+ if (!bp->dpll) { You have to use IS_ERR() here. Same problem in ice. [...] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel