From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8188EC6FD1F for ; Thu, 16 Mar 2023 12:14:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HjPrbvGSBO0i5ToqKbyVe8GZvhQCetfdOW/dlfb+FaI=; b=XCwbKNsEzuFNh2 GsDM92zT/M5SKZZKajCVL9IMBXC3ixASp+Jr1OrRkrMCKFevJL6LsBCxJxykGwTZdq8i5OupXjLFv W2QNopWF2QNupAcOsmRmXnp8ETTcLv7GgRbzYScbOOLEbOjzhIFm8YdB2lzIzWycEDe7orz0cFnjt JwdJPFfDjM1e0lUX2XKKPm9UDLsdSkpvBxF5McL3U5cMOHj8zGXi29k04zn09qkDe0cKjRfyXaW7b 5v2484ChXlHCfvG8+I5o9DHWv6d7Gs0xxiab/r687PVSxsjMe29Qv1nJoA28zihelwAMH53Avrmuf abnCtv62BsocBuHen+uQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pcmTl-00GLvU-0l; Thu, 16 Mar 2023 12:13:09 +0000 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pcmTf-00GLuW-2b for linux-arm-kernel@lists.infradead.org; Thu, 16 Mar 2023 12:13:07 +0000 Received: by mail-wm1-x335.google.com with SMTP id p16so1066735wmq.5 for ; Thu, 16 Mar 2023 05:13:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20210112.gappssmtp.com; s=20210112; t=1678968779; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=0WO9ZvpvbKYXwSvZnqpXO8L+DfOB3WdQq1e9D11Fqd0=; b=oVUGF0yasUG8tgP9FJtlDU/de74oAD79T9FS8r2MSfGFRpIJ41K+41e7qS9sP+Twqy poSmiTR1VOUd7g/CNm4uEosBAw/QbRSjHOidSfW1UQ1gKZKVjl/k3L2LBFDyHHt8Yeh3 obq842Lj9kLvR5Iezk7uIybJ95+rkTGkrCMkapwdWCnqdFCnaA3EG4/EaDi7iI6fEFJM FuuaRUzjeEKWrVMalcg4VDenEqeJu59L+o+GkDhBRaN+WJyU4dVVNoe7fRgYhXz2cLzR hosk2HHNsANeiYufiHrjD5UyhGxJatkAlqUiN0kjipFVS8h6VtQrH+u5qIt14qdX7MpF WW5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678968779; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0WO9ZvpvbKYXwSvZnqpXO8L+DfOB3WdQq1e9D11Fqd0=; b=TAtjCttJo09rDJCod+Nsr6CB3f9F8yWlzXGtS12Y5QIHevILKdNXkvtYhKiNL2Oirw 6CKH2sGc/mMNkniCfGric92wuP9adneu+7zHfSEKl0rspXJ257VGvjfLfpwOyUidcWrR OX7yRik3mxbIi5OmWcK5hZxT40iTNkh0/Lko7N5dr8khxYqvNg2iHMlrswv8jJ6TiS6v MTPcB4AmTd3/5LlMS9hyZllL7wUi0dRiDXn9deQvgi4CU7XudU3yfN6xL7EGtY4vLple gOvQdEHJWxP5Bo/TkvW+4onq52pJ8TGbzb9QYzKCHi/tOYxhVgtOuU73tjAUAteqadf6 mwwg== X-Gm-Message-State: AO0yUKXxDsIKz0KaEyBWPvO5csPAyxZnsYefxcNdRKFdYGmydXaScAsI xPZMaViK4WxNUddT1w49yTa/6w== X-Google-Smtp-Source: AK7set9NjrFBLZ4ieAlm3ZW5QgEeNlqzUCFNjWu5qAKobxPwLHR5HhGvM2v06tBMGI6Yp5t1wJ1/sw== X-Received: by 2002:a05:600c:458e:b0:3eb:37ce:4c3d with SMTP id r14-20020a05600c458e00b003eb37ce4c3dmr19992464wmo.38.1678968779589; Thu, 16 Mar 2023 05:12:59 -0700 (PDT) Received: from localhost (host-213-179-129-39.customer.m-online.net. [213.179.129.39]) by smtp.gmail.com with ESMTPSA id f13-20020adff44d000000b002cfe29d2982sm7048067wrp.103.2023.03.16.05.12.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Mar 2023 05:12:58 -0700 (PDT) Date: Thu, 16 Mar 2023 13:12:57 +0100 From: Jiri Pirko To: Vadim Fedorenko Cc: Jakub Kicinski , Arkadiusz Kubalewski , Jonathan Lemon , Paolo Abeni , Vadim Fedorenko , poros@redhat.com, mschmidt@redhat.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org Subject: Re: [PATCH RFC v6 6/6] ptp_ocp: implement DPLL ops Message-ID: References: <20230312022807.278528-1-vadfed@meta.com> <20230312022807.278528-7-vadfed@meta.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230312022807.278528-7-vadfed@meta.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230316_051304_060880_928FEB5F X-CRM114-Status: UNSURE ( 8.22 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Sun, Mar 12, 2023 at 03:28:07AM CET, vadfed@meta.com wrote: [...] >@@ -4243,6 +4430,8 @@ ptp_ocp_remove(struct pci_dev *pdev) > struct ptp_ocp *bp = pci_get_drvdata(pdev); > struct devlink *devlink = priv_to_devlink(bp); > You are missing pins unregister and put here. Btw, It would be probably good to add a WARN_ON into dpll_device_unregister() to catch bugs like this one. >+ dpll_device_unregister(bp->dpll); >+ dpll_device_put(bp->dpll); > devlink_unregister(devlink); > ptp_ocp_detach(bp); > pci_disable_device(pdev); >-- >2.34.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel