From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 13E36C6FD1F for ; Thu, 16 Mar 2023 12:20:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=o3lHhFfppxAjD9O4rbegv3koN7mK+TESyR3k75LTV78=; b=inkGTauZdsVXYT kY8IxDgRz072K2ikfBWcDKoy10U2YkV9ebXXZwPL3GUxhQLBLwLnYuwG7JersgvvFnXfc9/GifJkN r6XbJJY9cqBsF7nsQkzek2DqmCh5NdLtWQTUCVGQyMYFop3+5/84M9BZDaZhCqIrqoh8yMNSIqRMx WAl7HJm/HBD0nkaq3egRGJSutIk7WqO2jKlJ1pdNK8x1rgOMSvpBp/hllGwpQ+vFaCx+KW+ju0bGz 1VQrv9K7NCHxeoKXuzAK0ksRDYv8Nr4/MAa52zeZWBks5huH1bqhJ+1fBJtKu9D/TxBxNFtJ0uf+A TJpZyhBkh4cxtW2w8LMg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pcmaa-00GMxm-0T; Thu, 16 Mar 2023 12:20:12 +0000 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pcmaW-00GMwd-2U for linux-arm-kernel@lists.infradead.org; Thu, 16 Mar 2023 12:20:09 +0000 Received: by mail-wm1-x32b.google.com with SMTP id p16so1105475wmq.5 for ; Thu, 16 Mar 2023 05:20:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20210112.gappssmtp.com; s=20210112; t=1678969205; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=KVg+HQThYLeKdF+SktSMsvte8PrLc9Lz2m3zKerLoNk=; b=ZhDFoWhwconSBXik8/oCRlArTiRy527X7RdRqxrwfyQ5fkRSreWP1etpng7OxaUueW SQrrinv9bCUZ+D5Ff5mwash2BmAtm7oAbgK3O8Bi3wPZRCm+Ut0xivl5eDiQcYa/ep57 a2xNYuT63EgoPoBPAkYf0y+NiFkP/iWwTrhkEmSl4r4t8f5yjureSha3DO9N+EE5JKDl 4MeCwSpOncYclsC10Kh0fUKE0IiJpKOwRXRNNIlo171Ulk48OikvIORtVoTqRI3lYvVB eNuBi2133KWkLMzVqhzdXpwAVlpUopg2WEhHc/ToyZ9fFEAaAv6uSHbudyWScqvFXI5S 4MQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678969205; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KVg+HQThYLeKdF+SktSMsvte8PrLc9Lz2m3zKerLoNk=; b=yVJ/cKZSE3MZIgPRfDOQJdGxpX7UKFrAFIoUxPrjthj9dRFFvWO84qqSpl6Nej+ohj 5Gh9lPvnbhVirg8hUwwDT54Zs4KfPICYuo0ERIpU1v01zL2WlvGJ+daryxdbh1hmt879 BkQ8tNxMRyddUvwnrrO65NU3zefnxX0/scNo6pi3ZSWfXecgySx6Qem7/czdxQ0o9MZ5 ai8DZPhbMw/5eQPB+VjjW7jMp1qgmMGhpUxP+GIQBzffoQH4MIWlb/mMOC9XJhh24pxa G1SdI7ZWZtubFiuKkrmnGEss/6ZhhkQ0YyUfV+rdeAuAMA6BuRu31QJprlmPx+bxrMAm n/4w== X-Gm-Message-State: AO0yUKWXqB4I36UBHlw9XmZOj9YiluxJYwy3CK3KGBU9Qw2JlWnVvKWz HN6V4R41i4KMEzMiPO+j1mXnxg== X-Google-Smtp-Source: AK7set+HaibucjTBWivbHwnXhA0iqdbe7hqauTwSwnA8PmD5OKUxEllEvl5Qz0afAowWtVk8fpYIdg== X-Received: by 2002:a05:600c:4707:b0:3eb:29fe:f912 with SMTP id v7-20020a05600c470700b003eb29fef912mr20771676wmo.36.1678969204980; Thu, 16 Mar 2023 05:20:04 -0700 (PDT) Received: from localhost (host-213-179-129-39.customer.m-online.net. [213.179.129.39]) by smtp.gmail.com with ESMTPSA id z1-20020adff1c1000000b002cea8e3bd54sm7137333wro.53.2023.03.16.05.20.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Mar 2023 05:20:04 -0700 (PDT) Date: Thu, 16 Mar 2023 13:20:03 +0100 From: Jiri Pirko To: Vadim Fedorenko Cc: Jakub Kicinski , Arkadiusz Kubalewski , Jonathan Lemon , Paolo Abeni , Vadim Fedorenko , poros@redhat.com, mschmidt@redhat.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, Milena Olech , Michal Michalik Subject: Re: [PATCH RFC v6 2/6] dpll: Add DPLL framework base functions Message-ID: References: <20230312022807.278528-1-vadfed@meta.com> <20230312022807.278528-3-vadfed@meta.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230312022807.278528-3-vadfed@meta.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230316_052008_815183_323864FE X-CRM114-Status: UNSURE ( 7.18 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Sun, Mar 12, 2023 at 03:28:03AM CET, vadfed@meta.com wrote: [...] >+/** >+ * dpll_pin_unregister - deregister dpll pin from dpll device >+ * @dpll: registered dpll pointer >+ * @pin: pointer to a pin >+ * >+ * Note: It does not free the memory >+ */ >+int dpll_pin_unregister(struct dpll_device *dpll, struct dpll_pin *pin) Make this return void. Function does not report anything useful, non-0 is only in case of WARN_ON. Nobody is going to check that ever anyway. >+{ >+ if (WARN_ON(xa_empty(&dpll->pin_refs))) >+ return -ENOENT; >+ >+ mutex_lock(&dpll_device_xa_lock); >+ mutex_lock(&dpll_pin_xa_lock); >+ __dpll_pin_unregister(dpll, pin); >+ mutex_unlock(&dpll_pin_xa_lock); >+ mutex_unlock(&dpll_device_xa_lock); >+ >+ return 0; >+} >+EXPORT_SYMBOL_GPL(dpll_pin_unregister); [...] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel