From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CD284C6FD1F for ; Thu, 16 Mar 2023 12:38:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=S9NrnhQXhAtPjI7iAHEnmaOq80upYWB2KnXtjHulwS8=; b=FXTPe7XbK2pA1W Dpz8647jjfwinyycqyTPz8uNZWINdaceuAR6GSIwA+t76IMP3JZS6niYUnyAjOFX2aExn8lckJRKR 3BEr/V0SXabfwdxqeXTymnapMwF5qVb6DuQ/aIOlprfkOLTyJ1C/bY26FuPEGC6E8rLh06G/m/yDR VEBn/zVJOdzP2ifFdF8VAEFKFyCybQQ9FX/nYgW2rqzg7J6BYmsG8yG8Ywjb3D+wdISqKsr43FLpx Q1TWmgX9qAmta/9eubsejldjwlyM6fE86oPkDoFf+Eb1Soy06mrnMaVLZZV69y4RRe8S17ZlEvfG4 DA7ohCV7yTNhqXpt2yqw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pcmrH-00GPe1-0T; Thu, 16 Mar 2023 12:37:27 +0000 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pcmrE-00GPdG-0Q for linux-arm-kernel@lists.infradead.org; Thu, 16 Mar 2023 12:37:25 +0000 Received: by mail-wm1-x32a.google.com with SMTP id bh21-20020a05600c3d1500b003ed1ff06fb0so1015317wmb.3 for ; Thu, 16 Mar 2023 05:37:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20210112.gappssmtp.com; s=20210112; t=1678970240; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=514h8Ll5c2ZEp3l/zYfk/oJdo5XaAivqw3cyq8ZPZSw=; b=bhaldaQm/jln74qCapYv4qWtRbz2JpUYOl7nJhAgaRQtWdo0utw7U6PPRr/WNU9ooN dkviyz7Feenie0jg+2ekmn/dWx/Fvr8ASEBufpH0kVO7bGe0a/TCqqi2je96INnirGao qRHprIeFmDro+yQ8ZfoxolaTbKIN+QKK1sYR28doKNZBTfrVXQ7H7PG+w2HtORe2FtOw 0XTbf76G0iwlvLQLjZBfn0KPaUTyWnP63Coa861PBv+ck/cPuBT7VI5C2BbaFIxdIaba ciP8KUOHfcmZ2Xui2StYR/UfxTJlKHcIAB0bPA9r+dr1P/ZLsLRCKCGXkhmJWf2YEend 5MCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678970240; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=514h8Ll5c2ZEp3l/zYfk/oJdo5XaAivqw3cyq8ZPZSw=; b=BBSR2X307cwOOh7cWmlXavkNBZilLrB+2w1kCLukS11Qf6bsrFp26Z8hJ7LZ94RYIA GwThODTxGa/pgneg1Jba2hzhcIthO7UFPgeA+xZG9TovaBR2z8VKrEsOcCwI75tMld8Z agfeVOFUzVQGiMhKCPO2zae8zlqUZrPc5vS/o4f98DNQMxQg5mbeW+6L2911H2hR6DZa IJeOU7dXfTvR0r6W9iy5Q+esupeF5SXy+oX0QzuINKeCQT+1CyHD+DwY0AVVR+lSgZTA RngDIsChLytRy0b6On9vHjmgmGlMhNNZF505KgaaNBpDR5v7QmqAFcwoqSJC9k2aRYty 8Law== X-Gm-Message-State: AO0yUKXy0316UJmk8UOQXZ3+vDVFpceGAsth7p4DZCKHVEEMk9Fdu0ad BgDZjEy9i/G3VYPe4lZAffALqA== X-Google-Smtp-Source: AK7set8ekJppoTaEs+bnyNw+oQE2sm8fXEl7zubfiVhYZ+bLOFl9uW5yvLguLiixXLXTFVdWY1gnVQ== X-Received: by 2002:a05:600c:ccf:b0:3eb:36fa:b78d with SMTP id fk15-20020a05600c0ccf00b003eb36fab78dmr21637699wmb.23.1678970240433; Thu, 16 Mar 2023 05:37:20 -0700 (PDT) Received: from localhost (host-213-179-129-39.customer.m-online.net. [213.179.129.39]) by smtp.gmail.com with ESMTPSA id k3-20020a7bc403000000b003ed1f69c967sm4950954wmi.9.2023.03.16.05.37.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Mar 2023 05:37:19 -0700 (PDT) Date: Thu, 16 Mar 2023 13:37:18 +0100 From: Jiri Pirko To: Vadim Fedorenko Cc: Jakub Kicinski , Arkadiusz Kubalewski , Jonathan Lemon , Paolo Abeni , Vadim Fedorenko , poros@redhat.com, mschmidt@redhat.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, Milena Olech , Michal Michalik Subject: Re: [PATCH RFC v6 2/6] dpll: Add DPLL framework base functions Message-ID: References: <20230312022807.278528-1-vadfed@meta.com> <20230312022807.278528-3-vadfed@meta.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230312022807.278528-3-vadfed@meta.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230316_053724_171602_28902BFB X-CRM114-Status: UNSURE ( 6.92 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Sun, Mar 12, 2023 at 03:28:03AM CET, vadfed@meta.com wrote: [...] >+struct dpll_pin * >+dpll_pin_alloc(u64 clock_id, u8 device_drv_id, struct module *module, >+ const struct dpll_pin_properties *prop) >+{ >+ struct dpll_pin *pin; >+ int ret; >+ >+ pin = kzalloc(sizeof(*pin), GFP_KERNEL); >+ if (!pin) >+ return ERR_PTR(-ENOMEM); >+ pin->dev_driver_id = device_drv_id; >+ pin->clock_id = clock_id; >+ pin->module = module; >+ refcount_set(&pin->refcount, 1); >+ if (WARN_ON(!prop->description)) { Why is this mandatory? I'm now working on mlx5 implementation, don't really know what to put here for SyncE. The type of the pin SyncE tells all I need. I would like to avoid description fill-up. >+ ret = -EINVAL; >+ goto release; >+ } >+ pin->prop.description = kstrdup(prop->description, GFP_KERNEL); >+ if (!pin->prop.description) { >+ ret = -ENOMEM; >+ goto release; >+ } [...] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel