From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 37D91C6FD19 for ; Thu, 16 Mar 2023 13:54:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0ypPAgur+XqaEl9pDARdCP6Kt1V8jl9/IVQOgrePMc0=; b=syqno2KAqZ6A7u TpLIM7IgUZgygggVvT4aqsUDfHiUeypAkkSZtJINOTFh1NKp9dpP5aJz4Q7b1ICAaDbpci5L3jazp SvuxLpNI1fbcoCajc5uL4irsLPmMxffeVTderSi5HI7K37T3Os04auwbRglN4KynEZKh3ygqAvPSR daJ454FB2JYxy+gBt0YyQD2Il4AX2B8BqKw/7AwiOuNehI/bG/rvsos0kv1i1S76vrwxwULJAEWLc /mMINL8/Gt3WzI5eUxKMo1vZHOkel8L0/CaXeGGzSbbYKdJoCnIGxBXvsFES8EKMbprm/r28kzlsd Hc8j5IeFYmZI/S9cIOzQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pco3K-00GbO6-0T; Thu, 16 Mar 2023 13:53:58 +0000 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pco3E-00GbJk-0b for linux-arm-kernel@lists.infradead.org; Thu, 16 Mar 2023 13:53:53 +0000 Received: by mail-wm1-x32b.google.com with SMTP id o11-20020a05600c4fcb00b003eb33ea29a8so1206188wmq.1 for ; Thu, 16 Mar 2023 06:53:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20210112.gappssmtp.com; s=20210112; t=1678974827; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=tJUkcR5TLj/pckcV8NLJv4p0N2ALJ8mExf2txWHqrmk=; b=wWYYJ+ypcPdJWK8mFMkmqjjTg/4tNQcs0l/VDlsiczG9njmrsHE+8e2lHla18Brgd9 KH7eoUQG5yA5+ddWujlQEuiA1U+UbeBjJOkWb92cpyhwyt2nLoXbIItaXQ6DkpA1riAH 71uscclX9xlwsyG59l3cAyXvVnDJKd06TT5lHUfP1WVX/V+Ef9nIpmMHoMNzkAdGgE1u e+IFUWiMCBhjNJ1fSBWMBn6CykaHsiGAGNrxX8P+bYwLu/vUSURlzV4k3EArtB4VIthU nPGwF6G/A684ROdz1Dk1ew3/Ic1YeDs5ZvIkmCtlpdOYPsKxd7/0xJubMZ+QGvzMcpWd FuFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678974827; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=tJUkcR5TLj/pckcV8NLJv4p0N2ALJ8mExf2txWHqrmk=; b=X/CnG937Xlu9Dv6XY1NmaAR1yXpFd8yUYYzMMDkJhcu7UQN0k9aPqDZ53SpGfvI9AS wYa+r4GZBASOcpSoF8P/CVVVCS0vEkdLocRcAYh5LffGxaaMg2xpRnxKtgXNwXEcdO0n 6sQnXqTTEKnG0N0Gv4qyOJxqBtPMBKojkl3aikatvUafEet4O35WxmlMGeOAUugsLKDC y8UWKZVSzqSy9afJA0ezc9kz24hFQsE+GyzO8aTckesrSYNxoLg+Op15SRIL+ZJhB6xm vKfTOWnTdDVEnSq4s58OKYKF9KOf7dgF4/+/0g5D25pA1Sh8eZj5Nkus6y9VqgtAuOI0 tysQ== X-Gm-Message-State: AO0yUKVz5qUE+MZ+kLXkOtPAmOqjn6wbzzm6FXjnP4PjX33uILNIcect FnCDJdqHuQxsKLgM1Xn3BARpGg== X-Google-Smtp-Source: AK7set+rqXMflrFeUbInvbGJbf4bdkNqSmGD9Ehmghl2MY/AZ9NJO7HEaQFrvUB9p731GmxgmKdHZg== X-Received: by 2002:a05:600c:35ce:b0:3e2:1368:e3a0 with SMTP id r14-20020a05600c35ce00b003e21368e3a0mr22297978wmq.18.1678974827774; Thu, 16 Mar 2023 06:53:47 -0700 (PDT) Received: from localhost (host-213-179-129-39.customer.m-online.net. [213.179.129.39]) by smtp.gmail.com with ESMTPSA id p3-20020a05600c358300b003ed2eb5c2dcsm5370341wmq.43.2023.03.16.06.53.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Mar 2023 06:53:47 -0700 (PDT) Date: Thu, 16 Mar 2023 14:53:46 +0100 From: Jiri Pirko To: Vadim Fedorenko Cc: Jakub Kicinski , Arkadiusz Kubalewski , Jonathan Lemon , Paolo Abeni , Vadim Fedorenko , poros@redhat.com, mschmidt@redhat.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, Milena Olech , Michal Michalik Subject: Re: [PATCH RFC v6 2/6] dpll: Add DPLL framework base functions Message-ID: References: <20230312022807.278528-1-vadfed@meta.com> <20230312022807.278528-3-vadfed@meta.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230312022807.278528-3-vadfed@meta.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230316_065352_224658_8146F8A8 X-CRM114-Status: UNSURE ( 6.22 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Sun, Mar 12, 2023 at 03:28:03AM CET, vadfed@meta.com wrote: [...] >+ int (*state_on_pin_get)(const struct dpll_pin *pin, >+ const struct dpll_pin *parent_pin, >+ enum dpll_pin_state *state, >+ struct netlink_ext_ack *extack); >+ int (*state_on_dpll_get)(const struct dpll_pin *pin, >+ const struct dpll_device *dpll, >+ enum dpll_pin_state *state, >+ struct netlink_ext_ack *extack); Could this be rather called "state_on_device_get" or perhaps even better just "state_get" (in sync with "prio_set/get") ? This "od dpll" is a bit confusing, there is no such object. We have "device" and "pin". >+ int (*state_on_pin_set)(const struct dpll_pin *pin, >+ const struct dpll_pin *parent_pin, >+ const enum dpll_pin_state state, >+ struct netlink_ext_ack *extack); >+ int (*state_on_dpll_set)(const struct dpll_pin *pin, >+ const struct dpll_device *dpll, >+ const enum dpll_pin_state state, >+ struct netlink_ext_ack *extack); [...] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel