From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 390F2C7618A for ; Thu, 16 Mar 2023 19:37:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=dEoWVEkYdZWPV48pLmxcny6Fcu4wwQl1Z6eeGQoiE8Y=; b=BXGlmQHsZHOrSv4GRpLC9Xikc0 fqiSMukghRplb67oZ8jJc3JTFTYb01TZEIdJXsWULdxhRQDIneNVLgpaKD9K94wDq1b1zi9aywYz3 x5zhlwl/ISpwoNKBvvfU2yo+19S0cQ2Vv5QUDbfjdc9rNOVgwHKG/8uwFs/Qa/LzSWHYnFpq3L0Gy 0lJ5cx/LsPTdqQHP6tXb3SUnbrOx2KAB8k4WQZgKZHcK/baD25YZ/TczVk8amnvJie/86obEOx3Y9 wTXSvRnbx3cZbw0o1rUd5Y27T10uUZlbbDDp2/P13buUBZDHPmFgZNZ/L2+FWTCU2mAUM0cPh02lE DQE/NOCQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pctOz-00HNxk-38; Thu, 16 Mar 2023 19:36:41 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pctOn-00HNvR-1f for linux-arm-kernel@lists.infradead.org; Thu, 16 Mar 2023 19:36:30 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 310F0620DC; Thu, 16 Mar 2023 19:36:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6BC94C433D2; Thu, 16 Mar 2023 19:36:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678995388; bh=jb2nzpatP7O5jIKb6JL0QWGvch9PFBPZozV5+PbWU2g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IWeb9mWETpl45M2YMdMNjenvVcI6zXSfbfWLPc1l7at+YySRspzAIywgnsdPtcShw NnZFII99HXO8f/uWxelG5WstEwlY7udBCnIsQGIvq6MRX0/19Al+EraKy8f84D5AHe +NlKP42RErlE+ceHPKaR0cjnMF2vS9h1CINZ7ezVIk4sSDPd+HupyoKGoehUZFog+x 0GbTax54yMdYf5nC45RO4r7u6QHW+pFVt8JQByapn2MPyaAMFBrcz2K+SDpVjkalN6 cOM3N03q4qURPQxf4my+l/nATtckrZRaDs++LUsKTbb7kT4eEoXiFIRNwJzbULCUhz gi7gM/sQ9IugA== Date: Thu, 16 Mar 2023 20:36:24 +0100 From: Wolfram Sang To: Alexander Stein Cc: Dong Aisheng , Shawn Guo , Sascha Hauer , Fabio Estevam , NXP Linux Team , Pengutronix Kernel Team , linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/2] i2c: imx-lpi2c: check only for enabled interrupt flags Message-ID: Mail-Followup-To: Wolfram Sang , Alexander Stein , Dong Aisheng , Shawn Guo , Sascha Hauer , Fabio Estevam , NXP Linux Team , Pengutronix Kernel Team , linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20230130153247.445027-1-alexander.stein@ew.tq-group.com> <20230130153247.445027-2-alexander.stein@ew.tq-group.com> MIME-Version: 1.0 In-Reply-To: <20230130153247.445027-2-alexander.stein@ew.tq-group.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230316_123629_593892_76604AC0 X-CRM114-Status: GOOD ( 14.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============6468863043567163883==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============6468863043567163883== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="nfFpViwYTWQzz58Q" Content-Disposition: inline --nfFpViwYTWQzz58Q Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 30, 2023 at 04:32:47PM +0100, Alexander Stein wrote: > When reading from I2C, the Tx watermark is set to 0. Unfortunately the > TDF (transmit data flag) is enabled when Tx FIFO entries is equal or less > than watermark. So it is set in every case, hence the reset default of 1. > This results in the MSR_RDF _and_ MSR_TDF flags to be set thus trying > to send Tx data on a read message. > Mask the IRQ status to filter for wanted flags only. >=20 > Fixes: a55fa9d0e42e ("i2c: imx-lpi2c: add low power i2c bus driver") > Signed-off-by: Alexander Stein Applied to for-current, thanks! --nfFpViwYTWQzz58Q Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmQTb7gACgkQFA3kzBSg KbYQFA/9EpQdG+HGWv5f3ofh9Ibz7E+0GVXuqqqZy5KLxeHDcDEQLYHUwfIY08RO niM35lxKezU6aBsLnPY44Ul+EU3iTitHy/IfzDUmxec6U3UoFiY9L1hCFYjvN/vc qbmr4Jl48Xitn4UdSzdvXtfKbZBRwHLGCRLBYIGd1wQvQqGSILKLW1kF/i1oNleg FQ4kDOx+Kci7RMG6PDQPnEkAss2/PUkL7PFUQMf3KZ2d9iR7kmS1RvlifNk2oHn8 YoimKa3d+moiSYiRPFB9uu+XL9BVBTDST8IXAiZIovX81mwSHfltK45Fw1pBDwEV oRAegRVjGkzgbddQ5SCQEu5oHRhNGDft0LSA8JCkBKprwektHFt1tBLJ47amDULj A4QmJTOJqEInxfpftb+CgLxoFKIlnjIqePc8vQL4zh+rgilXYgwjzhoCxnm0TfaG tM6Zj5Ml9u+zBsIxquOYxe/dCSrIx2dC7UO9cHZeXfCv5j8YkMnh80JQeVpnL1z5 HKy9KVy93hNhzFjnPXs//TkpN6ptiJajV05f8aDINEuT0pSoGixTwxxs7F2zeM1/ sO1QA4MRAIKNGRZTlMHfZQSVvio0kLJe4pcbB+AsDgZ/QlJifaTDfveYsE+/iD0T e3IUW7s+PActLFH4kLSUIijxetkxnzXzXgg5ydWwKeoiVvbIUHA= =aABt -----END PGP SIGNATURE----- --nfFpViwYTWQzz58Q-- --===============6468863043567163883== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============6468863043567163883==--