From: Chester Lin <clin@suse.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "Linus Walleij" <linus.walleij@linaro.org>,
"NXP S32 Linux Team" <s32@nxp.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
"Ghennadi Procopciuc" <Ghennadi.Procopciuc@oss.nxp.com>,
"Andrei Stefanescu" <andrei.stefanescu@nxp.com>,
"Radu Pirea" <radu-nicolae.pirea@nxp.com>,
"Andreas Färber" <afaerber@suse.de>,
"Matthias Brugger" <mbrugger@suse.com>
Subject: Re: [PATCH 0/3] pinctrl: s32: driver improvements and generic struct use
Date: Fri, 17 Mar 2023 11:45:21 +0800 [thread overview]
Message-ID: <ZBPiUTFRFry/BAqR@linux-8mug> (raw)
In-Reply-To: <CAHp75Ve=U_rkgL6ohpy1r4RejXK-PqgrqfkPmCrhzK9O3necnw@mail.gmail.com>
Hi Andy,
On Tue, Mar 14, 2023 at 07:21:55PM +0200, Andy Shevchenko wrote:
> On Tue, Mar 14, 2023 at 3:46 PM Chester Lin <clin@suse.com> wrote:
> >
> > Hello,
> >
> > This patch series contains some improvements for s32 pinctrl drivers suggested
> > by upstream[1], such as
> >
> > - Fix error shadowings and improve return value handlings.
> > - Fix print format.
> > - Remove unnecessary blanks.
> > - Use proper macros and helpers to simplify codes.
> > - Refactor config param parsing and remove config arguments that are never used.
> > - Use generic struct pingroup and struct pinfunction to describe pin data.
>
> Overall it looks not bad, thank you for doing this.
> Individual patches have been reviewed and commented accordingly.
Thank you for reviewing this patch. I will fix the rest in v2 soon.
Regards,
Chester
>
> --
> With Best Regards,
> Andy Shevchenko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2023-03-17 3:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 13:46 [PATCH 0/3] pinctrl: s32: driver improvements and generic struct use Chester Lin
2023-03-14 13:46 ` [PATCH 1/3] pinctrl: s32: refine error/return/config checks and simplify driver codes Chester Lin
2023-03-14 17:08 ` Andy Shevchenko
2023-03-14 13:46 ` [PATCH 2/3] pinctrl: s32cc: refactor pin config parsing Chester Lin
2023-03-14 17:15 ` Andy Shevchenko
2023-03-14 13:46 ` [PATCH 3/3] pinctrl: s32cc: embed generic struct pingroup and pinfunction Chester Lin
2023-03-14 17:19 ` Andy Shevchenko
2023-03-14 17:21 ` [PATCH 0/3] pinctrl: s32: driver improvements and generic struct use Andy Shevchenko
2023-03-17 3:45 ` Chester Lin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBPiUTFRFry/BAqR@linux-8mug \
--to=clin@suse.com \
--cc=Ghennadi.Procopciuc@oss.nxp.com \
--cc=afaerber@suse.de \
--cc=andrei.stefanescu@nxp.com \
--cc=andy.shevchenko@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mbrugger@suse.com \
--cc=radu-nicolae.pirea@nxp.com \
--cc=s32@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).