* [PATCH net-next] net: ethernet: ti: am65-cpts: reset pps genf adj settings on enable
@ 2023-03-16 9:52 Siddharth Vadapalli
2023-03-17 11:27 ` Roger Quadros
2023-03-18 5:50 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 4+ messages in thread
From: Siddharth Vadapalli @ 2023-03-16 9:52 UTC (permalink / raw)
To: davem, edumazet, kuba, pabeni, rogerq, jacob.e.keller
Cc: netdev, linux-kernel, linux-arm-kernel, srk, s-vadapalli
From: Grygorii Strashko <grygorii.strashko@ti.com>
The CPTS PPS GENf adjustment settings are invalid after it has been
disabled for a while, so reset them.
Fixes: eb9233ce6751 ("net: ethernet: ti: am65-cpts: adjust pps following ptp changes")
Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>
---
drivers/net/ethernet/ti/am65-cpts.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/ethernet/ti/am65-cpts.c b/drivers/net/ethernet/ti/am65-cpts.c
index 16ee9c29cb35..8caf85acbb6a 100644
--- a/drivers/net/ethernet/ti/am65-cpts.c
+++ b/drivers/net/ethernet/ti/am65-cpts.c
@@ -636,6 +636,10 @@ static void am65_cpts_perout_enable_hw(struct am65_cpts *cpts,
val = lower_32_bits(cycles);
am65_cpts_write32(cpts, val, genf[req->index].length);
+ am65_cpts_write32(cpts, 0, genf[req->index].control);
+ am65_cpts_write32(cpts, 0, genf[req->index].ppm_hi);
+ am65_cpts_write32(cpts, 0, genf[req->index].ppm_low);
+
cpts->genf_enable |= BIT(req->index);
} else {
am65_cpts_write32(cpts, 0, genf[req->index].length);
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH net-next] net: ethernet: ti: am65-cpts: reset pps genf adj settings on enable
2023-03-16 9:52 [PATCH net-next] net: ethernet: ti: am65-cpts: reset pps genf adj settings on enable Siddharth Vadapalli
@ 2023-03-17 11:27 ` Roger Quadros
2023-03-17 12:30 ` Michal Swiatkowski
2023-03-18 5:50 ` patchwork-bot+netdevbpf
1 sibling, 1 reply; 4+ messages in thread
From: Roger Quadros @ 2023-03-17 11:27 UTC (permalink / raw)
To: Siddharth Vadapalli, davem, edumazet, kuba, pabeni,
jacob.e.keller
Cc: netdev, linux-kernel, linux-arm-kernel, srk
On 16/03/2023 11:52, Siddharth Vadapalli wrote:
> From: Grygorii Strashko <grygorii.strashko@ti.com>
>
> The CPTS PPS GENf adjustment settings are invalid after it has been
> disabled for a while, so reset them.
>
> Fixes: eb9233ce6751 ("net: ethernet: ti: am65-cpts: adjust pps following ptp changes")
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
> Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>
Reviewed-by: Roger Quadros <rogerq@kernel.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net-next] net: ethernet: ti: am65-cpts: reset pps genf adj settings on enable
2023-03-17 11:27 ` Roger Quadros
@ 2023-03-17 12:30 ` Michal Swiatkowski
0 siblings, 0 replies; 4+ messages in thread
From: Michal Swiatkowski @ 2023-03-17 12:30 UTC (permalink / raw)
To: Roger Quadros
Cc: Siddharth Vadapalli, davem, edumazet, kuba, pabeni,
jacob.e.keller, netdev, linux-kernel, linux-arm-kernel, srk
On Fri, Mar 17, 2023 at 01:27:36PM +0200, Roger Quadros wrote:
>
>
> On 16/03/2023 11:52, Siddharth Vadapalli wrote:
> > From: Grygorii Strashko <grygorii.strashko@ti.com>
> >
> > The CPTS PPS GENf adjustment settings are invalid after it has been
> > disabled for a while, so reset them.
> >
> > Fixes: eb9233ce6751 ("net: ethernet: ti: am65-cpts: adjust pps following ptp changes")
> > Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
> > Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>
>
> Reviewed-by: Roger Quadros <rogerq@kernel.org>
Small nit for the future: should be [PATCH net] instead of net-next when
You sending fixes.
Looks fine, thanks
Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] net: ethernet: ti: am65-cpts: reset pps genf adj settings on enable
2023-03-16 9:52 [PATCH net-next] net: ethernet: ti: am65-cpts: reset pps genf adj settings on enable Siddharth Vadapalli
2023-03-17 11:27 ` Roger Quadros
@ 2023-03-18 5:50 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-03-18 5:50 UTC (permalink / raw)
To: Siddharth Vadapalli
Cc: davem, edumazet, kuba, pabeni, rogerq, jacob.e.keller, netdev,
linux-kernel, linux-arm-kernel, srk
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Thu, 16 Mar 2023 15:22:32 +0530 you wrote:
> From: Grygorii Strashko <grygorii.strashko@ti.com>
>
> The CPTS PPS GENf adjustment settings are invalid after it has been
> disabled for a while, so reset them.
>
> Fixes: eb9233ce6751 ("net: ethernet: ti: am65-cpts: adjust pps following ptp changes")
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
> Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>
>
> [...]
Here is the summary with links:
- [net-next] net: ethernet: ti: am65-cpts: reset pps genf adj settings on enable
https://git.kernel.org/netdev/net/c/3dacc5bb8147
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-03-18 5:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-16 9:52 [PATCH net-next] net: ethernet: ti: am65-cpts: reset pps genf adj settings on enable Siddharth Vadapalli
2023-03-17 11:27 ` Roger Quadros
2023-03-17 12:30 ` Michal Swiatkowski
2023-03-18 5:50 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).