From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 97E8AC74A5B for ; Fri, 17 Mar 2023 16:11:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KEsUxLBBBthz0081rdbouAmLxIqvlC0gZmHFHAv3PIQ=; b=WnRBHqAQdStYLJ EU6beZnQHtqv1+9W5VWJkUKi+40JPoeFSEFB8iXjVpREKt06TIJ20ntNHutMS8L2aBNMhUqj7iVby 7XUXue43uECmVrOWpFv+gYNUyNwWFYeaZU9KXevcmwBk7Y8yIJhHDpO/7YdksoTmGdIfk+/Seo0qY /fT8+eyselhmww9IeFe/adEW0opCjb6YHYbYOOM/tBQHBqfuX28ndH/fg1mvHAAR2RKTADl4pk28s jDA07n+dz79OEz3hBaw98DtDSQtIBBeY0axBlpUBdKxFbn5VA8Xj1nCIO9S/VOdm5d7R4MJOqf+UO Pywqk+oT1g95zPfhEGww==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pdCel-002ijW-1V; Fri, 17 Mar 2023 16:10:15 +0000 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pdCeh-002iik-0d for linux-arm-kernel@lists.infradead.org; Fri, 17 Mar 2023 16:10:13 +0000 Received: by mail-wr1-x436.google.com with SMTP id y14so4924284wrq.4 for ; Fri, 17 Mar 2023 09:10:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20210112.gappssmtp.com; s=20210112; t=1679069407; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=UjzDxDVWXiH7vDhwwdNksFwW7YtaxEhKuy7mNkKU/kY=; b=WLtYCSEw6QZI9xCr3EfpQa/4pvjbN6mMOrCWKnyFC71zf7OLUE1vSzp76q1DKeOLvA A5qVA3aHYRzDHcj5adEuiwVislL78m8zLrH2E3NYuaZcwvkeXjtwy4jRS7z+aAl0j6d4 nmvscTrM2Ogf1O2YqX9qmjinE3f/dNi+OoHbbO0tWhqeSf4Vul2FtoeqqosCN0fShjQo GZ0M2gGrqJDRHKU/H4YfV18sjgP5QMSaroqqjz7dyEPtPhCQ3HxaatLICuvI0wXSK/m1 /gyTlC4AXPR6wQIEKFs2h9P5r4WId/zJqdXfYiGdeZteSvQSdijhbZ58jGgpTRWz/eRX 6/VA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679069407; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=UjzDxDVWXiH7vDhwwdNksFwW7YtaxEhKuy7mNkKU/kY=; b=cpNK+eGJqzJ/ClqW9i4BiOPdjwla0a9WUfqZVAy67phxQUeHmrO8MB/xqDUf56FPYk sLzdGUJuWvY+PbDKjWX3Tf5R8bqiwkjjwmw+dbeoOl806S9lb3I6EcoIyOlj5dVfb1zZ qKyzrmd2nGqM6WryeZ82b1YsxPSNXxQfXyBYRP3PIpz20tsx/H4OMiEEuqJVQphGyXvH HK7x7AuqAGfU/Huew/+f6cc2qafltGSgaRwditUmGCy97/QSm9AUQNftkc1um+ZgW5Ux CWDhNR3J1fuCYBj6yP6CLVk1K399L/FlPmusatv4t336t8C05qm/LMn3cOBIyOjGktya ypzg== X-Gm-Message-State: AO0yUKXlTGvJkt2cWEi2jo9BBb8hrzjsT6hUViaaAoSfBeNtXfUzMFVJ TEHC3Sr5IWj4bXkWQE6EqR47pw== X-Google-Smtp-Source: AK7set93hypJDsMm1enAfIZg8215eCAIhP4PBJcZFx0zQJdvHMFklrJCpfni543ui1ToxFKL4ckHKw== X-Received: by 2002:a05:6000:12c5:b0:2ce:a8f9:7cae with SMTP id l5-20020a05600012c500b002cea8f97caemr7964173wrx.53.1679069406830; Fri, 17 Mar 2023 09:10:06 -0700 (PDT) Received: from localhost (host-213-179-129-39.customer.m-online.net. [213.179.129.39]) by smtp.gmail.com with ESMTPSA id y1-20020a5d4ac1000000b002ceaeb24c0asm2303163wrs.58.2023.03.17.09.10.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Mar 2023 09:10:05 -0700 (PDT) Date: Fri, 17 Mar 2023 17:10:04 +0100 From: Jiri Pirko To: Vadim Fedorenko Cc: Vadim Fedorenko , Jakub Kicinski , Arkadiusz Kubalewski , Jonathan Lemon , Paolo Abeni , poros@redhat.com, mschmidt@redhat.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org Subject: Re: [PATCH RFC v6 0/6] Create common DPLL/clock configuration API Message-ID: References: <20230312022807.278528-1-vadfed@meta.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230317_091011_428250_7527FEDB X-CRM114-Status: GOOD ( 11.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Mon, Mar 13, 2023 at 04:33:13PM CET, vadim.fedorenko@linux.dev wrote: >On 13/03/2023 12:20, Jiri Pirko wrote: >> Sun, Mar 12, 2023 at 03:28:01AM CET, vadfed@meta.com wrote: >> > Implement common API for clock/DPLL configuration and status reporting. >> > The API utilises netlink interface as transport for commands and event >> > notifications. This API aim to extend current pin configuration and >> > make it flexible and easy to cover special configurations. >> >> Could you please put here some command line examples to work with this? > >We don't have open-source tools ready right now for specific hardware, but >with YAML spec published you can use in-kernel tool to manipulate the values, >i.e.: > >./tools/net/ynl/cli.py --spec Documentation/netlink/specs/dpll.yaml --dump >device-get >./tools/net/ynl/cli.py --spec Documentation/netlink/specs/dpll.yaml --do >device-get --json '{"id": 0}' >./tools/net/ynl/cli.py --spec Documentation/netlink/specs/dpll.yaml --dump >pin-get >./tools/net/ynl/cli.py --spec Documentation/netlink/specs/dpll.yaml --do >pin-get --json '{"id": 0, "pin-idx":1}' >./tools/net/ynl/cli.py --spec Documentation/netlink/specs/dpll.yaml --do >pin-set --json '{"id":0, "pin-idx":1, "pin-frequency":1}' Interesting, is this working for you? I'm experiencing some issue with cmd value. Example: ./tools/net/ynl/cli.py --spec Documentation/netlink/specs/dpll.yaml --do device-get --json '{"id": 0}' this should send DPLL_CMD_DEVICE_GET which is 1. In kernel genl_family_rcv_msg() the hdr->cmd is 2 Any idea what might be wrong? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel