From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 953C7C6FD1D for ; Fri, 17 Mar 2023 16:22:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Y5B9OVv8/624NxFLukC2AgxZIfWLsaWs7nxgGlZsNq0=; b=ITaGUjHmr40edo OXEEerNDIPD7IqzYHHZpfjJ2O/FrtS40zzCU9QxEb5FAa+yL0v2obvQNCbBcsNR+F+bmNhrkrfOdv o3yM2ahpweKRxkeVCRH682q+GKFJUEk5aq2KD8Wsw5pS+O97d92Jt0G4+//Rg+e7eKuzRzc7Ohao+ QdgMVLy/Rjdc5r1yIG0+zgL+3sLMNq3NzSlUCZRCkWXrBuZetiYeOQIJuQFbe23M3HvAYlLEBQ3si ohdEdc3qUPayvN7+XlKuvQcM6mxyiWl2xPjXPNeY8VRKDgktMJ813Z2vXu7pcn6ZejBEbPyjM1AJS x/dN363LP18rO0h+aqSw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pdCqF-002kFg-18; Fri, 17 Mar 2023 16:22:07 +0000 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pdCqD-002kEX-0M for linux-arm-kernel@lists.infradead.org; Fri, 17 Mar 2023 16:22:06 +0000 Received: by mail-wm1-x32d.google.com with SMTP id bh21-20020a05600c3d1500b003ed1ff06fb0so3714068wmb.3 for ; Fri, 17 Mar 2023 09:22:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20210112.gappssmtp.com; s=20210112; t=1679070120; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=WK9yNSRVMlEjJBHOwhJwHBFPa8SNWqT9uE9ABk62B2U=; b=DG/fto1x98uQ7dSsGetIjYJWDexNDd5i4LfyYi7NUiz/WSFew62SHnWLIBzbeuVYJA PTxVBfS1gAOEUEiymezfy1LtBiNhWQOav3DpLy6ja3+l8BNlAJtDisQteOWEKOL/033d El5MmsPw4Of/YpfYhjCD52HU4YVV/Emc57hGz11Lkmwe/ttLSF5IYTlqkxYby+p5A7KE J6ZMSBeAVQSMC+5CH+jugzxU9DC9Bm01if+a2T2Rn72sjm/AuCE3jjzMpOqSWC74SJk9 hHuE3ZUuCkm548uyPlOxaNNc+RMfCf+DkSFe2q/m5SSxooUZIDIxjXz6U8W6uJFmICCL txOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679070120; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=WK9yNSRVMlEjJBHOwhJwHBFPa8SNWqT9uE9ABk62B2U=; b=hmweaMVNV9IfZSsKNdOSBjw92hHYnBvYyUizdCp70E2OaPvSywmco8IhK8ho02NDXN TzAkYjIfG+kVKhxjIIkvAtmUo1qGoLfHwbe4erjBdFztgHD9L5drMdWCtU3wG2XnqfOd yZw0lmRdzc6B4FbbU7lJxoNaLt0riAr24IiQHzU9qJUuGeE1K3+mVB88UoM/PZAmQUXV 1PQyLZedtrdBYkHOwdIt4V/ii+9FxVGyyzNhHlU6FGupe45CvtWrumCWqNnirnH9IW9G 0qRUApaZx7iQ/8x5d895pBGAfmpY2b1fNHoldNYybuKxWxCgqdzsq8TE8ys4LDr0YZTE TRGQ== X-Gm-Message-State: AO0yUKV0WNw+m65BOtPMJRqfersU2NbnO7gznT+e9N/CNVRJJw5U0XcS FwgmU+5iI8C8kacv2UtMFaJYkiypdK/++OaYYVI= X-Google-Smtp-Source: AK7set8HoNwwA1+/Xl56688DC6BYt9rhtjCtl5fanZOEjjmCrJBpY85I6piUWRSAGVEqRLFCTdji7w== X-Received: by 2002:a05:600c:1546:b0:3ed:22f2:554c with SMTP id f6-20020a05600c154600b003ed22f2554cmr18431844wmg.29.1679070120483; Fri, 17 Mar 2023 09:22:00 -0700 (PDT) Received: from localhost (host-213-179-129-39.customer.m-online.net. [213.179.129.39]) by smtp.gmail.com with ESMTPSA id q8-20020a1cf308000000b003ed4f6c6234sm2408743wmq.23.2023.03.17.09.21.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Mar 2023 09:21:59 -0700 (PDT) Date: Fri, 17 Mar 2023 17:21:58 +0100 From: Jiri Pirko To: Vadim Fedorenko Cc: Jakub Kicinski , Arkadiusz Kubalewski , Jonathan Lemon , Paolo Abeni , Vadim Fedorenko , poros@redhat.com, mschmidt@redhat.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, Milena Olech , Michal Michalik Subject: Re: [PATCH RFC v6 2/6] dpll: Add DPLL framework base functions Message-ID: References: <20230312022807.278528-1-vadfed@meta.com> <20230312022807.278528-3-vadfed@meta.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230312022807.278528-3-vadfed@meta.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230317_092205_149746_734C0590 X-CRM114-Status: UNSURE ( 6.27 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Sun, Mar 12, 2023 at 03:28:03AM CET, vadfed@meta.com wrote: [...] >+int dpll_nl_device_get_dumpit(struct sk_buff *skb, struct netlink_callback *cb) >+{ >+ struct nlattr *hdr, *nest; >+ struct dpll_device *dpll; >+ unsigned long i; >+ int ret; >+ >+ hdr = genlmsg_put(skb, NETLINK_CB(cb->skb).portid, cb->nlh->nlmsg_seq, >+ &dpll_nl_family, 0, DPLL_CMD_DEVICE_GET); >+ if (!hdr) >+ return -EMSGSIZE; >+ >+ xa_for_each_marked(&dpll_device_xa, i, dpll, DPLL_REGISTERED) { >+ nest = nla_nest_start(skb, DPLL_A_DEVICE); >+ ret = dpll_msg_add_dev_handle(skb, dpll); >+ if (ret) { >+ nla_nest_cancel(skb, nest); >+ break; >+ } Please fillup the attrs for the object. The format should be exactly the same as for doit. >+ nla_nest_end(skb, nest); >+ } >+ if (ret) >+ genlmsg_cancel(skb, hdr); >+ else >+ genlmsg_end(skb, hdr); >+ >+ return ret; >+} >+ [...] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel