From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9F2E5C74A5B for ; Fri, 17 Mar 2023 20:58:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EOUuL/CpGnNSgeTDVvRiy8tT9+ptF4yuL97mYJZZq/M=; b=lcsNxAq5OtFWf2 LcjGcE3igyX66Tt5b2NIrE3t29ooM6uzy43T5yhTxOKrZ3GVuxTXpLzvZNan/umVsOla63p39/SoV EXxhfP80VAKEVjaw/u0lDvRShwrLvqXAWgsbvXjQ3V+dbrrdqcrxBBmO4JPhfbQ+VvOyVbPB3WbZ8 SdIbM6PY3FTLdfhFQa/TTU7mI3tmgeDWYI/yGr0TWocPER8igOnl/IXBS6v/RdkYpQacEo8IUuCmM yTW7cIOUFYGz/TqWsEDc3CNbZ0uWBnSQhsXgflApHkMpR9ZqZTHyZuJ1qtROmVSYwrZVWxc1AV1sG ScWmlGt3/Z2Cu9pT9Cng==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pdH9I-003NGS-2V; Fri, 17 Mar 2023 20:58:04 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pdH9F-003NF7-1i for linux-arm-kernel@lists.infradead.org; Fri, 17 Mar 2023 20:58:02 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=dZeWiRhjX2jTc6AkO+17VmA9bj/Bj3rR/73GUR3OEW4=; b=IO/VVsx2D9PvqNqMwcSg/mPkeh vu5KPNie2nPo1nelTEi4mumhG1/k4XJkbVPXA3NgUGhz6aq+sNHwzq4mHHnuoUwgRjZY7L+eSSpkz iDGfAmwREQTpsVT41OjhnF0s95Xbzxlm594QPFtyTSttqZO+GIutg1AIKAUjJYdBLtKHrGZfg4LQX FX/jreGLqVFpgdeBeMKmQkT748OA5ELDA1vu4x0SE63krhv35+Q09L93VzTXK5FnSj6t2oV0tB4YM St7NZC4tkYCNht4tfHkS3CU/oHtBWUhwAi0mRFrofWJEKBs/uvJxTN3URflAFRPktjDXAWBWBhbTD S+qo3zIQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:56108) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pdH94-0003TX-At; Fri, 17 Mar 2023 20:57:50 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1pdH92-0003mq-JK; Fri, 17 Mar 2023 20:57:48 +0000 Date: Fri, 17 Mar 2023 20:57:48 +0000 From: "Russell King (Oracle)" To: Andrew Lunn Cc: Michael Sit Wei Hong , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Ong Boon Leong , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Looi Hong Aun , Voon Weifeng , Lai Peter Jun Ann Subject: Re: [PATCH net v2 1/2] net: stmmac: fix PHY handle parsing Message-ID: References: <20230314070208.3703963-1-michael.wei.hong.sit@intel.com> <20230314070208.3703963-2-michael.wei.hong.sit@intel.com> <10aff941-e18a-4d77-974b-1760529988a6@lunn.ch> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <10aff941-e18a-4d77-974b-1760529988a6@lunn.ch> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230317_135801_570426_20981B42 X-CRM114-Status: GOOD ( 15.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Mar 17, 2023 at 08:56:19PM +0100, Andrew Lunn wrote: > On Tue, Mar 14, 2023 at 03:02:07PM +0800, Michael Sit Wei Hong wrote: > > phylink_fwnode_phy_connect returns 0 when set to MLO_AN_INBAND. > > This causes the PHY handle parsing to skip and the PHY will not be attached > > to the MAC. > > Please could you expand the commit message because i'm having trouble > following this. > > phylink_fwnode_phy_connect() says: > > /* Fixed links and 802.3z are handled without needing a PHY */ > if (pl->cfg_link_an_mode == MLO_AN_FIXED || > (pl->cfg_link_an_mode == MLO_AN_INBAND && > phy_interface_mode_is_8023z(pl->link_interface))) > return 0; > > So your first statement is not true. It should be MLO_AN_INBAND > and phy_interface_mode_is_8023z. > > > Add additional check for PHY handle parsing when set to MLO_AN_INBAND. > > Looking at the patch, there is no reference to MLO_AN_INBAND, or > managed = "in-band-status"; That's the pesky "xpcs_an_inband" which ends up as phylink's "ovr_an_inband"... I'm sure these are random renames of stuff to make sure that people struggle to follow the code. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel