From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 44B16C7618A for ; Mon, 20 Mar 2023 10:25:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=leyw3FvnS745mNTVrkHneFXijgq6/14ozOBZyPAOVV0=; b=VfolFp0SGVyLxU EysKOTTVa2m0L2CxJxqPmD4Z6CzveX/anmeTsq2kEYqLb6N+MllV3lwSZJLdAZBsOO+n16thFAGz2 uRHAtZRpj2cgRf6CNopZkEE9I+FFJ3MmLDbOWuEpXu85Ec5yAe9HV4R312sa3A950FVcFX5ByaldB 6Pqjp+Morh5hbHUbQ9AGCc2nmFZ2q2qlmYJHy6DGsg3iUvznnSWmH2Qgk7VrcNLYnAoMZCMdfopX6 eB4+WkkgeReSQYQdYIxsK2IVG0kfFUnTJvtdHBPKjIziSqUWCtvueoBZit4CvnBHYgNfm3sLs+Yuk rEcGcMlKBD07Gz9MHgeQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1peCh0-008c5u-1k; Mon, 20 Mar 2023 10:24:42 +0000 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1peCgw-008c4m-0W for linux-arm-kernel@lists.infradead.org; Mon, 20 Mar 2023 10:24:40 +0000 Received: by mail-wr1-x430.google.com with SMTP id r29so9771859wra.13 for ; Mon, 20 Mar 2023 03:24:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20210112.gappssmtp.com; s=20210112; t=1679307875; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=A+r+Ws9THn6CGGgF4iFUCDGWb6IKHLEjNyMHSQSGlO8=; b=nG9TTuPuz+uZOoE6OQ4kAZeXgquf97A2dUACNYxaDnO02llmtPU4pk5B/ZQP1wlcu0 /BIF/AKRMYPy6EoIOoRrNjp+VwUHQ6Af+hF0vAWgep+GqiEG/r+wbl4GwhmGu81kE7kb xzgqjPVgqoLacuzWjjm1LmwGeeuw1LRXA5q7o/EzcHQ0qKcTy1hH5HpnPJxA7Q8zIvBC l/29cBygTSzm2yk2PpLr2bfScGQR96IYS61iMGf/jQGFKzWIGHQyjAb/1OAkgxif1Nz3 SAkJLL9KJ3/J3/gdUq2sxdpfBbHU2PCRF4f7abSjKz7CdaYwuGqjiC5G4TJVSUX+/RFW Plkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679307875; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=A+r+Ws9THn6CGGgF4iFUCDGWb6IKHLEjNyMHSQSGlO8=; b=ctusY/8aDaLiry9iNdEvAcdLbq4p8v5mY/AqHThqjOOgaIoiZpWWwz4CMWs28FmYHT oPgRQMpn82tPyFdBtMpJprxcBs3+wyifLh3RoEFexDh7N/VidQzPt17EVkqRlF/NH0jJ /XB9ITWbWDgFjAsfhJJNTlZVUsrZvQ8lyEY9Qf9fAc1v9rJd2rcUHirNT9zSY+C+LeOD aKKbFUtiwKbFYjuOnSw9ChqfsGpu/CSNOej6ikJE9Nmz2xmSjTC20mbaOLz8SxYDaUQA GYwBCuKnTd3xe9ZqUaLO7LrZVt+WFJcFp0NC+I/q9C/9khToJgMjy/XyUSp43SUe3gUm 0vtg== X-Gm-Message-State: AO0yUKWLaa5pd3s1LL3FgmTWK1q3tW56OsJ8UFkgMnx20EJIHYg93fsm pZrIZw3m5GPcg7HMqxdUTZ1IqA== X-Google-Smtp-Source: AK7set9f6rQrysSDP3kM2wqFNJh2dj49yepLBpmS2CK1LmemoN2ngd4i7NVxTEb1XHgVZqZ60K0rag== X-Received: by 2002:adf:f8c2:0:b0:2cf:e6de:c6ab with SMTP id f2-20020adff8c2000000b002cfe6dec6abmr13631837wrq.11.1679307874756; Mon, 20 Mar 2023 03:24:34 -0700 (PDT) Received: from localhost (host-213-179-129-39.customer.m-online.net. [213.179.129.39]) by smtp.gmail.com with ESMTPSA id f18-20020adff452000000b002c5d3f0f737sm8564095wrp.30.2023.03.20.03.24.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Mar 2023 03:24:34 -0700 (PDT) Date: Mon, 20 Mar 2023 11:24:33 +0100 From: Jiri Pirko To: Vadim Fedorenko Cc: Jakub Kicinski , Arkadiusz Kubalewski , Jonathan Lemon , Paolo Abeni , Vadim Fedorenko , poros@redhat.com, mschmidt@redhat.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, Milena Olech , Michal Michalik Subject: Re: [PATCH RFC v6 2/6] dpll: Add DPLL framework base functions Message-ID: References: <20230312022807.278528-1-vadfed@meta.com> <20230312022807.278528-3-vadfed@meta.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230312022807.278528-3-vadfed@meta.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230320_032438_389532_0A106914 X-CRM114-Status: UNSURE ( 7.75 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Sun, Mar 12, 2023 at 03:28:03AM CET, vadfed@meta.com wrote: [...] >+static int >+dpll_msg_add_pins_on_pin(struct sk_buff *msg, struct dpll_pin *pin, >+ struct netlink_ext_ack *extack) >+{ >+ struct dpll_pin_ref *ref = NULL; Pointless init. [...] >+static int >+dpll_event_device_change(struct sk_buff *msg, struct dpll_device *dpll, >+ struct dpll_pin *pin, struct dpll_pin *parent, >+ enum dplla attr) >+{ >+ int ret = dpll_msg_add_dev_handle(msg, dpll); >+ struct dpll_pin_ref *ref = NULL; Pointless init. [...] >+struct dpll_pin_ops { >+ int (*frequency_set)(const struct dpll_pin *pin, >+ const struct dpll_device *dpll, >+ const u32 frequency, >+ struct netlink_ext_ack *extack); >+ int (*frequency_get)(const struct dpll_pin *pin, >+ const struct dpll_device *dpll, >+ u32 *frequency, struct netlink_ext_ack *extack); >+ int (*direction_set)(const struct dpll_pin *pin, >+ const struct dpll_device *dpll, >+ const enum dpll_pin_direction direction, >+ struct netlink_ext_ack *extack); >+ int (*direction_get)(const struct dpll_pin *pin, >+ const struct dpll_device *dpll, >+ enum dpll_pin_direction *direction, >+ struct netlink_ext_ack *extack); For frequency and direction, why exactly do you need to pass dpll pointer? For set I can understand you need it to set the same frequency/direction for all dplls the pin is connected to, but why for get()? [...] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel