From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AD255C7618A for ; Mon, 20 Mar 2023 14:29:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pJ4ktwqWYQboBJW9G04G5vDT8LrSGHzny2E30FImrdM=; b=jK75UGLTAxwxXp sY26hqwr/4ge0589hVSEHxX8nUPQ7jCwg8S0WdxlEAN48pKhFDoeD0MzfLuI6ETRYficXxMDAR+P6 nVpSKSJamLR2+Djwa/H/ASz5kW2kovN6Bt4lzjzG2Tjl7qvQh+M9lwyMZcoB360FCfdgD2ihAfewO Djou2600145f5ZOenQIP2LpE4TOZYmI8991t6gkRQYsk+IHRXyL4l4U4HW3BxPfBjsI3RZtPaiFB5 L9uGdwE2WitSIFOwblf3nw3oEX+aZnwiwC7GIcBTr+m4GaqtSlSKw9/0cNySdpwne7HbKH45WthtW u6Bppq/1G/S9auH/WKnw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1peGUS-009KFO-1D; Mon, 20 Mar 2023 14:28:00 +0000 Received: from mga03.intel.com ([134.134.136.65]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1peGUP-009KCe-0b for linux-arm-kernel@lists.infradead.org; Mon, 20 Mar 2023 14:27:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1679322477; x=1710858477; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=LUNrtdSwwHMc4qJtxtzF+hn2LllZTlHtaPhQKDeqGkU=; b=WEatEz6Oe+nHG8RVl4NQ2XpoK+ZRzVRzBnxpqno5o3oWFfx6t4guBQpT R4G6ZsYLwDTSDM8cvwB1KKZylsdKAQ8hu4Gd7QDx4D1V4TUNFLMxBoIQ7 ut5Qs/O/aXpC6VREQCJyt4JgnpHHrNhnFo2BAiQy4OR+WshsWyUgFy4n4 Wa03l1BcQUJ/Am6OmvksPibhzGnvmjTKgdRtlBZN5j4jwuSvXwGrLj3NT WoWxPTD2WoFpWuzS8Htyn5Rr9L5GpAuBRY4qeHDxtzTX42AXOxEkpcbge jogM+szxQNdjXDWy/k6DWs4AgDJbO9gHBDXVGw91Xbqrlq08NPvOerZq1 g==; X-IronPort-AV: E=McAfee;i="6600,9927,10655"; a="341033333" X-IronPort-AV: E=Sophos;i="5.98,274,1673942400"; d="scan'208";a="341033333" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Mar 2023 07:27:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10655"; a="713588571" X-IronPort-AV: E=Sophos;i="5.98,274,1673942400"; d="scan'208";a="713588571" Received: from yilunxu-optiplex-7050.sh.intel.com (HELO localhost) ([10.239.159.165]) by orsmga001.jf.intel.com with ESMTP; 20 Mar 2023 07:27:50 -0700 Date: Mon, 20 Mar 2023 22:16:26 +0800 From: Xu Yilun To: Michal Simek Cc: Tom Rix , mdf@kernel.org, hao.wu@intel.com, michal.simek@xilinx.com, nathan@kernel.org, ndesaulniers@google.com, linux-fpga@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev Subject: Re: [PATCH] fpga: xilinx-pr-decoupler: remove unused xlnx_pr_decouple_read function Message-ID: References: <20230317230617.1673923-1-trix@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230320_072757_262522_03D701F8 X-CRM114-Status: GOOD ( 20.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2023-03-20 at 08:40:22 +0100, Michal Simek wrote: > > > On 3/18/23 00:06, Tom Rix wrote: > > CAUTION: This message has originated from an External Source. Please use proper judgment and caution when opening attachments, clicking links, or responding to this email. > > > > > > clang with W=1 reports > > drivers/fpga/xilinx-pr-decoupler.c:37:19: error: unused function 'xlnx_pr_decouple_read' [-Werror,-Wunused-function] > > static inline u32 xlnx_pr_decouple_read(const struct xlnx_pr_decoupler_data *d, > > ^ > > This static function is not used, so remove it. > > > > Signed-off-by: Tom Rix > > --- > > drivers/fpga/xilinx-pr-decoupler.c | 6 ------ > > 1 file changed, 6 deletions(-) > > > > diff --git a/drivers/fpga/xilinx-pr-decoupler.c b/drivers/fpga/xilinx-pr-decoupler.c > > index 2d9c491f7be9..b6f18c07c752 100644 > > --- a/drivers/fpga/xilinx-pr-decoupler.c > > +++ b/drivers/fpga/xilinx-pr-decoupler.c > > @@ -34,12 +34,6 @@ static inline void xlnx_pr_decoupler_write(struct xlnx_pr_decoupler_data *d, > > writel(val, d->io_base + offset); > > } > > > > -static inline u32 xlnx_pr_decouple_read(const struct xlnx_pr_decoupler_data *d, > > - u32 offset) > > -{ > > - return readl(d->io_base + offset); > > -} > > - > > static int xlnx_pr_decoupler_enable_set(struct fpga_bridge *bridge, bool enable) > > { > > int err; > > -- > > 2.27.0 > > > > It should be fixed like this instead. > > Thanks, > Michal > > diff --git a/drivers/fpga/xilinx-pr-decoupler.c b/drivers/fpga/xilinx-pr-decoupler.c > index 2d9c491f7be9..58508f44cd49 100644 > --- a/drivers/fpga/xilinx-pr-decoupler.c > +++ b/drivers/fpga/xilinx-pr-decoupler.c > @@ -69,7 +69,7 @@ static int xlnx_pr_decoupler_enable_show(struct > fpga_bridge *bridge) > if (err) > return err; > > - status = readl(priv->io_base); > + status = xlnx_pr_decouple_read(priv); OK, I'll drop the previous fix, and waiting for the new one. Thanks, Yilun > > clk_disable(priv->clk); > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel