From: Luis Chamberlain <mcgrof@kernel.org>
To: Nick Alcock <nick.alcock@oracle.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Masahiro Yamada <masahiroy@kernel.org>
Cc: Shawn Guo <shawnguo@kernel.org>,
linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org,
Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 14/24] kbuild, firmware: imx: remove MODULE_LICENSE in non-modules
Date: Mon, 20 Mar 2023 14:42:04 -0700 [thread overview]
Message-ID: <ZBjTLGhohFlbO4xr@bombadil.infradead.org> (raw)
In-Reply-To: <874jqfvheo.fsf@esperi.org.uk>
On Mon, Mar 20, 2023 at 10:36:15AM +0000, Nick Alcock wrote:
> On 14 Mar 2023, Shawn Guo verbalised:
>
> > On Fri, Feb 17, 2023 at 02:10:49PM +0000, Nick Alcock wrote:
> >> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
> >> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
> >> are used to identify modules. As a consequence, uses of the macro
> >> in non-modules will cause modprobe to misidentify their containing
> >> object file as a module when it is not (false positives), and modprobe
> >> might succeed rather than failing with a suitable error message.
> >>
> >> So remove it in the files in this commit, none of which can be built as
> >> modules.
> >>
> >> Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
> >> Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
> >
> > Should I apply it as a fix for 6.3-rc with Cc stable tag, or can it be
> > a material for -next?
These are not stable critical patches.
> This is currently built against -next, but Luis has indicated an intent
> to pull the lot in via -rc3 (hence my scrambling to get the series
> polished up for him, tags attached etc now). So, er... yes? :)
Those patches which don't get this simply can't benefit from future
tooling enhancements which Nick is working on which will leverage
correct mapping.
So yes, my goal is to pull up straggler patches except where some
maintainer explicitly don't want them. For instance, I will not be
taking in the patches for trees that Greg KH maintains as he would
prefer an alternative, but yet hasn't recommended an alternative
strategy to help with Nick's work.
Luis
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-03-20 21:43 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230217141059.392471-1-nick.alcock@oracle.com>
2023-02-17 14:10 ` [PATCH 07/24] kbuild, bus: arm-integrator-lm: remove MODULE_LICENSE in non-modules Nick Alcock
2023-02-17 14:10 ` [PATCH 08/24] kbuild, drivers/perf: " Nick Alcock
2023-02-17 14:10 ` [PATCH 10/24] kbuild, pinctrl: actions: " Nick Alcock
2023-02-17 14:10 ` [PATCH 11/24] kbuild, soc: apple: apple-pmgr-pwrstate: " Nick Alcock
2023-02-19 12:38 ` Sven Peter
2023-02-20 5:00 ` Eric Curtin
2023-02-17 14:10 ` [PATCH 12/24] kbuild, soc: sunxi: sram: " Nick Alcock
2023-02-21 18:24 ` Jernej Škrabec
2023-03-14 20:39 ` Jernej Škrabec
2023-02-17 14:10 ` [PATCH 13/24] kbuild, clk: bm1880: " Nick Alcock
2023-02-17 22:43 ` Stephen Boyd
2023-02-17 14:10 ` [PATCH 14/24] kbuild, firmware: imx: " Nick Alcock
2023-03-14 1:35 ` Shawn Guo
2023-03-20 10:36 ` Nick Alcock
2023-03-20 21:42 ` Luis Chamberlain [this message]
2023-02-17 14:10 ` [PATCH 15/24] kbuild, bus: ixp4xx: " Nick Alcock
2023-02-17 14:10 ` [PATCH 16/24] kbuild, irqchip/mvebu-pic: " Nick Alcock
2023-02-17 14:10 ` [PATCH 20/24] kbuild, gpio: " Nick Alcock
2023-03-06 9:58 ` Bartosz Golaszewski
2023-02-17 14:10 ` [PATCH 21/24] kbuild, serial: " Nick Alcock
2023-03-09 16:17 ` Greg Kroah-Hartman
2023-02-17 14:10 ` [PATCH 22/24] kbuild, dmaengine: s3c24xx: " Nick Alcock
2023-02-17 14:20 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBjTLGhohFlbO4xr@bombadil.infradead.org \
--to=mcgrof@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hasegawa-hitomi@fujitsu.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=nick.alcock@oracle.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).