From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 17DC0C6FD1C for ; Mon, 20 Mar 2023 21:43:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ST2R4+yBB0btOHJPTGtIMOzJunkVRWWtozTvUXNxnuk=; b=TmZ2keGPVBI2bd VkQBi3nOBceaZjuZOlto4v0Gm/GjI8yReYzYLv9hbkOC+vriasXtNUfTLGiH3E7RAnFvzFVtj60g6 wsx7wCMY1CECPZpKC9z4mwgMa/n5fUs4Jo4HbDr8O5k2N4kfv3FVKYH8KTSRyI4ifGHt/a6L5GKVd mO397zBKQXyOlRC8EZtXngcGiNx83OhALI6t3AUTHhLMuDLejWD8seQsN+MC9/m2jK4bBI3widsZ5 gNGYljREZ8ow5bWBoq7PxDJXJwvRocTCUBZU/5b1afSqE+WjmEBZ3aZpVjtYCC6cjiVbCuhJWGZgT z17ZMIjoGAcfRXe+3atA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1peNGY-00AZ3a-0X; Mon, 20 Mar 2023 21:42:06 +0000 Received: from mcgrof by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1peNGW-00AZ3O-0H; Mon, 20 Mar 2023 21:42:04 +0000 Date: Mon, 20 Mar 2023 14:42:04 -0700 From: Luis Chamberlain To: Nick Alcock , Greg Kroah-Hartman , Masahiro Yamada Cc: Shawn Guo , linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org, Hitomi Hasegawa , Sascha Hauer , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 14/24] kbuild, firmware: imx: remove MODULE_LICENSE in non-modules Message-ID: References: <20230217141059.392471-1-nick.alcock@oracle.com> <20230217141059.392471-15-nick.alcock@oracle.com> <20230314013539.GA143566@dragon> <874jqfvheo.fsf@esperi.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <874jqfvheo.fsf@esperi.org.uk> X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Mar 20, 2023 at 10:36:15AM +0000, Nick Alcock wrote: > On 14 Mar 2023, Shawn Guo verbalised: > > > On Fri, Feb 17, 2023 at 02:10:49PM +0000, Nick Alcock wrote: > >> Since commit 8b41fc4454e ("kbuild: create modules.builtin without > >> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations > >> are used to identify modules. As a consequence, uses of the macro > >> in non-modules will cause modprobe to misidentify their containing > >> object file as a module when it is not (false positives), and modprobe > >> might succeed rather than failing with a suitable error message. > >> > >> So remove it in the files in this commit, none of which can be built as > >> modules. > >> > >> Signed-off-by: Nick Alcock > >> Suggested-by: Luis Chamberlain > > > > Should I apply it as a fix for 6.3-rc with Cc stable tag, or can it be > > a material for -next? These are not stable critical patches. > This is currently built against -next, but Luis has indicated an intent > to pull the lot in via -rc3 (hence my scrambling to get the series > polished up for him, tags attached etc now). So, er... yes? :) Those patches which don't get this simply can't benefit from future tooling enhancements which Nick is working on which will leverage correct mapping. So yes, my goal is to pull up straggler patches except where some maintainer explicitly don't want them. For instance, I will not be taking in the patches for trees that Greg KH maintains as he would prefer an alternative, but yet hasn't recommended an alternative strategy to help with Nick's work. Luis _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel