From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CE1E4C74A5B for ; Tue, 21 Mar 2023 10:26:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KcW/muFs5OpwemhHIJQ1ZzxyEARQ3PXhQoRuFRTRnBQ=; b=O9p6nUhPRi+ta2 g5O6WFWUDY9H+gRFgBMWR1zK2JSbZBJvUnnMSNhs5ttsJTWteI5TBl8DFEK88mF4DMkvO3KBXLd0K xllJRkKaI0hNIbcsVPCV/l3/2ZGU0JQZ9tsqGKAhlLa3cmV8M68AYnMsCko9n2kEGDtEoJ5kg/OC9 rEJpisHsSx9kXI+pc06ei3tMgo6SQk5KrkUHBYEENQJQBswmBvU9/xLXXt8Tg5+QkfIZbcCaPpsS0 MoPMwxWVWhWavBShkMZbeGu4WGlviM5Xf6CHAPDzTNL1glxmJKt854MQirYxu3oly0Q8v+vkhVds6 T/m4VV87P6GXPsl85LwA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1peZAu-00C0wu-10; Tue, 21 Mar 2023 10:25:04 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1peZAr-00C0vf-20 for linux-arm-kernel@lists.infradead.org; Tue, 21 Mar 2023 10:25:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=2/5ZKCRtcozJW7fGgvaCJXkANVONxvDwkzpoVXYWfpA=; b=g0SsILMYrdK9CoBNejEiR55gQk K1chqIjm/nDgGtNLESl2IdkWqFpCcDQIkiGwf6C/yeI8w9SxFRqBDLCSq6Rg6m/c76/Yw+j5nIDaj 2Z0JfT1RqCg3nz/yfL/wRxgyCfmoby/T1GG6n7CodvHUmmbn9bw25waTLSCG7xixjepShUgKQqKdc IJeqQCLXGkutSYlq6uyFZr6pkvVqK8vrL8zZPNC8e4qMg+WCr3Sw7QMrRKvptHbLxtpvr+1Tq7cMA uGWuVMgZal/BdX7TqZAI4WRshXd+qcAxDXwQT4piVVH9yK1LjPk6AA0HgyL5AzwqyMiqSoR3Vsxel D2iTKQLw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:44938) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1peZAh-0000rR-AV; Tue, 21 Mar 2023 10:24:51 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1peZAf-0007eU-Na; Tue, 21 Mar 2023 10:24:49 +0000 Date: Tue, 21 Mar 2023 10:24:49 +0000 From: "Russell King (Oracle)" To: "Sit, Michael Wei Hong" Cc: Andrew Lunn , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , "Ong, Boon Leong" , "netdev@vger.kernel.org" , "linux-stm32@st-md-mailman.stormreply.com" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "Looi, Hong Aun" , "Voon, Weifeng" , "Lai, Peter Jun Ann" Subject: Re: [PATCH net v2 1/2] net: stmmac: fix PHY handle parsing Message-ID: References: <20230314070208.3703963-1-michael.wei.hong.sit@intel.com> <20230314070208.3703963-2-michael.wei.hong.sit@intel.com> <10aff941-e18a-4d77-974b-1760529988a6@lunn.ch> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230321_032501_666528_75D4D944 X-CRM114-Status: GOOD ( 26.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 21, 2023 at 08:34:49AM +0000, Sit, Michael Wei Hong wrote: > > > > -----Original Message----- > > From: Russell King > > Sent: Saturday, March 18, 2023 4:58 AM > > To: Andrew Lunn > > Cc: Sit, Michael Wei Hong ; > > Giuseppe Cavallaro ; Alexandre > > Torgue ; Jose Abreu > > ; David S . Miller > > ; Eric Dumazet > > ; Jakub Kicinski ; > > Paolo Abeni ; Maxime Coquelin > > ; Ong, Boon Leong > > ; netdev@vger.kernel.org; linux- > > stm32@st-md-mailman.stormreply.com; linux-arm- > > kernel@lists.infradead.org; linux-kernel@vger.kernel.org; Looi, > > Hong Aun ; Voon, Weifeng > > ; Lai, Peter Jun Ann > > > > Subject: Re: [PATCH net v2 1/2] net: stmmac: fix PHY handle > > parsing > > > > On Fri, Mar 17, 2023 at 08:56:19PM +0100, Andrew Lunn wrote: > > > On Tue, Mar 14, 2023 at 03:02:07PM +0800, Michael Sit Wei > > Hong wrote: > > > > phylink_fwnode_phy_connect returns 0 when set to > > MLO_AN_INBAND. > > > > This causes the PHY handle parsing to skip and the PHY will not > > be > > > > attached to the MAC. > > > > > > Please could you expand the commit message because i'm > > having trouble > > > following this. > > > > > > phylink_fwnode_phy_connect() says: > > > > > > /* Fixed links and 802.3z are handled without needing a > > PHY */ > > > if (pl->cfg_link_an_mode == MLO_AN_FIXED || > > > (pl->cfg_link_an_mode == MLO_AN_INBAND && > > > phy_interface_mode_is_8023z(pl->link_interface))) > > > return 0; > > > > > > So your first statement is not true. It should be > > MLO_AN_INBAND and > > > phy_interface_mode_is_8023z. > > > > > > > Add additional check for PHY handle parsing when set to > > MLO_AN_INBAND. > > > > > > Looking at the patch, there is no reference to > > MLO_AN_INBAND, or > > > managed = "in-band-status"; > > > > That's the pesky "xpcs_an_inband" which ends up as phylink's > > "ovr_an_inband"... I'm sure these are random renames of stuff > > to make sure that people struggle to follow the code. > > > It is as mentioned above, the "xpcs_an_inband" will end up as > "ovr_an_inband" which will then > set pl->cfg_link_an_mode = MLO_AN_INBAND in the > phylink_parse_mode() in phylink.c Let me make my comment more clear, because I don't think you understood it correctly. Please rename "xpcs_an_inband" to "ovr_an_inband" or "phylink_ovr_an_inband" so it's obvious what it is and where it ends up. Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel