From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 88C73C7618D for ; Tue, 21 Mar 2023 11:21:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=trbqhgZrHuVI4wtxOm6tuyDZLGiwonL8TvroAjKAL+I=; b=lLngeMME17enKj yGqlRdK8aGeU4C9BgeJ9V+UZqu5WkIWxmSTdRGHAZ32zAKIr4tr4eVpF+0Zy21Xo1O2ebo/AcR/xX 67Zgi7SbQDIYVcgynqHhdrQvjQIbarSUDaLNWOMqDdXd4dI+ODunRwELURM/t6D0OF+fWeEq9Deu/ p3ZBS39JTW6UA1sfnoSPEktnj9Hhfm8VedbLgyeM2Wn+wk/Nf/LsY6Io6G5GpNqNQFg42cQzGly+r PKsF4SS+Yt6tdHncWVrmQAwEPzhrMRMWqwDYOsfYzl4uQmid0a8xyXcSPecijlCQ4v1Nqu+VFaQPE yY4p5rdW5hHxCNhg5scw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pea2E-00CAnh-1z; Tue, 21 Mar 2023 11:20:10 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pea2A-00CAmh-0p for linux-arm-kernel@lists.infradead.org; Tue, 21 Mar 2023 11:20:08 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 386ACAD7; Tue, 21 Mar 2023 04:20:46 -0700 (PDT) Received: from FVFF77S0Q05N (unknown [10.57.54.220]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4FFD43F71E; Tue, 21 Mar 2023 04:20:01 -0700 (PDT) Date: Tue, 21 Mar 2023 11:19:55 +0000 From: Mark Rutland To: Chris Packham Cc: catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: Support CMDLINE_EXTEND Message-ID: References: <20230320211451.2512800-1-chris.packham@alliedtelesis.co.nz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230320211451.2512800-1-chris.packham@alliedtelesis.co.nz> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230321_042006_371983_F2CBD779 X-CRM114-Status: GOOD ( 18.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 21, 2023 at 10:14:51AM +1300, Chris Packham wrote: > Support extending the bootloader provided command line for arm64 > targets. This support is already present via generic DT/EFI code the > only thing required is for the architecture to make it selectable. > > Signed-off-by: Chris Packham We deliberately dropped support for CMDLINE_EXTEND in commit: cae118b6acc3 ("arm64: Drop support for CMDLINE_EXTEND") ... which was mentioned the last time somone tried to re-add it: https://lore.kernel.org/linux-arm-kernel/ZAh8dWvbNkVQT11C@arm.com/ Has something changes such that those issues no longer apply? If so, please call that out explicitly in the commit message. If not, I do not think we should take this patch. Thanks, Mark. > --- > arch/arm64/Kconfig | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > index 1023e896d46b..3c837b085f21 100644 > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -2228,6 +2228,12 @@ config CMDLINE_FROM_BOOTLOADER > the boot loader doesn't provide any, the default kernel command > string provided in CMDLINE will be used. > > +config CMDLINE_EXTEND > + bool "Extend bootloader kernel arguments" > + help > + The command-line arguments provided by the boot loader will be > + appended to the default kernel command string. > + > config CMDLINE_FORCE > bool "Always use the default kernel command string" > help > -- > 2.40.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel