From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 39D87C76195 for ; Thu, 23 Mar 2023 10:38:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PSQfOekzInd5NjkLWhPwPk254lww82q2eI/LrTIQp7o=; b=m9T3AsyWJe7ovl yJy1WP6j2udbdJMCakvxiHqHC4SfhulrTGjBtPZEWKO3pscMvEaU+lUAZRfWPnDyABSD85WTJJRRX mGSD8crTfhA69nRBs5tmcMZqMkwt9Tg0IlNkaZ5xbzd+e7s8znQS7bRC49sF6bZsDt3f8RkiNvUQb H867bPV2mc/vTyipyhkjIj4Qwht1FsZ2E2wHkPqNq9wVeOOa9mLZaSA6ysXpf6Zc5v4+tt44ijfrD 1q2aDKFFMgF8nFNAvM3Y4XC6b0Sd47GKovWDSDFtu29JQzRmDCGMw8aP+iNmAO8bpJgPUtV1Ji7a3 /BUCEbXkQio4Q2xlu+XA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pfIK1-001b87-0W; Thu, 23 Mar 2023 10:37:29 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pfIJx-001b6h-0M for linux-arm-kernel@lists.infradead.org; Thu, 23 Mar 2023 10:37:27 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 98F7D62100; Thu, 23 Mar 2023 10:37:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A0F9CC4339B; Thu, 23 Mar 2023 10:37:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679567844; bh=7HVmHyHcaSnCmEQ9wvlGS5D2gJIf2hovuJXSyaCaqdA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sPKSP02iJA6KAFPv7bGM4/Se81vulHnHqt8qfWTUhZFZfE1s7yfVR1WI2haHPg+A3 jWzVvRFZzkglSwote3myrlA5TUDE+Mjiy60hA/JC5FTriwEUlR/LYSMkz7fsTaldFc oMQlw0WTXs+ktUIZkgxUF4A7BhNREJZy9IC+pPvHI8Vsp+m2dbErDE2naZmB571znT Fxiq15cRjtHrw73FO6Y3VXmv90htiJ2rNj1RicLa12inWDP9wSpUycX7R7yd2Kgx+7 vrbS8fMpVelSjMFK/gnOL3tvAHj3UliwBTODwab575ZgUsXBaJnqCJoJygIlhUcZOE OSTuDUXtdmoRA== Date: Thu, 23 Mar 2023 12:37:05 +0200 From: Mike Rapoport To: Catalin Marinas Cc: Andrew Morton , Arnd Bergmann , Christophe Leroy , "David S. Miller" , Dinh Nguyen , Geert Uytterhoeven , Guo Ren , John Paul Adrian Glaubitz , "Kirill A. Shutemov" , Max Filippov , Michael Ellerman , Rich Felker , Russell King , Will Deacon , Yoshinori Sato , Zi Yan , linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mm@kvack.org, linux-sh@vger.kernel.org, linux-xtensa@linux-xtensa.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org Subject: Re: [PATCH 02/14] arm64: drop ranges in definition of ARCH_FORCE_MAX_ORDER Message-ID: References: <20230323092156.2545741-1-rppt@kernel.org> <20230323092156.2545741-3-rppt@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230323_033725_188954_76BA033B X-CRM114-Status: GOOD ( 24.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Mar 23, 2023 at 10:15:33AM +0000, Catalin Marinas wrote: > On Thu, Mar 23, 2023 at 11:21:44AM +0200, Mike Rapoport wrote: > > From: "Mike Rapoport (IBM)" > > > > It is not a good idea to change fundamental parameters of core memory > > management. Having predefined ranges suggests that the values within > > those ranges are sensible, but one has to *really* understand > > implications of changing MAX_ORDER before actually amending it and > > ranges don't help here. > > > > Drop ranges in definition of ARCH_FORCE_MAX_ORDER > > > > Signed-off-by: Mike Rapoport (IBM) > > --- > > arch/arm64/Kconfig | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > > index e60baf7859d1..bab6483e4317 100644 > > --- a/arch/arm64/Kconfig > > +++ b/arch/arm64/Kconfig > > @@ -1489,9 +1489,7 @@ config XEN > > config ARCH_FORCE_MAX_ORDER > > int "Maximum zone order" if ARM64_4K_PAGES || ARM64_16K_PAGES > > default "13" if ARM64_64K_PAGES > > - range 11 13 if ARM64_16K_PAGES > > default "11" if ARM64_16K_PAGES > > - range 10 15 if ARM64_4K_PAGES > > default "10" > > I don't mind rewriting the help text as in the subsequent patch but I'd > keep the ranges as a safety measure. It's less wasted time explaining to > people why some random max order doesn't work. Alternatively, we can > drop the ranges but make this option configurable only if EXPERT. I like the EXPERT alternative more. I'll add it in v2. > -- > Catalin -- Sincerely yours, Mike. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel