From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E44BEC6FD1C for ; Thu, 23 Mar 2023 19:50:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AnUqA6j7HHIP9bbmA+ePWPJfy1vj0dyPkumrc67LYFk=; b=bwDi8h1TyJ4cg9 0QV3dT7EwO/qeMx0BGeN4x0Zti+KpHqhDbhjdDPhIBIcvmEjuwtHzV2t/QzEsaapplNW8qQluTKMY Z8VuNQl9BjNAcaphkGflH8dgYh3Bt4oYyE9KvmBOz7oObS79iKsMxO8EgdB1XQOlJPvhyn0pHszMN avb74T7OgvpPOG3E8C4u7fzzvlZNQ97BIgKQoGtT2r7N6JtAc6PnKSjMlSPPvPtIGRvJp1Rw7mFlf HDnR/ZFbufuXAaCGDHa9a0jcJuIel8aaIXQwzdDmZx/Z+TgvyOGxYOYLudtoAi395apCLC+wSw/Aq 017W4xuOeYCsISa0KD6A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pfQw8-002rah-0H; Thu, 23 Mar 2023 19:49:24 +0000 Received: from out-19.mta0.migadu.com ([2001:41d0:1004:224b::13]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pfQw4-002rZz-1P for linux-arm-kernel@lists.infradead.org; Thu, 23 Mar 2023 19:49:21 +0000 Date: Thu, 23 Mar 2023 19:49:12 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1679600956; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=30olvZAapUZx7TEEy9RyCXZ05qesWJ5bkCOLGb++Q4o=; b=QKsCmzSM95s6TbJ4fWJsKAqQgFAhsxAeO5PHC6exJn+LD9RC+4tzc3iTp1zmAeU6CE2uhK +sEaF+oiWqixzSjXtcUTKn3rD8ZccgoQ6fIllLRxI3Do0Qj/Qx56k4v2fZ48lPvrQisSsQ 0GDarWu6I2qYitQPyyNVD5YeONEkaFY= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: Marc Zyngier Cc: James Morse , Suzuki K Poulose , kvmarm@lists.linux.dev, Zenghui Yu , linux-arm-kernel@lists.infradead.org, Sean Christopherson , Jeremy Linton Subject: Re: [PATCH v2 2/4] KVM: arm64: Avoid lock inversion when setting the VM register width Message-ID: References: <20230316211412.2651555-1-oliver.upton@linux.dev> <20230316211412.2651555-3-oliver.upton@linux.dev> <87lejpgfj3.wl-maz@kernel.org> <4f18d5264e4213f5a94a26bd8539eb0c@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4f18d5264e4213f5a94a26bd8539eb0c@kernel.org> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230323_124920_618154_37B15762 X-CRM114-Status: GOOD ( 13.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Mar 23, 2023 at 07:43:04PM +0000, Marc Zyngier wrote: > On 2023-03-23 19:20, Oliver Upton wrote: > > On Wed, Mar 22, 2023 at 12:02:40PM +0000, Marc Zyngier wrote: > > > On Thu, 16 Mar 2023 21:14:10 +0000, Oliver Upton wrote: [...] > > > > +#ifdef CONFIG_LOCKDEP > > > > + /* Inform lockdep that the config_lock is acquired after vcpu->mutex */ > > > > + mutex_lock(&vcpu->mutex); > > > > + mutex_lock(&vcpu->kvm->arch.config_lock); > > > > + mutex_unlock(&vcpu->kvm->arch.config_lock); > > > > + mutex_unlock(&vcpu->mutex); > > > > +#endif > > > > > > Shouldn't this hunk be moved to the previous patch? > > > > Uh, I don't believe so since this is the patch that actually introduces > > kvm_arch::config_lock. The last patch was aimed at a separate lock for > > mp state. > > Nah, you're obviously right. I reviewed this at 4am being jet-lagged. > Not the brightest comment... :-/ Sorry for the noise. No problem at all! I wish I had as good of an excuse as you for the times I gave far worse feedback... -- Thanks, Oliver _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel