From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A3123C76188 for ; Wed, 5 Apr 2023 08:31:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DJLhS7TSPufKHK+/evL/Ea/zimMNbB2cPDVY2v0nJ+0=; b=z2V89A4zMlZMtv Q5jBlgsRhFNGGgg1XzAMkj7kXEABVI/0E1PPaOdXz2NE8g3uK+uRvaOOLFILZuFrZudfP0SDXpkpq Y9hDrGa0PlW75TWhblewq44cfxxAdwf8O45rk22jPcEL8/wZCHk65n8J3ckE64BAy7BtChOyu9VUO qLlzbgniE423Zwrfd1gjNgaGb6/pKZ2Ko1l1NiSB8yEPrgSI3CThuCwEYiLTzM9K6BP1mIw2W/M+2 zWQ3LIulFEdT9CW4uiOagJi8ux+nt0GX9dY5pqTJVoWhgD/ePVtbBmjpNWnpsY8xkIWD92fHr06By 2tSl/xh8NcHOzBL1/rBQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pjyXQ-003nGf-1v; Wed, 05 Apr 2023 08:30:40 +0000 Received: from mga12.intel.com ([192.55.52.136]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pjyXN-003nEv-16 for linux-arm-kernel@lists.infradead.org; Wed, 05 Apr 2023 08:30:38 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1680683437; x=1712219437; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=o2D+LfXhLk+QrH3a0th/mLBmSHhjZTr2yV97vm5EWfI=; b=Che/QAnFobh2WGFKdi8EUugmTqZKpx4D/O8/biO3UhW4AtCtjV8hhhQ+ +mUhc93pBO6Wq87Vv8WipMKWD0qZ5npw0kh88zyotuleVeQ7a1eESzGes H4r4/Y2KUhtjSQwjD82Gf1RRuKFEJeERJcIzD94ux2YYiD6Hb2cflnruy OcSnTlIz76ED0mIf7dDZZjFnEqmDXB4kTDJ/bZscrDv72CVelWuyopnmZ G6ZaOF+F4FyiqossU1UNBf4viGt8iKcWrikUOJuTfG5sYd397rS7hRKt6 yJvnTAlPJ2YTrYNX/SHrB+GrmxLu3/WUioYfLkNpIQENu5kJ3c/E51s0i w==; X-IronPort-AV: E=McAfee;i="6600,9927,10670"; a="322058599" X-IronPort-AV: E=Sophos;i="5.98,319,1673942400"; d="scan'208";a="322058599" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Apr 2023 01:30:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10670"; a="860894821" X-IronPort-AV: E=Sophos;i="5.98,319,1673942400"; d="scan'208";a="860894821" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga005.jf.intel.com with ESMTP; 05 Apr 2023 01:30:23 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1pjyX4-00Ckbm-35; Wed, 05 Apr 2023 11:30:18 +0300 Date: Wed, 5 Apr 2023 11:30:18 +0300 From: Andy Shevchenko To: =?iso-8859-1?Q?Micka=EBl_Sala=FCn?= , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Mika Westerberg , Michael Ellerman , Randy Dunlap , Arnd Bergmann , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Niklas Schnelle , Bjorn Helgaas , "Rafael J. Wysocki" , Pali =?iso-8859-1?Q?Roh=E1r?= , "Maciej W. Rozycki" , Juergen Gross , Dominik Brodowski , linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-pci@vger.kernel.org, xen-devel@lists.xenproject.org, linux-acpi@vger.kernel.org Cc: Miguel Ojeda , Richard Henderson , Ivan Kokshaysky , Matt Turner , Russell King , Andrew Lunn , Sebastian Hesselbarth , Gregory Clement , Thomas Bogendoerfer , Nicholas Piggin , Christophe Leroy , Anatolij Gustschin , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , "David S. Miller" , Bjorn Helgaas , Stefano Stabellini , Oleksandr Tyshchenko Subject: Re: [PATCH v8 7/7] pcmcia: Convert to use less arguments in pci_bus_for_each_resource() Message-ID: References: <20230330162434.35055-1-andriy.shevchenko@linux.intel.com> <20230330162434.35055-8-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230330162434.35055-8-andriy.shevchenko@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230405_013037_394069_AF76C818 X-CRM114-Status: GOOD ( 12.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Mar 30, 2023 at 07:24:34PM +0300, Andy Shevchenko wrote: ... > @@ -960,12 +960,9 @@ static int nonstatic_autoadd_resources(struct pcmcia_socket *s) > */ > if (s->cb_dev->bus->number == 0) > return -EINVAL; > - > - for (i = 0; i < PCI_BRIDGE_RESOURCE_NUM; i++) { > - res = s->cb_dev->bus->resource[i]; > -#else > - pci_bus_for_each_resource(s->cb_dev->bus, res, i) { > #endif > + > + pci_bus_for_each_resource(s->cb_dev->bus, res) { > if (!res) > continue; As pointed out in the reply to Bjorn's email this hunk needs to be revisited, since I wrote the documentation for the above call I have started understanding the deal behind this special treatment for X86 case. -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel