From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A1429C6FD18 for ; Wed, 29 Mar 2023 16:23:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=80F0bgTux2S2NoL8X6rGZ6seJjVXmtO0QyPfWcdTTPE=; b=f6DEk0w+l1pkzA WVDP0Qvd0xleb5yeMVwqT5ASjkmam3UqNAimb4Qu0vZdF9rrNZgsKLe62/PgGPIcky53YV7axGOmG n6IXp2GdBi51krdi07fhMY1gyTJ2EjR34bHcgeV+xybkQ5a9daUJPvg9QnaqC+HUDg5w9M1nPztxi UXFwL9FOq5cGtBej/iZUISgJl+E3LCM4WuFJm65GjZIaX2XuKP6b4qNFTQHcbiyfopnpMMTfv8HWx nha0hD/ayM25xGV/945oCQjfCp8X0ZKVo7tiPwI993XcPTZZHU29EmZn3GxHwC9I0WA4VCUzd204W B1ZSEyNPaL7jjrANRzpg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1phYZh-0014qN-1X; Wed, 29 Mar 2023 16:23:01 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1phYZe-0014or-2r for linux-arm-kernel@lists.infradead.org; Wed, 29 Mar 2023 16:23:00 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 20E76B81E4A; Wed, 29 Mar 2023 16:22:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 967AEC433EF; Wed, 29 Mar 2023 16:22:52 +0000 (UTC) Date: Wed, 29 Mar 2023 17:22:49 +0100 From: Catalin Marinas To: Gregory Price Cc: linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org, oleg@redhat.com, avagin@gmail.com, peterz@infradead.org, luto@kernel.org, krisman@collabora.com, tglx@linutronix.de, corbet@lwn.net, shuah@kernel.org, arnd@arndb.de, will@kernel.org, mark.rutland@arm.com, tongtiangen@huawei.com, robin.murphy@arm.com, Gregory Price Subject: Re: [PATCH v14 1/4] asm-generic,arm64: create task variant of access_ok Message-ID: References: <20230328164811.2451-1-gregory.price@memverge.com> <20230328164811.2451-2-gregory.price@memverge.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230328164811.2451-2-gregory.price@memverge.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230329_092259_097051_FECB2CC7 X-CRM114-Status: GOOD ( 18.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 28, 2023 at 12:48:08PM -0400, Gregory Price wrote: > diff --git a/arch/arm64/include/asm/uaccess.h b/arch/arm64/include/asm/uaccess.h > index 5c7b2f9d5913..1a51a54f264f 100644 > --- a/arch/arm64/include/asm/uaccess.h > +++ b/arch/arm64/include/asm/uaccess.h > @@ -35,7 +35,9 @@ static inline int __access_ok(const void __user *ptr, unsigned long size); > * This is equivalent to the following test: > * (u65)addr + (u65)size <= (u65)TASK_SIZE_MAX > */ > -static inline int access_ok(const void __user *addr, unsigned long size) > +static inline int task_access_ok(struct task_struct *task, > + const void __user *addr, > + unsigned long size) > { > /* > * Asynchronous I/O running in a kernel thread does not have the > @@ -43,11 +45,18 @@ static inline int access_ok(const void __user *addr, unsigned long size) > * the user address before checking. > */ > if (IS_ENABLED(CONFIG_ARM64_TAGGED_ADDR_ABI) && > - (current->flags & PF_KTHREAD || test_thread_flag(TIF_TAGGED_ADDR))) > + (task->flags & PF_KTHREAD || test_ti_thread_flag(task, TIF_TAGGED_ADDR))) > addr = untagged_addr(addr); > > return likely(__access_ok(addr, size)); > } > + > +static inline int access_ok(const void __user *addr, unsigned long size) > +{ > + return task_access_ok(current, addr, size); > +} > + > +#define task_access_ok task_access_ok I'd not bother with this at all. In the generic code you can either do an __access_ok() check directly or just access_ok(untagged_addr(selector), ...) with a comment that address tagging of the ptraced task may not be enabled. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel