From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 932EFC6FD18 for ; Wed, 29 Mar 2023 22:15:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=y0+zNAmQENSBpraRHdtNHywKPzoHiYzanBBt4W/vruI=; b=ccckN2ZLJpzkAj GP3QyH38RGoRMtPauQR9qL/ReM51QcFi6HdA4Yt4/4HGeNnvn93XvcAhuU4gnzk/Yld7mUG++AxXc P9S0yleCKMWGyu65HgYxkOh8zxgIrXM4Sku+8KNjcu7kGkMJvZkQ/VvSFrRw8ZGmrf7+5QtZcg67m v5QtqiMwwQWZvBGDxdZEMtwCqswmfeBpMKF627Sj43rJgtpjQmZxSpVSB+9eKE0e6opAxbttV9kMr HEnl51oxEkdxh4L3QMvlUBtCvwPqJ+AoDapLtlVHFHIM+rBubX4GuLxPi4nCXluT/tgbgpUCf33b+ QRDoOMUyCUDs8HfRriTw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1phe4J-001xYM-2Q; Wed, 29 Mar 2023 22:14:59 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1phe4I-001xYG-1n for linux-arm-kernel@bombadil.infradead.org; Wed, 29 Mar 2023 22:14:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=rzLFZ/WJKLztSNiaQby7MGHXk3hJ6ZiQlEd8mxCV1OE=; b=IfhYWHLpLss0oxkLvlj2r+S64+ 4fEfaUT17qTQrMJvOo2tGcRIcQwK31KpSByC0RvjUo5KE31kZVANtJc/Jzq/4pkq11+CVld1JkdAV 7THIKKTHxKrXCHx9QVyaWGY/52L/4aacjWlyhx1C6jOIVv7O12IlIZXiUZizhNY+Jrn5xMsqugfxJ l0ZS5gW7yQqQC3NiLLvl0BnaByonrCzzTzrZ2DZWWuNsMwkngI7OQXXINhXyQ6Ln6S7cN4MFuYR2f nkl5baxG0IiTIcVDtmqUnv9bVM1/+k+76035nZfUWMf9JcwhN4qESq6l6f4Y1m0eCJeY2qIQVOed7 dna+oEeQ==; Received: from [187.19.239.165] (helo=quaco.ghostprotocols.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1phe4G-009pe6-LS; Wed, 29 Mar 2023 22:14:56 +0000 Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 941194052D; Wed, 29 Mar 2023 19:14:52 -0300 (-03) Date: Wed, 29 Mar 2023 19:14:52 -0300 From: Arnaldo Carvalho de Melo To: Mike Leach Cc: linux-perf-users@vger.kernel.org, linux-arm-kernel@lists.infradead.org, coresight@lists.linaro.org, linux-kernel@vger.kernel.org, suzuki.poulose@arm.com, leo.yan@linaro.org, peterz@infradead.org, mingo@redhat.com, will@kernel.org, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@redhat.com, namhyung@kernel.org, gankulkarni@os.amperecomputing.com, darren@os.amperecomputing.com, James Clark Subject: Re: [PATCH v8 1/3] perf: cs-etm: Move mapping of Trace ID and cpu into helper function Message-ID: References: <20230329111422.3693-1-mike.leach@linaro.org> <20230329111422.3693-2-mike.leach@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Em Wed, Mar 29, 2023 at 04:28:19PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Wed, Mar 29, 2023 at 03:47:25PM +0100, Mike Leach escreveu: > > On Wed, 29 Mar 2023 at 14:22, Arnaldo Carvalho de Melo wrote: > > > > > > Em Wed, Mar 29, 2023 at 01:59:10PM +0100, Mike Leach escreveu: > > > > Sorry - my error. > > > > > > > > The same change is made in patch 3/3 of this set. > > > > > > > > Looks like I didn't do a patch by patch build check when I was testing yesterday > > > > > > np, its fixed now and pushed to tmp.perf-tools-next, please check, will > > > go to perf-tools-next later today after passing thru my set of container > > > build tests. > > > > > > - Arnaldo > > > > tmp.perf-tools-next - Builds and tests OK > > Not here, I'll check after a call: > > 50 9.90 ubuntu:18.04-x-arm : FAIL gcc version 7.5.0 (Ubuntu/Linaro 7.5.0-3ubuntu1~18.04) > arch/arm/util/cs-etm.c: In function 'cs_etm_save_ete_header': > arch/arm/util/cs-etm.c:720:29: error: implicit declaration of function 'coresight_get_trace_id' [-Werror=implicit-function-declaration] > data[CS_ETE_TRCTRACEIDR] = coresight_get_trace_id(cpu); > ^~~~~~~~~~~~~~~~~~~~~~ This function was removed in: Author: Mike Leach Date: Wed Mar 29 12:14:21 2023 +0100 perf cs-etm: Update record event to use new Trace ID protocol Trace IDs are now dynamically allocated. I'm removing this series from perf-tools-next, please address this issue and send a v9. Thanks, - Arnaldo > cc1: all warnings being treated as errors > /git/perf-6.3.0-rc1/tools/build/Makefile.build:140: recipe for target 'util' failed > make[5]: *** [util] Error 2 > /git/perf-6.3.0-rc1/tools/build/Makefile.build:140: recipe for target 'arm' failed > make[4]: *** [arm] Error 2 > /git/perf-6.3.0-rc1/tools/build/Makefile.build:140: recipe for target 'arch' failed > make[3]: *** [arch] Error 2 > 51 9.50 ubuntu:18.04-x-arm64 : FAIL gcc version 7.5.0 (Ubuntu/Linaro 7.5.0-3ubuntu1~18.04) > arch/arm64/util/../../arm/util/cs-etm.c: In function 'cs_etm_save_ete_header': > arch/arm64/util/../../arm/util/cs-etm.c:720:29: error: implicit declaration of function 'coresight_get_trace_id' [-Werror=implicit-function-declaration] > data[CS_ETE_TRCTRACEIDR] = coresight_get_trace_id(cpu); > ^~~~~~~~~~~~~~~~~~~~~~ > cc1: all warnings being treated as errors > /git/perf-6.3.0-rc1/tools/build/Makefile.build:140: recipe for target 'util' failed > make[5]: *** [util] Error 2 > /git/perf-6.3.0-rc1/tools/build/Makefile.build:140: recipe for target 'arm64' failed > make[4]: *** [arm64] Error 2 > /git/perf-6.3.0-rc1/tools/build/Makefile.build:140: recipe for target 'arch' failed > make[3]: *** [arch] Error 2 > 52 19.34 ubuntu:18.04-x-m68k : Ok m68k-linux-gnu-gcc (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0 -- - Arnaldo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel