From: Jason Gunthorpe <jgg@nvidia.com>
To: Robin Murphy <robin.murphy@arm.com>
Cc: Steven Price <steven.price@arm.com>,
Heiko Stuebner <heiko@sntech.de>, Joerg Roedel <joro@8bytes.org>,
Will Deacon <will@kernel.org>,
iommu@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
John Keeping <john@metanate.com>
Subject: Re: [PATCH v3] iommu/rockchip: Add missing set_platform_dma_ops callback
Date: Thu, 30 Mar 2023 12:34:35 -0300 [thread overview]
Message-ID: <ZCWsC38WGyZi3Y0p@nvidia.com> (raw)
In-Reply-To: <3356d18f-d1ce-4995-2b95-16938df1b7d6@arm.com>
On Thu, Mar 30, 2023 at 04:09:03PM +0100, Robin Murphy wrote:
> > +static struct iommu_domain_ops rk_identity_ops = {
> > + .attach_dev = rk_iommu_identity_attach,
>
> Since it's going to behave like a regular identity domain and be treated as
> one, it needs to support .free as well.
It would be nice to provide some
static void iommu_domain_static_free(struct iommu_domain *){}
Or adjust the core code so NULL is OK..
I think this pattern of static singleton will be popular. I drafted a
patch for the DART driver like this too
Thanks,
Jason
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2023-03-30 15:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-30 14:46 [PATCH v3] iommu/rockchip: Add missing set_platform_dma_ops callback Steven Price
2023-03-30 15:09 ` Robin Murphy
2023-03-30 15:34 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZCWsC38WGyZi3Y0p@nvidia.com \
--to=jgg@nvidia.com \
--cc=heiko@sntech.de \
--cc=iommu@lists.linux.dev \
--cc=john@metanate.com \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robin.murphy@arm.com \
--cc=steven.price@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).