From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9EA34C77B60 for ; Fri, 31 Mar 2023 08:26:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Xy2LQHp9qn+HzAzNGSIhZFaeUr0ykXxQpmkLUAFq5+U=; b=Rb58UI9Ji2cPNx QmARlaX+xmVQx2CWp/tpEIRRfAV1W6TpdkvXBeyliRN9h0s1nUJV1OVPQ5kO3Lf/nGUiye9VMDRXp zMQAMRXrAbP88+ZgHXMK6k2Kpd//aYxwtq/g2jff77NsPX7KCM4L7+F9+qCs8TqWEZWxOky1qhGsW W0s/HsM1opYdNuHNyPf7eGM5vnx7lpx0LeJRwnKXeyRuxhFpHzCDrR5pHWObmrY74QIvrfIykbNP4 RclxF7551SC105jM4DhQe3UnPKKALJABYpMn3DuffPsHI6XhFNXkuTZL8jG5SxgraGVoRF7pDpPw/ aAlyZDa9smSd5rKIMZqw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1piA4e-006MrM-2K; Fri, 31 Mar 2023 08:25:28 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1piA3q-006MGC-2W for linux-arm-kernel@lists.infradead.org; Fri, 31 Mar 2023 08:24:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=WSWDDda2TuuKrdshOYENayNcESV0rnA62FdNuHFuLds=; b=rSt0ft84kxxHG7oCIx7ZquEpCk sk24e6a/mww4k20spQGqKRdesiGO4AA4Nnvkv0EqtIZ8fDVCxc7+LYR3xzy4mZiM/zzoz6aL8ro+O chl6gSHryzZIUqd4FpTr74LIivICRlOyCTmociIfABZPb/D74uaEbW09bvAIBtSbo9EeB3ccvQLVT hZjZIkSYxaOb1hzk6bCaV5BFC1kBqVcFAdLSDCoeZ+BNnAuxJz4tjECdmGRaMiNdzHm+C0gZazvNx labBIErkCe3exzLnjzhlRAAs+idajKeQgtlxuUJJEFrvuQWvKvhi7hyb/xZpiIoWdC8fXYr3mjJF1 9WcY7xUA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:58736) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1piA3i-0004I0-4W; Fri, 31 Mar 2023 09:24:30 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1piA3h-0000zs-1E; Fri, 31 Mar 2023 09:24:29 +0100 Date: Fri, 31 Mar 2023 09:24:29 +0100 From: "Russell King (Oracle)" To: Siddharth Vadapalli Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, rogerq@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, srk@ti.com Subject: Re: [PATCH net-next 2/2] net: ethernet: ti: am65-cpsw: Enable USXGMII mode for J784S4 CPSW9G Message-ID: References: <20230331065110.604516-1-s-vadapalli@ti.com> <20230331065110.604516-3-s-vadapalli@ti.com> <54c3964b-5dd8-c55e-08db-61df4a07797c@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <54c3964b-5dd8-c55e-08db-61df4a07797c@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230331_012438_841598_BADEC410 X-CRM114-Status: GOOD ( 18.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Mar 31, 2023 at 01:35:10PM +0530, Siddharth Vadapalli wrote: > Hello Russell, > > Thank you for reviewing the patch. > > On 31/03/23 13:27, Russell King (Oracle) wrote: > > On Fri, Mar 31, 2023 at 12:21:10PM +0530, Siddharth Vadapalli wrote: > >> TI's J784S4 SoC supports USXGMII mode. Add USXGMII mode to the > >> extra_modes member of the J784S4 SoC data. Additionally, configure the > >> MAC Control register for supporting USXGMII mode. Also, for USXGMII > >> mode, include MAC_5000FD in the "mac_capabilities" member of struct > >> "phylink_config". > > > > I don't think TI "get" phylink at all... > > > >> diff --git a/drivers/net/ethernet/ti/am65-cpsw-nuss.c b/drivers/net/ethernet/ti/am65-cpsw-nuss.c > >> index 4b4d06199b45..ab33e6fe5b1a 100644 > >> --- a/drivers/net/ethernet/ti/am65-cpsw-nuss.c > >> +++ b/drivers/net/ethernet/ti/am65-cpsw-nuss.c > >> @@ -1555,6 +1555,8 @@ static void am65_cpsw_nuss_mac_link_up(struct phylink_config *config, struct phy > >> mac_control |= CPSW_SL_CTL_GIG; > >> if (interface == PHY_INTERFACE_MODE_SGMII) > >> mac_control |= CPSW_SL_CTL_EXT_EN; > >> + if (interface == PHY_INTERFACE_MODE_USXGMII) > >> + mac_control |= CPSW_SL_CTL_XGIG | CPSW_SL_CTL_XGMII_EN; > > > > The configuration of the interface mode should *not* happen in > > mac_link_up(), but should happen in e.g. mac_config(). > > I will move all the interface mode associated configurations to mac_config() in > the v2 series. Looking at the whole of mac_link_up(), could you please describe what effect these bits are having: CPSW_SL_CTL_GIG CPSW_SL_CTL_EXT_EN CPSW_SL_CTL_IFCTL_A Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel