linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/1] clk: imx6ul: retain early UART clocks during kernel init
@ 2023-03-21 13:53 Alexander Stein
  2023-03-31 12:50 ` Abel Vesa
  0 siblings, 1 reply; 3+ messages in thread
From: Alexander Stein @ 2023-03-21 13:53 UTC (permalink / raw)
  To: Abel Vesa, Peng Fan, Michael Turquette, Stephen Boyd, Shawn Guo,
	Sascha Hauer, Fabio Estevam
  Cc: Alexander Stein, Pengutronix Kernel Team, NXP Linux Team,
	linux-clk, linux-arm-kernel

Make sure to keep UART clocks enabled during kernel init if
earlyprintk or earlycon are active.

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
Apparently i.MX6UL was missed in commit 0822f933735c ("clk: imx6: retain
early UART clocks during kernel init"). But as commit 379c9a24cc23 ("clk:
imx: Fix reparenting of UARTs not associated with stdout") changes the
calling signature it's not warranting a Fixes for the old commit.

 drivers/clk/imx/clk-imx6ul.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/clk/imx/clk-imx6ul.c b/drivers/clk/imx/clk-imx6ul.c
index 206e4c43f68f..26578e407d3e 100644
--- a/drivers/clk/imx/clk-imx6ul.c
+++ b/drivers/clk/imx/clk-imx6ul.c
@@ -510,6 +510,8 @@ static void __init imx6ul_clocks_init(struct device_node *ccm_node)
 		clk_set_parent(hws[IMX6ULL_CLK_EPDC_PRE_SEL]->clk, hws[IMX6UL_CLK_PLL3_PFD2]->clk);
 
 	clk_set_parent(hws[IMX6UL_CLK_ENFC_SEL]->clk, hws[IMX6UL_CLK_PLL2_PFD2]->clk);
+
+	imx_register_uart_clocks(2);
 }
 
 CLK_OF_DECLARE(imx6ul, "fsl,imx6ul-ccm", imx6ul_clocks_init);
-- 
2.34.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1] clk: imx6ul: retain early UART clocks during kernel init
  2023-03-21 13:53 [PATCH 1/1] clk: imx6ul: retain early UART clocks during kernel init Alexander Stein
@ 2023-03-31 12:50 ` Abel Vesa
  2023-03-31 19:58   ` Abel Vesa
  0 siblings, 1 reply; 3+ messages in thread
From: Abel Vesa @ 2023-03-31 12:50 UTC (permalink / raw)
  To: Alexander Stein
  Cc: Abel Vesa, Peng Fan, Michael Turquette, Stephen Boyd, Shawn Guo,
	Sascha Hauer, Fabio Estevam, Pengutronix Kernel Team,
	NXP Linux Team, linux-clk, linux-arm-kernel

On 23-03-21 14:53:24, Alexander Stein wrote:
> Make sure to keep UART clocks enabled during kernel init if
> earlyprintk or earlycon are active.
> 
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>

Applied, thanks!

[1/1] clk: imx6ul: retain early UART clocks during kernel init
      commit: edc6476d334adaeedf899c70e61264305155fd70

Best regards,
--
Abel Vesa <abel.vesa@linaro.org>

> ---
> Apparently i.MX6UL was missed in commit 0822f933735c ("clk: imx6: retain
> early UART clocks during kernel init"). But as commit 379c9a24cc23 ("clk:
> imx: Fix reparenting of UARTs not associated with stdout") changes the
> calling signature it's not warranting a Fixes for the old commit.
> 
>  drivers/clk/imx/clk-imx6ul.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/clk/imx/clk-imx6ul.c b/drivers/clk/imx/clk-imx6ul.c
> index 206e4c43f68f..26578e407d3e 100644
> --- a/drivers/clk/imx/clk-imx6ul.c
> +++ b/drivers/clk/imx/clk-imx6ul.c
> @@ -510,6 +510,8 @@ static void __init imx6ul_clocks_init(struct device_node *ccm_node)
>  		clk_set_parent(hws[IMX6ULL_CLK_EPDC_PRE_SEL]->clk, hws[IMX6UL_CLK_PLL3_PFD2]->clk);
>  
>  	clk_set_parent(hws[IMX6UL_CLK_ENFC_SEL]->clk, hws[IMX6UL_CLK_PLL2_PFD2]->clk);
> +
> +	imx_register_uart_clocks(2);
>  }
>  
>  CLK_OF_DECLARE(imx6ul, "fsl,imx6ul-ccm", imx6ul_clocks_init);
> -- 
> 2.34.1
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1] clk: imx6ul: retain early UART clocks during kernel init
  2023-03-31 12:50 ` Abel Vesa
@ 2023-03-31 19:58   ` Abel Vesa
  0 siblings, 0 replies; 3+ messages in thread
From: Abel Vesa @ 2023-03-31 19:58 UTC (permalink / raw)
  To: Alexander Stein
  Cc: Abel Vesa, Peng Fan, Michael Turquette, Stephen Boyd, Shawn Guo,
	Sascha Hauer, Fabio Estevam, Pengutronix Kernel Team,
	NXP Linux Team, linux-clk, linux-arm-kernel

On 23-03-31 15:50:19, Abel Vesa wrote:
> On 23-03-21 14:53:24, Alexander Stein wrote:
> > Make sure to keep UART clocks enabled during kernel init if
> > earlyprintk or earlycon are active.
> > 
> > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> 
> Applied, thanks!
> 
> [1/1] clk: imx6ul: retain early UART clocks during kernel init
>       commit: edc6476d334adaeedf899c70e61264305155fd70
> 
> Best regards,
> --
> Abel Vesa <abel.vesa@linaro.org>


Actually dropped, because of this:
https://lore.kernel.org/all/202304010336.L6H9SxmK-lkp@intel.com/

Rebase and resend if needed, please.

> 
> > ---
> > Apparently i.MX6UL was missed in commit 0822f933735c ("clk: imx6: retain
> > early UART clocks during kernel init"). But as commit 379c9a24cc23 ("clk:
> > imx: Fix reparenting of UARTs not associated with stdout") changes the
> > calling signature it's not warranting a Fixes for the old commit.
> > 
> >  drivers/clk/imx/clk-imx6ul.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/drivers/clk/imx/clk-imx6ul.c b/drivers/clk/imx/clk-imx6ul.c
> > index 206e4c43f68f..26578e407d3e 100644
> > --- a/drivers/clk/imx/clk-imx6ul.c
> > +++ b/drivers/clk/imx/clk-imx6ul.c
> > @@ -510,6 +510,8 @@ static void __init imx6ul_clocks_init(struct device_node *ccm_node)
> >  		clk_set_parent(hws[IMX6ULL_CLK_EPDC_PRE_SEL]->clk, hws[IMX6UL_CLK_PLL3_PFD2]->clk);
> >  
> >  	clk_set_parent(hws[IMX6UL_CLK_ENFC_SEL]->clk, hws[IMX6UL_CLK_PLL2_PFD2]->clk);
> > +
> > +	imx_register_uart_clocks(2);
> >  }
> >  
> >  CLK_OF_DECLARE(imx6ul, "fsl,imx6ul-ccm", imx6ul_clocks_init);
> > -- 
> > 2.34.1
> > 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-03-31 19:59 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-21 13:53 [PATCH 1/1] clk: imx6ul: retain early UART clocks during kernel init Alexander Stein
2023-03-31 12:50 ` Abel Vesa
2023-03-31 19:58   ` Abel Vesa

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).