From: Simon Horman <simon.horman@corigine.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Vinod Koul <vkoul@kernel.org>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Bhupesh Sharma <bhupesh.sharma@linaro.org>,
netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de
Subject: Re: [PATCH net-next 03/11] net: stmmac: dwmac-qcom-ethqos: Drop an if with an always false condition
Date: Mon, 3 Apr 2023 17:47:57 +0200 [thread overview]
Message-ID: <ZCr1LXCiaJoImjmJ@corigine.com> (raw)
In-Reply-To: <20230402143025.2524443-4-u.kleine-koenig@pengutronix.de>
On Sun, Apr 02, 2023 at 04:30:17PM +0200, Uwe Kleine-König wrote:
> The remove callback is only ever called after .probe() returned
> successfully. After that get_stmmac_bsp_priv() always return non-NULL.
>
> Side note: The early exit would also be a bug because the return value
> of qcom_ethqos_remove() is ignored by the device core and the device is
> unbound unconditionally. So exiting early resulted in a dangerous
> resource leak as all devm allocated resources (some memory and the
> register mappings) are freed but the network device stays around. Using
> the network device afterwards probably oopses.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-04-03 15:49 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-02 14:30 [PATCH net-next 00/11] net: stmmac: Convert to platform remove callback returning void Uwe Kleine-König
2023-04-02 14:30 ` [PATCH net-next 01/11] net: stmmac: Make stmmac_pltfr_remove() return void Uwe Kleine-König
2023-04-02 14:41 ` Jernej Škrabec
2023-04-03 15:55 ` Simon Horman
2023-04-03 20:39 ` Martin Blumenstingl
2023-04-02 14:30 ` [PATCH net-next 02/11] net: stmmac: dwmac-visconti: Make visconti_eth_clock_remove() " Uwe Kleine-König
2023-04-02 17:02 ` Simon Horman
2023-04-03 5:52 ` Uwe Kleine-König
2023-04-02 14:30 ` [PATCH net-next 03/11] net: stmmac: dwmac-qcom-ethqos: Drop an if with an always false condition Uwe Kleine-König
2023-04-03 15:47 ` Simon Horman [this message]
2023-04-02 14:30 ` [PATCH net-next 04/11] net: stmmac: dwmac-visconti: Convert to platform remove callback returning void Uwe Kleine-König
2023-04-03 15:46 ` Simon Horman
2023-04-02 14:30 ` [PATCH net-next 05/11] net: stmmac: dwmac-dwc-qos-eth: " Uwe Kleine-König
2023-04-03 15:49 ` Simon Horman
2023-04-02 14:30 ` [PATCH net-next 06/11] net: stmmac: dwmac-qcom-ethqos: " Uwe Kleine-König
2023-04-03 15:49 ` Simon Horman
2023-04-02 14:30 ` [PATCH net-next 07/11] net: stmmac: dwmac-rk: " Uwe Kleine-König
2023-04-03 15:50 ` Simon Horman
2023-04-02 14:30 ` [PATCH net-next 08/11] net: stmmac: dwmac-sti: " Uwe Kleine-König
2023-04-03 15:52 ` Simon Horman
2023-04-02 14:30 ` [PATCH net-next 09/11] net: stmmac: dwmac-stm32: " Uwe Kleine-König
2023-04-03 15:52 ` Simon Horman
2023-04-02 14:30 ` [PATCH net-next 10/11] net: stmmac: dwmac-sun8i: " Uwe Kleine-König
2023-04-02 14:41 ` Jernej Škrabec
2023-04-03 15:52 ` Simon Horman
2023-04-02 14:30 ` [PATCH net-next 11/11] net: stmmac: dwmac-tegra: " Uwe Kleine-König
2023-04-03 15:54 ` Simon Horman
2023-04-04 11:16 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZCr1LXCiaJoImjmJ@corigine.com \
--to=simon.horman@corigine.com \
--cc=alexandre.torgue@foss.st.com \
--cc=bhupesh.sharma@linaro.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=joabreu@synopsys.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peppe.cavallaro@st.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).