From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4222AC761A6 for ; Tue, 4 Apr 2023 11:17:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=tFdXu/1MvASEZ5g2PQA6OdJd2uPI2Q/yEIF3XiqTGAE=; b=HMZZmSz46EC0c1BPs4Mbikgzha Ksnsl6f6IpiQmKztPc265j6OeNCWCGlhq5Ae2IMFNavS5ox9cJO4dinM9y1YuTc7aeAjacvgDirSz ILGSHmzPhbb4FhbSvMFcapv/G8Xyi0Qo13NL0QjeB6x3I5keOHsxiYMNnpG4TNQBfIFslrgvhrYQR uzJ4nr4MSYuKGcjk8aipJ2WtBL1nIglNHA9BKNeDYLE6jrPmlopOL8Fr+dfzPZkkkOgnTndwbeqNY G8APqVajoGBkSSIcXE9kuZP5hNbTU+Hb7N0VAMBbeRkqKjGrWmQ6oYM7GEQL5n6hxGQTETEY/avD3 oRy0+iHw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pjeeE-0013Ec-1b; Tue, 04 Apr 2023 11:16:22 +0000 Received: from mail-ed1-x529.google.com ([2a00:1450:4864:20::529]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pjeeB-0013DB-24 for linux-arm-kernel@lists.infradead.org; Tue, 04 Apr 2023 11:16:20 +0000 Received: by mail-ed1-x529.google.com with SMTP id y4so129119728edo.2 for ; Tue, 04 Apr 2023 04:16:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680606973; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=a93jlFBEn37wnN+TcvU+K1AUTd72n1q82Rp2YlCTV3Q=; b=UyIkfrOmB7rJCwWoTVRwQQD9qhL2RcE3FbLY5o+pvNKiqfTCRdmL+TaH24hsQTY+ic /KodZsrgfNJPO93oHf67gUhdgVUgngVo1d/CxmFL4gU8qGrmHmcXfNtxCmkoESC7oU4H xVRn2djQO0j39P1cxFDg/84Ef4keE0k/wYGBgDm39dTMyYDywBQ7CZwLW3tYQpzmf9en yzJBz53R7NLVRYZN0nUvYPtv8HufFKZ1q+CcU/XYS/94AVd8BdW87AWvSyQJYmEisaat mKHEYQ0ytW8SuPd6GQOlgZ+GnQX/viQ6V/e83g9YIbapJakUswthgweaQ2og+JRWrT0X GaKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680606973; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=a93jlFBEn37wnN+TcvU+K1AUTd72n1q82Rp2YlCTV3Q=; b=WqV4Wmy+aTY+SkgmJpqht4AXaE/zkK3bZlL8AUIbNZVxESmB11mIHG7ELQ1HN4BwOh hF4/bdwSzbYZV5g2sbWQH0xquTUjUI37hGps220dPZ+6XTrN8Za5OITiTtkUdSIF/EG2 EX6iO6Il9cHiSbNqwdt+P63o8a6TWeWyVU/rpoRuFjnbVpbxXXaY/mbWXWeDiwaJdaz5 kM+y2w+NzCOJhaknJFM1mah6M6IIafbMZKc2HFZFqxpXK+jYcpTpsNA2JX2zSggsGWlY mveE2/NbRhOBQsDiG2YEOQLCwmbvs9PSCyAck6Z5p0fBODCmthSJ/hPPEeMbnBk8JZ6R 2elQ== X-Gm-Message-State: AAQBX9csoltX8ALUeoaCquFOtlZ5xwz1vatY6IukhzKxv2Ktlpw+P5ir SP4CWBHcgB7i4qhluiSs4UI= X-Google-Smtp-Source: AKy350YX2rjJgE8ohoVGUGgdqkT4aMdrcxdH+2xwiWoRgZ0Iqukk70bnmVt/ZEgV6aKvJBaBqME0gg== X-Received: by 2002:a17:907:170a:b0:8dd:5710:a017 with SMTP id le10-20020a170907170a00b008dd5710a017mr1740550ejc.4.1680606972817; Tue, 04 Apr 2023 04:16:12 -0700 (PDT) Received: from orome (p200300e41f1c0800f22f74fffe1f3a53.dip0.t-ipconnect.de. [2003:e4:1f1c:800:f22f:74ff:fe1f:3a53]) by smtp.gmail.com with ESMTPSA id f24-20020a170906825800b008bc8ad41646sm5815788ejx.157.2023.04.04.04.16.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Apr 2023 04:16:12 -0700 (PDT) Date: Tue, 4 Apr 2023 13:16:10 +0200 From: Thierry Reding To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Jonathan Hunter , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org, kernel@pengutronix.de Subject: Re: [PATCH net-next 11/11] net: stmmac: dwmac-tegra: Convert to platform remove callback returning void Message-ID: References: <20230402143025.2524443-1-u.kleine-koenig@pengutronix.de> <20230402143025.2524443-12-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 In-Reply-To: <20230402143025.2524443-12-u.kleine-koenig@pengutronix.de> User-Agent: Mutt/2.2.10 (2023-03-25) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230404_041619_684600_1CBDEB0A X-CRM114-Status: GOOD ( 18.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============4147822556051637490==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============4147822556051637490== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="OpE5E+f+NrCfJbvo" Content-Disposition: inline --OpE5E+f+NrCfJbvo Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Apr 02, 2023 at 04:30:25PM +0200, Uwe Kleine-K=C3=B6nig wrote: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is (mostly) ignored > and this typically results in resource leaks. To improve here there is a > quest to make the remove callback return void. In the first step of this > quest all drivers are converted to .remove_new() which already returns > void. >=20 > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. >=20 > Signed-off-by: Uwe Kleine-K=C3=B6nig > --- > drivers/net/ethernet/stmicro/stmmac/dwmac-tegra.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) Acked-by: Thierry Reding --OpE5E+f+NrCfJbvo Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmQsBvoACgkQ3SOs138+ s6EduRAAv3uNT9SNrysZJ44HOk63A5CQb1xTEVAacJguS9BsNgRfH79RGsaT9jWp axQPQQcoyqH9pSmJLUdXyknDjQ0V2fLjCm7FlMTpPn+WGarF6FEBy2F/0Q7B30d/ LIb1zYnuwNfW6rCWzZo/cTK/Neck8+zC7TQRbAg5PMrNGZadZf/wEpg+tBY4lL+X Dcrs4n+fD89x1VSEynqBIg3AyMFGsh1iWNQ9Icn7Hi9PUe2PiyUJmqmEPEwp6xEu qD3AwrN0jX+exBIn4BxojVms2alChLZvTDVzxWM2l217ANgALCWf/MQlBcGhuPpl j3wqdKpbRUcrg/B0BeFSQ1Fy2rrOnUbnexngxHsqG4voE6BZrXTicUjPH4pzOp7d KvEtXVVMmo5n3mXMI8PBUsJl3k3YQnMEo+Bu1JHf9q8EYrOmDLXkkopP/BmTXrN3 WswMR7BcGyC1rkMJ6pmnAp0qvEd8E5BK5NM6I6npvs0qaqw6rzYLNylMQkAwLpgK lVNsi8Gl/XSFtJwADUurLKiZCy/nkNXWh7O080/EZlKPkhEnvWemUndATh29ClmP DI7BbFaLtnb73mTtfuBozbIiFsZMnu4KfCls72hS1zYrFJ9FahXTSE6ny1InV86T UMNUYLR2MpLbYdqCJ07gm/3no/ErA/L4IRmzAWPMOLPu2gg869U= =/3Yh -----END PGP SIGNATURE----- --OpE5E+f+NrCfJbvo-- --===============4147822556051637490== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============4147822556051637490==--