From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CFE66C761A6 for ; Tue, 4 Apr 2023 13:30:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=vZGtCnm4/BSlvIY9PorMsHXU/P1WwBsQ7aNsq+UeNqI=; b=uo533ldGqYSKB33Bps09y4jHZ8 Y5AvHpgvGeefvudrOJjE095BPfQvyKRtC7/ijM1TALEv6smwYwOnCx7+qpOcqYw81rjPGpKWazznN RAy9VOn5UppWgiGxgXKxSQarNurvA0a6Trj3PIobMpLHHcJw62wY7/seIkTEBYMMe67Wv0MCm51JC eFo8zALhWIgvPs6CM9KteX9G57xaMIDLf3B5HrjwwuLenK03/1iz0Q2IUjA1bb9D/whqLVq/oUTbt 2v5g5J5VwfVf8xIhu5HWtjqlgJhY1CX7Fop0kXHSmDg/5BawpqR30KVMabbb7AvCQUecy/m//9VNx rpBHd8yw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pjgjh-001Sc2-0E; Tue, 04 Apr 2023 13:30:09 +0000 Received: from mail-ed1-x52e.google.com ([2a00:1450:4864:20::52e]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pjgje-001SbJ-2E for linux-arm-kernel@lists.infradead.org; Tue, 04 Apr 2023 13:30:07 +0000 Received: by mail-ed1-x52e.google.com with SMTP id r11so130670798edd.5 for ; Tue, 04 Apr 2023 06:30:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680615004; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=/1xSHxE1EltnFe4rBdKCgr4L21D3en11swmxi78/QJo=; b=bLUcssMAVwFowKXOWPM1CwtxkNm422B0OcXpOWrHzgiGiJzsm6/YgLo/UMlBhuHBfd Il9Oub1F/7X1iOg7r6YTlpSlY5pMAb5yJBU/14P/SxIWfsolcFdiHb3eu9TFo0D4nf+7 0cRj8CXV4afLv6SYPyOCupXLLBgWxT1d5qK5Y8APW0BjP5o+Q/LnEFIx7EwX5A+BT/l5 Jdk5xQuBjZUFRWjUkibnrSXLy4Gso3NnY4WsLIZcnoCWd/gCHGoWyUhHlC6ldSiZ6XHu Z4n218T3YQ470eRTFZQH6aZ79HV7K1M9dHjNEZCKCwwXJqWkTUmYvajFjE3BSKOnhHvH x07g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680615004; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/1xSHxE1EltnFe4rBdKCgr4L21D3en11swmxi78/QJo=; b=p3Jzb5jztEfA/O5hmNOl3JTkhDJzhhJpYokQTWEX7wTjoqZMBbLJjDSu+QARTJ95wD PI5xP5IdtCtILKBA9gOb0qLSz+fd1FAh7LpsNP1q9Knl3xCcK6SavIsDbZv5aEUtJ4Us f6gYdz6PHca1q9VLDqove1gc2Gh/1S/L4rbkDZPNKC5uF78H2wX3r1XPL9FyWpklONcN +fHDED/rToBJWcN9CVmPO1QgeOhu6SbZN8y1R5fHUHGkFueJtnhCJzlKsV7kZBuPHeyq yTiFkXyQXNPBGVW5ZNoiRT39a54PWDJIgScrJVCDpPSGGXYRPw3PwhinEz29bYLTEeC6 MHFQ== X-Gm-Message-State: AAQBX9enQIJy813u6qvuHd04Y9JmogYH7VNqH62X5oG1vnXBVR9fPHLX 3XU+e3/8SToRU7qxuZfcYlR8rEijNYY= X-Google-Smtp-Source: AKy350ZY7QhVY8loZEZFHvtjndpc4b0Kz415JBuObSnrseK7HdloY+pOgaUekGIUv0tm7DhIanNa8A== X-Received: by 2002:a17:906:c04f:b0:92e:e9c2:7b9c with SMTP id bm15-20020a170906c04f00b0092ee9c27b9cmr2486126ejb.77.1680615004393; Tue, 04 Apr 2023 06:30:04 -0700 (PDT) Received: from orome (p200300e41f1c0800f22f74fffe1f3a53.dip0.t-ipconnect.de. [2003:e4:1f1c:800:f22f:74ff:fe1f:3a53]) by smtp.gmail.com with ESMTPSA id e7-20020a170906c00700b0093f83562f09sm5981780ejz.87.2023.04.04.06.30.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Apr 2023 06:30:04 -0700 (PDT) Date: Tue, 4 Apr 2023 15:30:02 +0200 From: Thierry Reding To: Sudeep Holla Cc: Rob Herring , Cristian Marussi , Jonathan Hunter , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org Subject: Re: [PATCH] firmware: Use of_property_present() for testing DT property presence Message-ID: References: <20230310144704.1542045-1-robh@kernel.org> <20230323120030.7mk62xk7tco32zw2@bogus> MIME-Version: 1.0 In-Reply-To: <20230323120030.7mk62xk7tco32zw2@bogus> User-Agent: Mutt/2.2.10 (2023-03-25) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230404_063006_754578_82BFA4BF X-CRM114-Status: GOOD ( 17.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============7972264386609735854==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============7972264386609735854== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="iUHciihrTalbzd5s" Content-Disposition: inline --iUHciihrTalbzd5s Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Mar 23, 2023 at 12:00:30PM +0000, Sudeep Holla wrote: > On Fri, Mar 10, 2023 at 08:47:04AM -0600, Rob Herring wrote: > > It is preferred to use typed property access functions (i.e. > > of_property_read_ functions) rather than low-level > > of_get_property/of_find_property functions for reading properties. As > > part of this, convert of_get_property/of_find_property calls to the > > recently added of_property_present() helper when we just want to test > > for presence of a property and nothing more. > >=20 > > Signed-off-by: Rob Herring > > --- > > drivers/firmware/arm_scmi/optee.c | 2 +- >=20 > Acked-by: Sudeep Holla (for the SCMI part) >=20 > I am assuming you will route this as it has other changes as well in the > patch. I can also pick this up along with the Tegra changes if Rob doesn't want to take it. But also feel free to take this through whatever tree works best, for the Tegra parts: Acked-by: Thierry Reding --iUHciihrTalbzd5s Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmQsJlcACgkQ3SOs138+ s6HDEhAAiyZv2IDatqnjFzcpro55n2pEFFzSq+wC+Rmf0uZ2n7/irrlJRwrx0+II v1b6UP0dd7STZ+6vpKZ44WCXgrv58iushgVhqAD4W/tr8Q0uwUYc4vWzvv5UbN8S vD2uizF0UuHLbKb9r/SttWElOD9U/iyZrP7IHlngTdznWyb1g5xV9hg0Eu351+qb 7DDNvlErcR3XmYeUcUTCd/SPjjJw2ZWxrJ01StWJand9145/UXyazJxVZ6j+i8I+ OUjx81H8ctLG3TAwfv4zWnR5ZlGndViv/hjVSQasEMe5b84ScQNBnDZB+xmtZAMp Qn87+8fQcJgTP+UDR/YjjaHRegNGMu9fNqHS14+J2KFvn8nYS0xRPj3aDM8V7CS6 YDflkqK9r2je2dON9/UOKINRgqERHYIY1u9DTlaym97wUtE9a5uOelcsrAR3FScU SG35J16O95HSXGzoxhwpqbMS0N/Tm5IQruT2ih2D3WNTZQqsjk+7KFSJ8JWabXY1 UYig/IrGLf8dnLoD1KtzxQAwdDslHmvdofvWBY9IBI+GodYQzCZVtyDTKilHi9i3 dW0/eO5knVsW6yWRrgtUEK0X3gIIvSeGr4NF02uuNSmyY94U+Um8e/LXZvc3lckI +7VHpuvCR7jO4ORq18T2Yoq35yRvqrikIEonW3Oz5NHkAiXo+Iw= =Qivr -----END PGP SIGNATURE----- --iUHciihrTalbzd5s-- --===============7972264386609735854== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============7972264386609735854==--