From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AC3B0C6FD1D for ; Tue, 4 Apr 2023 20:48:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gL8FkGvTZD41MAHkDrNvhIm4hMckkzWOF6q0iXwJ2so=; b=sKIO/tHMsKRNT5 qZoaUd/BWqV+V9zvaQNtmaTla/+3TW5sCczWlfZl9m8O1uPuJAC2+EgEBBX8cLOEM68kY3natyuVX rhYfzo63Xc5r1fnFHjDu5ArPfymxQ125JxrNXFqSEoe/NYvsPh39Dqtyx+h8/gi4jwJEtAgRUoeJX zjRtc05BdCJXpUsZ6n72MGbdjSZJpkoEal0MSdmtXXuu9IwvyuqE82UBp/IBdqbE+PIujX86XRrrl lDJEd+Rprz19SeE8pALTH48p0nNttrm4YPk953fuHDYvqsnA9lVlsOE950sI88RFQjQP7EkwzLvdp RAFoZu+EjQksCEXSbcTw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pjnYr-002q2A-0v; Tue, 04 Apr 2023 20:47:25 +0000 Received: from desiato.infradead.org ([90.155.92.199]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pjmZY-002hwl-11 for linux-arm-kernel@bombadil.infradead.org; Tue, 04 Apr 2023 19:44:04 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=oo72y+C9GAk4TX3Xexbl8ChW3WJT6jJtrsPurmSXTHs=; b=MfJgS34c64xPlLxfuNpl8hmuuM die8kLwwx33el15o73jriZwmY7cejuf3bR+Entfz6RNsm5LhJiQaWtgIwBiaakE2LZFqwcWUTJLF0 5xMZTr3A//WCqAodzIQq9FbXPRa1mRTPGH4uIl7Qm+V4GN2zVNfppeGUjFDZNOZLndc9hVSjCL0EK erFAW9AGXHLNXQtyCtWU65eRleodde+OdNHZI3ZBMCyS0NTln4F+2V9l6nT18rDNog7qdleFBAexN lMnqNR80BAYl0UL54W5+OQhz+rsy6it7tUqr1KVD9raK5tU1J075MFMTeT+y/tw+6LkK5nkQv0o6j Vt9mWD/A==; Received: from out-49.mta1.migadu.com ([2001:41d0:203:375::31]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pjmZU-009NlO-1t for linux-arm-kernel@lists.infradead.org; Tue, 04 Apr 2023 19:44:02 +0000 Date: Tue, 4 Apr 2023 19:43:40 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1680637429; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oo72y+C9GAk4TX3Xexbl8ChW3WJT6jJtrsPurmSXTHs=; b=NSRjnW/TZah/qkXgQrr9JHQ/FWR4wEvSnoja35+kwW5MrctQfwh4GlnwcLCiuPZkkCkcaA /HzuZo/X+5T0jWLdwJHz4UF+6eNEPzg2jYp6klJeWrNAZvA1GLPKsZQRKcVMDTY5FNTZga KodSImPt6+c6nNgwQaVEU6F24QCrwtY= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: David Dai Cc: "Rafael J. Wysocki" , Viresh Kumar , Rob Herring , Krzysztof Kozlowski , Paolo Bonzini , Jonathan Corbet , Marc Zyngier , James Morse , Suzuki K Poulose , Zenghui Yu , Catalin Marinas , Will Deacon , Mark Rutland , Lorenzo Pieralisi , Sudeep Holla , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Valentin Schneider , kernel-team@android.com, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev Subject: Re: [RFC PATCH 0/6] Improve VM DVFS and task placement behavior Message-ID: References: <20230330224348.1006691-1-davidai@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230330224348.1006691-1-davidai@google.com> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230404_204400_778934_22D70CE5 X-CRM114-Status: GOOD ( 15.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Folks, On Thu, Mar 30, 2023 at 03:43:35PM -0700, David Dai wrote: > PCMark > Higher is better > +-------------------+----------+------------+--------+-------+--------+ > | Test Case (score) | Baseline | Hypercall | %delta | MMIO | %delta | > +-------------------+----------+------------+--------+-------+--------+ > | Weighted Total | 6136 | 7274 | +19% | 6867 | +12% | > +-------------------+----------+------------+--------+-------+--------+ > | Web Browsing | 5558 | 6273 | +13% | 6035 | +9% | > +-------------------+----------+------------+--------+-------+--------+ > | Video Editing | 4921 | 5221 | +6% | 5167 | +5% | > +-------------------+----------+------------+--------+-------+--------+ > | Writing | 6864 | 8825 | +29% | 8529 | +24% | > +-------------------+----------+------------+--------+-------+--------+ > | Photo Editing | 7983 | 11593 | +45% | 10812 | +35% | > +-------------------+----------+------------+--------+-------+--------+ > | Data Manipulation | 5814 | 6081 | +5% | 5327 | -8% | > +-------------------+----------+------------+--------+-------+--------+ > > PCMark Performance/mAh > Higher is better > +-----------+----------+-----------+--------+------+--------+ > | | Baseline | Hypercall | %delta | MMIO | %delta | > +-----------+----------+-----------+--------+------+--------+ > | Score/mAh | 79 | 88 | +11% | 83 | +7% | > +-----------+----------+-----------+--------+------+--------+ > > Roblox > Higher is better > +-----+----------+------------+--------+-------+--------+ > | | Baseline | Hypercall | %delta | MMIO | %delta | > +-----+----------+------------+--------+-------+--------+ > | FPS | 18.25 | 28.66 | +57% | 24.06 | +32% | > +-----+----------+------------+--------+-------+--------+ > > Roblox Frames/mAh > Higher is better > +------------+----------+------------+--------+--------+--------+ > | | Baseline | Hypercall | %delta | MMIO | %delta | > +------------+----------+------------+--------+--------+--------+ > | Frames/mAh | 91.25 | 114.64 | +26% | 103.11 | +13% | > +------------+----------+------------+--------+--------+--------+ > Next steps: > =========== > We are continuing to look into communication mechanisms other than > hypercalls that are just as/more efficient and avoid switching into the VMM > userspace. Any inputs in this regard are greatly appreciated. We're highly unlikely to entertain such an interface in KVM. The entire feature is dependent on pinning vCPUs to physical cores, for which userspace is in the driver's seat. That is a well established and documented policy which can be seen in the way we handle heterogeneous systems and vPMU. Additionally, this bloats the KVM PV ABI with highly VMM-dependent interfaces that I would not expect to benefit the typical user of KVM. Based on the data above, it would appear that the userspace implementation is in the same neighborhood as a KVM-based implementation, which only further weakens the case for moving this into the kernel. I certainly can appreciate the motivation for the series, but this feature should be in userspace as some form of a virtual device. -- Thanks, Oliver _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel