From: Thierry Reding <thierry.reding@gmail.com>
To: Rob Herring <robh@kernel.org>
Cc: Sudeep Holla <sudeep.holla@arm.com>,
Cristian Marussi <cristian.marussi@arm.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH] firmware: Use of_property_present() for testing DT property presence
Date: Tue, 4 Apr 2023 21:52:54 +0200 [thread overview]
Message-ID: <ZCyAFhY0xVy8Q0Yk@orome> (raw)
In-Reply-To: <20230404165846.GA49361-robh@kernel.org>
[-- Attachment #1.1: Type: text/plain, Size: 1316 bytes --]
On Tue, Apr 04, 2023 at 11:58:46AM -0500, Rob Herring wrote:
> On Tue, Apr 04, 2023 at 03:30:02PM +0200, Thierry Reding wrote:
> > On Thu, Mar 23, 2023 at 12:00:30PM +0000, Sudeep Holla wrote:
> > > On Fri, Mar 10, 2023 at 08:47:04AM -0600, Rob Herring wrote:
> > > > It is preferred to use typed property access functions (i.e.
> > > > of_property_read_<type> functions) rather than low-level
> > > > of_get_property/of_find_property functions for reading properties. As
> > > > part of this, convert of_get_property/of_find_property calls to the
> > > > recently added of_property_present() helper when we just want to test
> > > > for presence of a property and nothing more.
> > > >
> > > > Signed-off-by: Rob Herring <robh@kernel.org>
> > > > ---
> > > > drivers/firmware/arm_scmi/optee.c | 2 +-
> > >
> > > Acked-by: Sudeep Holla <sudeep.holla@arm.com>(for the SCMI part)
> > >
> > > I am assuming you will route this as it has other changes as well in the
> > > patch.
> >
> > I can also pick this up along with the Tegra changes if Rob doesn't
> > want to take it. But also feel free to take this through whatever tree
> > works best, for the Tegra parts:
> >
> > Acked-by: Thierry Reding <treding@nvidia.com>
>
> You can take it. Thanks.
Applied now, thanks.
Thierry
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-04-04 19:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-10 14:47 [PATCH] firmware: Use of_property_present() for testing DT property presence Rob Herring
2023-03-23 12:00 ` Sudeep Holla
2023-04-04 13:30 ` Thierry Reding
2023-04-04 16:58 ` Rob Herring
2023-04-04 19:52 ` Thierry Reding [this message]
2023-04-04 19:53 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZCyAFhY0xVy8Q0Yk@orome \
--to=thierry.reding@gmail.com \
--cc=cristian.marussi@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).