Re: [PATCH] staging: vchiq_arm: Make vchiq_platform_init() static

From: Simon Horman <horms@kernel.org>
To: Stefan Wahren <stefan.wahren@i2se.com>
Cc: Broadcom internal kernel review list
	<bcm-kernel-feedback-list@broadcom.com>,
	Nathan Chancellor <nathan@kernel.org>,
	Nick Desaulniers <ndesaulniers@google.com>,
	Tom Rix <trix@redhat.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-rpi-kernel@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-staging@lists.linux.dev, llvm@lists.linux.dev,
	Florian Fainelli <f.fainelli@gmail.com>
Subject: Re: [PATCH] staging: vchiq_arm: Make vchiq_platform_init() static
Date: Wed, 19 Apr 2023 10:51:06 +0200	[thread overview]
Message-ID: <ZD+rethobzN+rONr@kernel.org> (raw)
In-Reply-To: <e1fed875-059d-bf98-f9da-09c51f362be8@i2se.com>

On Wed, Apr 19, 2023 at 08:37:58AM +0200, Stefan Wahren wrote:
> Hi Simon,
> 
> Am 18.04.23 um 13:23 schrieb Simon Horman:
> > vchiq_platform_init() is only used in this file so it can be static.
> > 
> > clang-16 with W=1 reports:
> > 
> >   drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:465:5: error: no previous prototype for function 'vchiq_platform_init' [-Werror,-Wmissing-prototypes]
> >   int vchiq_platform_init(struct platform_device *pdev, struct vchiq_state *state)
> >       ^
> >   drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:465:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
> > 
> > Signed-off-by: Simon Horman <horms@kernel.org>
> 
> this is not the first attempt to fix this [1]. But maybe this has been fixed
> in the meantime.
> 
> [1] - https://lore.kernel.org/linux-staging/20221022043548.1671644-1-scottjcrouch@gmail.com/#t

Thanks,

I see in that thread that Greg notes that "this breaks the build in a very
horrible and strange way" [2].

I'm a bit surprised as I didn't observe such a thing.
But I also don't dispute it - clearly my testing was inadequate.

I'll try and dig a bit deeper into this one.
Perhaps starting with the report from the kernel test robot [3]

[2] https://lore.kernel.org/linux-staging/Y1Okpjbi2kKU2GFz@kroah.com/
[3] https://lore.kernel.org/linux-staging/202210230127.p1Dp295m-lkp@intel.com/

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel