From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B6B44C77B73 for ; Wed, 19 Apr 2023 08:52:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=umUu+pypnOAkfGFL3e68AiHWBDbAtxtGrIdhYAPSUZ0=; b=tiaEeVqF2+MjIz y04xahaYT5Nva5R0BzlkoRAOje/s6/WhvT9MUhkmm3ZX6tWm2mV9AyzaXTwhnOit9D8OMw2pZ669h IVppJKGmCwluTHd/jGyVnJ8odKpeq6cw1yTQD7puBfoIip1QOyU5uDNlIYQPYjGcRfEiGahoaAIC9 H7K0DReFXthdN9aEjJeIUXUfPMnvSxzTY6A5OT+74wZffRln1CzUtul1waoq41JbZm18NKNzUKjoO vfGLs+TocYnK7qTq5zZ9gDpfL8WQ5dSKA2y1sDUOd1pNBtt0pOy5+fT51eyrh15yf1C2JLXUalw17 2jvIFAKwyiZMILh+fc1w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pp3X2-004eWU-3D; Wed, 19 Apr 2023 08:51:17 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pp3Wz-004eVY-0u; Wed, 19 Apr 2023 08:51:14 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C997A61851; Wed, 19 Apr 2023 08:51:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 14E2DC433D2; Wed, 19 Apr 2023 08:51:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681894272; bh=VXrpOSBlujFi+hh3tYsCGOxDWdKBsM/QYjcPSg9RskE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ka7ocJbBGzZMh64ujq3JPqaSiDyCzuUb7UQ9jIjPNctNl3tAHXyS8iPrzTBzXW1Xa ZTGaaPFwNEwOu7/T10uoT2AkUtvvCGw/iA/ZR9TTHzez4wCnGxcJp/2Vm81M7vrrbU fxsGgIobRAncv2vykywEOcofgyQ764C3vAxebwBJ+Z2hT29ZkA+MHKw3/kCqY1xyhR dcme4FK8dkQqDIuDM3FCPmY7r98xH0fSn6MUZ6YNIlgjpshkyvdISA2RLN3nFCt+XV s7hbeuWt0UGXek2grLzYh3MWx7qjwJoBYJdVk+o/bTT+eu6AON8ZKym8aAEVECXkkX dClvpK4JcuaTA== Date: Wed, 19 Apr 2023 10:51:06 +0200 From: Simon Horman To: Stefan Wahren Cc: Broadcom internal kernel review list , Nathan Chancellor , Nick Desaulniers , Tom Rix , Greg Kroah-Hartman , linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, llvm@lists.linux.dev, Florian Fainelli Subject: Re: [PATCH] staging: vchiq_arm: Make vchiq_platform_init() static Message-ID: References: <20230418-vchiq_platform_init-static-v1-1-3c38ba81bc66@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230419_015113_355908_96E36BCB X-CRM114-Status: GOOD ( 19.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Apr 19, 2023 at 08:37:58AM +0200, Stefan Wahren wrote: > Hi Simon, > > Am 18.04.23 um 13:23 schrieb Simon Horman: > > vchiq_platform_init() is only used in this file so it can be static. > > > > clang-16 with W=1 reports: > > > > drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:465:5: error: no previous prototype for function 'vchiq_platform_init' [-Werror,-Wmissing-prototypes] > > int vchiq_platform_init(struct platform_device *pdev, struct vchiq_state *state) > > ^ > > drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:465:1: note: declare 'static' if the function is not intended to be used outside of this translation unit > > > > Signed-off-by: Simon Horman > > this is not the first attempt to fix this [1]. But maybe this has been fixed > in the meantime. > > [1] - https://lore.kernel.org/linux-staging/20221022043548.1671644-1-scottjcrouch@gmail.com/#t Thanks, I see in that thread that Greg notes that "this breaks the build in a very horrible and strange way" [2]. I'm a bit surprised as I didn't observe such a thing. But I also don't dispute it - clearly my testing was inadequate. I'll try and dig a bit deeper into this one. Perhaps starting with the report from the kernel test robot [3] [2] https://lore.kernel.org/linux-staging/Y1Okpjbi2kKU2GFz@kroah.com/ [3] https://lore.kernel.org/linux-staging/202210230127.p1Dp295m-lkp@intel.com/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel