From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7CC39C6FD18 for ; Wed, 19 Apr 2023 05:43:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/mAgql7WLccy3FCgnF5BX52RxcqGa1gTfpbiyY4RzFY=; b=c0h/susSOshjmP QsVdk0JIkHLf4mPjVcClztVwL71QiDCn5Lo1Qzw4J4Zaryma27g+wHuFLFuDY6E5Gd/lqB61d5BSf LQGyYB7Abe5SVyBasBM/bm+/JtV1UBbz1/pPsyR+6TDwQ7mrg5SaBQp9WK5J2avtYUwMzK9XY0JXE mKOA+yyuMKVHBSnm0B7MdqbUveRXJ+Gb/RP3Oe7W8a7Axkb6c7rov0qN/EcYglaQHMrg+AbO7TJP7 QUX3RapcNiV8uZ9IPblXvsGoGTDlbXwvUlpA2gW12/fHreImnqu6Zaw7oIDML3dVEziTqcKEYykVU Q5hJA4eBCQvj9CpA/CcA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pp0aW-0047fg-1x; Wed, 19 Apr 2023 05:42:40 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pp0aT-0047ep-2u; Wed, 19 Apr 2023 05:42:39 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 43B4C60FB5; Wed, 19 Apr 2023 05:42:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8905DC433D2; Wed, 19 Apr 2023 05:42:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681882956; bh=q1EDCX90eyaKlEozriKlZ5Kk5qpJSj1P9jvcWUQYroo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iQcXSmFd0/IJrBSATb9RSeOS6t/9XaLZ1mPMehX5pEUAgMVuvL/QGZudjHxX7YA5R ENZqy+Ah5c7mMYNTbgkQLsdnThTYueNcFDFZk9+NUCcN15Wlk8B8Emr6QFoN0at6rl ic8PKVpnHIWROV61I5GUbOwSNDJ2nbv8LSufsgFt+fAKsTS26+ffCTwNNJQNeVbO5p uJEgbGaa++uds3P8RUJvsVS2Y5ovbAOQsYam8DXkzgXj9MwUnxKDV99RykD+xW7GMu GmEY7856uxb9Lri2cT9qAdQuZdb9lcm+ZooAmoJ/OCM0tAmPXmK0QU4YTIFp0CAvsb rg3XV7jlTZKCg== Date: Wed, 19 Apr 2023 07:42:32 +0200 From: Simon Horman To: Nathan Chancellor Cc: Florian Fainelli , Greg Kroah-Hartman , Broadcom internal kernel review list , Nick Desaulniers , Tom Rix , linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, llvm@lists.linux.dev Subject: Re: [PATCH] staging: vchiq_arm: Make vchiq_platform_init() static Message-ID: References: <20230418-vchiq_platform_init-static-v1-1-3c38ba81bc66@kernel.org> <20230418184419.GB2635379@dev-arch.thelio-3990X> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230418184419.GB2635379@dev-arch.thelio-3990X> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230418_224238_017635_6423EB2D X-CRM114-Status: GOOD ( 25.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Apr 18, 2023 at 11:44:19AM -0700, Nathan Chancellor wrote: > On Tue, Apr 18, 2023 at 01:23:11PM +0200, Simon Horman wrote: > > vchiq_platform_init() is only used in this file so it can be static. > > > > clang-16 with W=1 reports: > > > > drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:465:5: error: no previous prototype for function 'vchiq_platform_init' [-Werror,-Wmissing-prototypes] > > int vchiq_platform_init(struct platform_device *pdev, struct vchiq_state *state) > > ^ > > drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:465:1: note: declare 'static' if the function is not intended to be used outside of this translation unit > > > > Signed-off-by: Simon Horman > > Introduced by commit 89cc4218f640 ("staging: vchiq_arm: drop unnecessary > declarations"), not sure it is worth a fixes tag since it is a W=1 > warning. Thanks. For some reason it didn't occur to me to check which patch introduced the issue. Perhaps because, as you say, it's a W=1 issue, and I don't think that warrants a fixes tag. I could include some information in the commit message, like "Introduced by ..." if desired. > Reviewed-by: Nathan Chancellor > > > --- > > drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c > > index 40dd62cf7399..59312b9f2058 100644 > > --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c > > +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c > > @@ -462,7 +462,8 @@ free_pagelist(struct vchiq_instance *instance, struct vchiq_pagelist_info *pagel > > cleanup_pagelistinfo(instance, pagelistinfo); > > } > > > > -int vchiq_platform_init(struct platform_device *pdev, struct vchiq_state *state) > > +static int > > +vchiq_platform_init(struct platform_device *pdev, struct vchiq_state *state) > > { > > struct device *dev = &pdev->dev; > > struct vchiq_drvdata *drvdata = platform_get_drvdata(pdev); > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel