From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 182C1C761A6 for ; Sun, 9 Apr 2023 07:53:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NuiWCjGMM1AirmW5bBLcr8PPDsjC/kfNHmpWtyEAll8=; b=VXX3sfPRNMEDnj 6Z5EFIZCTY/OzyqHaya3RM5kuepjfC3Guo+BjvhgM3jZIkQJ+ZCL79P89BPqRj4iwDbsp0pU+iZyl 4m6n2zmeGYAyVPjzE6M/C7AuiKdmYjw1vb2Jus0yaht4cT0beFYAit/DtB4kXs++phI808OSoLmqX mim2R5UX2kmZHEuJHDWjl/xIFQEi2Imu2nJ0MvWdJ/o/G9Luh8MlGHA2s5jkgzi+g8Dnf3smsqykE XP5ZOl1prar3NzhN7g1+3ol1j69lwA2REKdYxdKIcDP8K8HomJuzsMwAzxOWhROGmBUR+ORjPobtU rENFPZOXehKsUMXAEp7A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1plPqK-00DINA-0o; Sun, 09 Apr 2023 07:52:08 +0000 Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1plPq7-00DIMP-2y for linux-arm-kernel@lists.infradead.org; Sun, 09 Apr 2023 07:52:00 +0000 Received: by mail-wr1-x42d.google.com with SMTP id d9so2193602wrb.11 for ; Sun, 09 Apr 2023 00:51:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20210112.gappssmtp.com; s=20210112; t=1681026710; x=1683618710; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=dfO6Q33trJc9amyhdRbPtb/0kOtWlf2GzxFdUmEYiZk=; b=xu7oqttuRrYeLuPwLeDqLWb1YoZ2oNd1KlEtRiVW19w9PN84nrTEoob2dNVqjAD9if cZdXB0iwrxjSRq00/78tUW84AOS/LKBqANL8Kba4+ZetKECF6QpXg9lZL6tO7k+w6tEt 2MZz30BfwHo3HJmn+g/tvTeLYe76HtSh7mg1QMFQm7XKH3Uy3jAILiR0h8uACNBKJPuk TDQjU3qcdm+cLcnc69nC6WBBw4W0EmdwaBKnD700yE7yCLtC2B/xnkXk/KPAdbH1iRr7 OjYYlLCCbzJFGM8nBTm+g678wcPsBZQy47Q1BK4gifH4PBIiqJolIS2RPA+Pe7JEf3Q0 eMAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681026710; x=1683618710; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dfO6Q33trJc9amyhdRbPtb/0kOtWlf2GzxFdUmEYiZk=; b=zs7wLL2/+S/ncMXZQgizyzHbtA0Izu60POQ4s2xfvvZmigH/DFk99jVN5pQ3EnjeXZ bteHZxDSRTu9NiC+VwuNmuuDWQT3gXsGsGz66ewOs8e5MWzwqprFkgtOX8vNvbyUeLyv upbvCX0Im6c0uTGknDUnzJJIUIIftcKGV7I5cIKq6nxcUMI4SmDjyjvNpw+ecyx/YYhd aiRHQrV3fBFNwn+uv4nvBSOr25Co5+9zq9o4BFm9xnAFqzDjMxIf+N24ICKuCDsSuvif SdxoJukbAnG0B2ItOuz19TTYjF4NOhzYIFr5/Sn7uDFK+aPcenZyAFEowqo+OwqSTQcV U5MA== X-Gm-Message-State: AAQBX9cgozJnTH0JPDHImNV0xldvoGxz4+hXqBRPC/7sebnDmoVuf76P WdjEPQ0J2Qlzv4pz5EdMU0UfNw== X-Google-Smtp-Source: AKy350a7jE9qhPToVvbG60Udd4ofHEpP3TiNv3InRKJaBJlwkFhj4NxtJ4QB9S7gt55caA0ys3LmQQ== X-Received: by 2002:adf:f60b:0:b0:2ef:bbbc:de7d with SMTP id t11-20020adff60b000000b002efbbbcde7dmr2140633wrp.46.1681026710389; Sun, 09 Apr 2023 00:51:50 -0700 (PDT) Received: from localhost ([86.61.181.4]) by smtp.gmail.com with ESMTPSA id h18-20020a5d5052000000b002cfe0ab1246sm8642373wrt.20.2023.04.09.00.51.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 09 Apr 2023 00:51:49 -0700 (PDT) Date: Sun, 9 Apr 2023 09:51:48 +0200 From: Jiri Pirko To: Jakub Kicinski Cc: "Kubalewski, Arkadiusz" , Vadim Fedorenko , Vadim Fedorenko , Jonathan Lemon , Paolo Abeni , poros , mschmidt , "netdev@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-clk@vger.kernel.org" , "Olech, Milena" , "Michalik, Michal" Subject: Re: [PATCH RFC v6 2/6] dpll: Add DPLL framework base functions Message-ID: References: <20230312022807.278528-1-vadfed@meta.com> <20230312022807.278528-3-vadfed@meta.com> <2b749045-021e-d6c8-b265-972cfa892802@linux.dev> <20230403111812.163b7d1d@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230403111812.163b7d1d@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230409_005156_198293_5588D25A X-CRM114-Status: GOOD ( 13.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Mon, Apr 03, 2023 at 08:18:12PM CEST, kuba@kernel.org wrote: >On Wed, 15 Mar 2023 10:22:33 +0100 Jiri Pirko wrote: >> So basically you say, you can have 2 approaches in app: >> 1) >> id = dpll_device_get_id("ice/c92d02a7129f4747/1") >> dpll_device_set(id, something); >> dpll_device_set(id, something); >> dpll_device_set(id, something); >> 2): >> dpll_device_set("ice/c92d02a7129f4747/1, something); >> dpll_device_set("ice/c92d02a7129f4747/1, something); >> dpll_device_set("ice/c92d02a7129f4747/1, something); >> >> What is exactly benefit of the first one? Why to have 2 handles? Devlink >> is a nice example of 2) approach, no problem there. > >IMHO for devlink the neatness of using the name came from the fact >that the device name was meaningful. > >With the advent of auxbus that's no longer the case. > >In fact it seems more than likely that changing the name to auxbus >will break FW update scripts. Maybe nobody has complained yet only >because prod adoption of these APIs is generally lacking :( > >I agree that supporting both name and ID is pointless, user space can >translate between the two trivially all by itself. But I'd lean towards >deleting the name support not the ID support :( Wait, not sure you get the format of the "name". It does not contain any bus address, so the auxdev issue you pointed out is not applicable. It is driver/clock_id/index. All 3 are stable and user can rely on them. Do you see any issue in that? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel