From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1E11DC77B70 for ; Sun, 9 Apr 2023 13:45:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+4IJP1kyj+wanNUrhK+cArqZm5vuuLrFXPtYJlkfuwM=; b=gpTPNINoeTcnE/ hKZD1cIguKSrnycxo8aIyhNjMKr6uRcoM9ytXaEUNfbjs/fNAUGnj661Wb3UduE6L2Jhqm4aSmVag h/dVS/3y5mIlMkfOz2U4uVQBOL/k0jPpyzK8XKx1BE8xxCQksAt4syAjY2YZd+iG5hhIPDMiI+EJO Px9sN37F/X+y+zOyTB7m3AAGNr6LZHX7a6LM6RAVrbSVX65JQQIwIv4GcumszmxhQo/2adueQarlX MeaKuc1jbfKv2BhlEZ0p+JODiQOqexrx2ecmAtS0DrcS36X2c8IDh/haStPWMDh9G6T8/8PeILpQk 8mzun7UvmA8dqV3+hOPw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1plVLT-00Dmch-0h; Sun, 09 Apr 2023 13:44:39 +0000 Received: from mail-ej1-x62b.google.com ([2a00:1450:4864:20::62b]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1plVLQ-00Dmbf-2Z for linux-arm-kernel@lists.infradead.org; Sun, 09 Apr 2023 13:44:38 +0000 Received: by mail-ej1-x62b.google.com with SMTP id g18so18399591ejj.5 for ; Sun, 09 Apr 2023 06:44:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681047875; x=1683639875; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=XkDkuaBPjpy+EJtSPevUxDWOfOvzo71cgS8AvzVvmes=; b=kGpQFbNrH/sZl9SHXTheP1vIDUq6XbItuidowGQMpGZlUuUhOXLwcsudyVGHF4ivaz ZevGcIeeF8jhx6gckp/kYIYg4cmNG1mrt4N3jdfzMNUlsXyWKv1fKRAuMulC7kQO7hSE 0/W15kGG/f0SihfSwTvmX3dNmxgp7UnyRRKi2DtdGaNVNCivv3a1nPp0BQj7CyvmC1Js UWwcYXuHGQUaT3D1Oj1gUB5rM4mwwgVZJBo1MWl1SSFAlhtMo8cA1qdoeBnQ+kij/f8q 3sTRg1DmJgT/urbI0/KynQt2IJ5e1iWmhcrBsEUpSi2f/jzw2X9YAKR5Hukak8c0psZk 6+hA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681047875; x=1683639875; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XkDkuaBPjpy+EJtSPevUxDWOfOvzo71cgS8AvzVvmes=; b=BnRaDzU84nR3QG+ogv+KyTv6oGhZZNZlpYaOw4bqirJUzMc3qbB5sW4cdIGxQO2RI8 ZAWBzNyIicpp870GDALrIZLENtjx11Y7K4HtgUOh4NulvzEXtqMhITOTmgginU7Qs2wT q3WwwJw5JO+95JtZ2JL1WyVgeHVyhNeCwI353WDrDm9g7GPe4xf4Zy/SNe2VrJ1PKAr3 utHl4DrXI5+eXLWs5aDv5BgtSdTsCa19FXL3Fi57mjEp4ZZJZsqTYLtqqdYAhd2Q7QmW 1HslJXZ7yh92QSCkWLOfcSFKaloCEg15yOp5SPbQ9q469SK/0I5vHSDae2Ol6RUT1A0D om9A== X-Gm-Message-State: AAQBX9dlR06UwiFWIkLFVyhj92BryOqOXOD1UHL8E5Mwr3U0b/mYMoxG McV5TKOdfWgLI7ZvbW/qcUTQ/g== X-Google-Smtp-Source: AKy350bNFZIuIh+vV8kCLJfSB+asCNAdxTw09g9zMvMd/eWOiygIOtcmHZksluJaGdImKJABTV5gGQ== X-Received: by 2002:a17:906:2706:b0:947:71bf:ca19 with SMTP id z6-20020a170906270600b0094771bfca19mr3853980ejc.65.1681047875261; Sun, 09 Apr 2023 06:44:35 -0700 (PDT) Received: from linaro.org ([188.25.26.161]) by smtp.gmail.com with ESMTPSA id a12-20020a17090680cc00b00922a79e79c2sm4142096ejx.217.2023.04.09.06.44.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 09 Apr 2023 06:44:34 -0700 (PDT) Date: Sun, 9 Apr 2023 16:44:33 +0300 From: Abel Vesa To: "Peng Fan (OSS)" Cc: abelvesa@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-imx@nxp.com, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Peng Fan , Jacky Bai Subject: Re: [PATCH V3 1/7] clk: imx: fracn-gppll: fix the rate table Message-ID: References: <20230403095300.3386988-1-peng.fan@oss.nxp.com> <20230403095300.3386988-2-peng.fan@oss.nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230403095300.3386988-2-peng.fan@oss.nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230409_064436_840646_EF252628 X-CRM114-Status: GOOD ( 17.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 23-04-03 17:52:54, Peng Fan (OSS) wrote: > From: Peng Fan > > The Fvco should be range 2.4GHz to 5GHz, the original table voilate the > spec, so update the table to fix it. > > Fixes: c196175acdd3 ("clk: imx: clk-fracn-gppll: Add more freq config for video pll") > Fixes: 044034efbeea ("clk: imx: clk-fracn-gppll: fix mfd value") > Fixes: 1b26cb8a77a4 ("clk: imx: support fracn gppll") > Signed-off-by: Jacky Bai > Signed-off-by: Peng Fan Reviewed-by: Abel Vesa > --- > drivers/clk/imx/clk-fracn-gppll.c | 16 +++++++++------- > 1 file changed, 9 insertions(+), 7 deletions(-) > > diff --git a/drivers/clk/imx/clk-fracn-gppll.c b/drivers/clk/imx/clk-fracn-gppll.c > index a2aaa14fc1ae..ec50c41e2a4c 100644 > --- a/drivers/clk/imx/clk-fracn-gppll.c > +++ b/drivers/clk/imx/clk-fracn-gppll.c > @@ -60,18 +60,20 @@ struct clk_fracn_gppll { > }; > > /* > - * Fvco = Fref * (MFI + MFN / MFD) > - * Fout = Fvco / (rdiv * odiv) > + * Fvco = (Fref / rdiv) * (MFI + MFN / MFD) > + * Fout = Fvco / odiv > + * The (Fref / rdiv) should be in range 20MHz to 40MHz > + * The Fvco should be in range 2.5Ghz to 5Ghz > */ > static const struct imx_fracn_gppll_rate_table fracn_tbl[] = { > - PLL_FRACN_GP(650000000U, 81, 0, 1, 0, 3), > + PLL_FRACN_GP(650000000U, 162, 50, 100, 0, 6), > PLL_FRACN_GP(594000000U, 198, 0, 1, 0, 8), > - PLL_FRACN_GP(560000000U, 70, 0, 1, 0, 3), > - PLL_FRACN_GP(498000000U, 83, 0, 1, 0, 4), > + PLL_FRACN_GP(560000000U, 140, 0, 1, 0, 6), > + PLL_FRACN_GP(498000000U, 166, 0, 1, 0, 8), > PLL_FRACN_GP(484000000U, 121, 0, 1, 0, 6), > PLL_FRACN_GP(445333333U, 167, 0, 1, 0, 9), > - PLL_FRACN_GP(400000000U, 50, 0, 1, 0, 3), > - PLL_FRACN_GP(393216000U, 81, 92, 100, 0, 5) > + PLL_FRACN_GP(400000000U, 200, 0, 1, 0, 12), > + PLL_FRACN_GP(393216000U, 163, 84, 100, 0, 10) > }; > > struct imx_fracn_gppll_clk imx_fracn_gppll = { > -- > 2.37.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel