From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 850BAC77B70 for ; Sun, 9 Apr 2023 13:45:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xbQchbWHgzM6k+jg4lhvHHwEK3CTsQLLMnP5SEPeid4=; b=Hs05U6MOb4OTmt ZNPrDVLb1mcLUSZWdXfkas+35lOIN3t0ajZmkvJBEW+6K50FlPwqPcbTL4kaGGaipRgQnL5aA5mbF 4XId/eboC5eL1kMAOeYyZL2xNC85TjvkQ9cQJ0h5BsF+9hVHSkifJAsnS4C0FySFn574IXlY7iQiM KqYUkYS/6wLVT74ASzn/0qSHyV2taZbMBSwPkN35ZcdfauykR5H699TW/0GxUotHV3R9IbSAhYnYp pz+BYsO4GY2gbkuMRDd9azrdxfL74cl4sy2ZVYjNjjTcJlNl46hTUbp+GlKETHqgK1tWT4nEZmS60 tLdCGVykuI/utJtHBWPA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1plVLk-00Dmf8-22; Sun, 09 Apr 2023 13:44:56 +0000 Received: from mail-ej1-x634.google.com ([2a00:1450:4864:20::634]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1plVLi-00DmeW-0O for linux-arm-kernel@lists.infradead.org; Sun, 09 Apr 2023 13:44:55 +0000 Received: by mail-ej1-x634.google.com with SMTP id a640c23a62f3a-94a34c2bc67so56940766b.2 for ; Sun, 09 Apr 2023 06:44:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681047892; x=1683639892; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=929lK8VO6bxJRF9BB7+iqZUXPeNl84XwHZdASD9/Zdo=; b=rYxKvfTrEXb5OIqyGp9lTdB00YiRER+tpYnhAFQsRh+B7awVo2Oo+3rJne/F5P62G1 mvp6fEZxUzMPO2rsCXLEja1+O42269dyAt2exOLAV8Vd6tCRR/0dK/1EtBRcQasOX3WN ZxX7/Wmbe2qHIPldHg7pXB5H8TELQIQGNi7R+WoaJqKc1+ul9VkoppcTJtW3jq/qbROa oTwpfdU8E0EOeDzwFM2jI6n+2ssnLhtLLNzm6GYtbG3ns33lWeoPMTElwUHJ93PYBbrE qj3Dn02q8GnZli1cle+0lfwY5noe/RkCOO4BrZ3/lGmhdQEI/oSpamGJSiGrLgj45+qD JB7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681047892; x=1683639892; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=929lK8VO6bxJRF9BB7+iqZUXPeNl84XwHZdASD9/Zdo=; b=RwLKltQPaupgkiJHRgP2fk7Fx8Q7kmk3Nq2JLFkddLk+72wRHVcrnjzjNErX1yIWtB K1R6QkrGl7YKJQAzhGXrBio0ZE/uQZkTj55itNUNREhs3a3L9ta81pcjFWwwQko9L8jQ F1prLzJ4KjYQnITZjdAV9vPeoxLUThNTc5Qs1PBS495q4bB9bS16cFbuTiJSpYJ6Z86d nPuDLdXQWkKMG3LM2+DNyWv2kekcZv1JDn8ibh6tjE1R2gqib2nMqvOGltxEfoO346E6 jJpzlhhAH6+Rw3SOVC51+CL4IrK9HVYZiD+qPL2w7J4u+/Yi5V9W1zz9TfXx4HAEYwbE 8rDQ== X-Gm-Message-State: AAQBX9d+9RWkZwc0+mM/CUcLwVnTFhlxzm9UhrvKrHnbNtznHzGQdKzr xdWfUmJsjZj3OxIinmL5PMOx2Q== X-Google-Smtp-Source: AKy350YcZwQIld2OZPKeYxCnySWYyl53q0DSZapxZVKetjrWq8kcxFbiXFfTQ59ktk9wP6EnfyXE9Q== X-Received: by 2002:a50:ed8b:0:b0:4fc:b51f:ff50 with SMTP id h11-20020a50ed8b000000b004fcb51fff50mr6831694edr.30.1681047892174; Sun, 09 Apr 2023 06:44:52 -0700 (PDT) Received: from linaro.org ([188.25.26.161]) by smtp.gmail.com with ESMTPSA id a71-20020a509ecd000000b00501dd53dbfbsm3952172edf.75.2023.04.09.06.44.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 09 Apr 2023 06:44:51 -0700 (PDT) Date: Sun, 9 Apr 2023 16:44:50 +0300 From: Abel Vesa To: "Peng Fan (OSS)" Cc: abelvesa@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-imx@nxp.com, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Peng Fan Subject: Re: [PATCH V3 2/7] clk: imx: fracn-gppll: disable hardware select control Message-ID: References: <20230403095300.3386988-1-peng.fan@oss.nxp.com> <20230403095300.3386988-3-peng.fan@oss.nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230403095300.3386988-3-peng.fan@oss.nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230409_064454_163699_6C7EF203 X-CRM114-Status: GOOD ( 14.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 23-04-03 17:52:55, Peng Fan (OSS) wrote: > From: Peng Fan > > When programming PLL, should disable Hardware control select to make PLL > controlled by register, not hardware inputs through OSCPLL. > > Fixes: 1b26cb8a77a4 ("clk: imx: support fracn gppll") > Signed-off-by: Peng Fan Reviewed-by: Abel Vesa > --- > drivers/clk/imx/clk-fracn-gppll.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/clk/imx/clk-fracn-gppll.c b/drivers/clk/imx/clk-fracn-gppll.c > index ec50c41e2a4c..f6674110a88e 100644 > --- a/drivers/clk/imx/clk-fracn-gppll.c > +++ b/drivers/clk/imx/clk-fracn-gppll.c > @@ -15,6 +15,7 @@ > #include "clk.h" > > #define PLL_CTRL 0x0 > +#define HW_CTRL_SEL BIT(16) > #define CLKMUX_BYPASS BIT(2) > #define CLKMUX_EN BIT(1) > #define POWERUP_MASK BIT(0) > @@ -193,6 +194,11 @@ static int clk_fracn_gppll_set_rate(struct clk_hw *hw, unsigned long drate, > > rate = imx_get_pll_settings(pll, drate); > > + /* Hardware control select disable. PLL is control by register */ > + tmp = readl_relaxed(pll->base + PLL_CTRL); > + tmp &= ~HW_CTRL_SEL; > + writel_relaxed(tmp, pll->base + PLL_CTRL); > + > /* Disable output */ > tmp = readl_relaxed(pll->base + PLL_CTRL); > tmp &= ~CLKMUX_EN; > -- > 2.37.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel