From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 65651C77B70 for ; Sun, 9 Apr 2023 14:10:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gZd4w69f8HYn7NbvZsxrpP7pennRQntUyd7Tif1+LqQ=; b=snBla+t0OaMBRC 4xIuAdPSohRufScRQ6Tc8/Z64wRQ5JbvzAAGnZ9+i7XcZLzrGmyVDAJVqat/JbRDxij4XRzmVAY1m kXCAlHmbeHe7QckRBDASn+4JcUKpqRImKHk746jI7TIFp2SJLgx0gwwEuK1TgMf5jn9hVwningbkS MLSJaKYIkopqnu6sCONOsilmSLyhhuz8vvEnUTVfac4coQKCBuLVJG0ZId3EUL1VS+IwLi0dhsDEg Fm5cm2/SQ2nlLkbNgW2Zu9r7XHngcV9IdOUNQClXIp9QNotLs/dvpzcoLztQXdRL8PsmagVjREKzR ohL4CTijEOjnP2OhhzyA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1plVjb-00DpAM-01; Sun, 09 Apr 2023 14:09:35 +0000 Received: from mail-ej1-x632.google.com ([2a00:1450:4864:20::632]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1plVjZ-00Dp9Q-04 for linux-arm-kernel@lists.infradead.org; Sun, 09 Apr 2023 14:09:34 +0000 Received: by mail-ej1-x632.google.com with SMTP id qa44so6764539ejc.4 for ; Sun, 09 Apr 2023 07:09:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681049369; x=1683641369; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=3QC/+02Fx1bZjSkOiyg9i0tDZlYd8mwmfGVMqDc10Bc=; b=x1SBAshYQNO02+4XIJDsBjHGqiSqxyggmv5imncBX+Z4oyhCo3o3rRlKy6ckIu84q6 g9jlrQ/gHSBMkT+JdPr72SuIe0BhooUH6n2xDGyLtGjcaHz1S3mDZWYaldiQttLTyJKv V4K7rTAA6DHfiH+sOZnQCb12epmR9QchOFeFnvgMAXYXn8x2KLT1jVZBrULc74yk/mFd 9fd54KV6jdJz7Q0iwJi6b0t1ZQpl97jtwRNtJ9hRDTULsVOvWtHIdbYGbImR1eqwJHMZ ZsRHl7LXa0yHkaWV5O9og7Q63daSaYx0HIFo+4iqbcI3iHpx4N+sSw2Kk9g2r8JSJSeN QnBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681049369; x=1683641369; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3QC/+02Fx1bZjSkOiyg9i0tDZlYd8mwmfGVMqDc10Bc=; b=c0WZzNOWJ8wUeW9KMk2d/SW4Q4k5CgicDWe+7WH+Okiq6BN5qNsQrTHEK8dPHa+7sF 5bPERZY9cE+SBfYOat+C3fAM0iyqbNO9ZoJLBh2T2Iwx+UA2mcS9yIfywOnLvyEiAy+M ddiVFI8POVx/tO1x1estBU6O6sA/O8nHp14HefzAzqj3NlCzXL2eIOJsxFJIHhYLswcx Kq2R8IAz8CWlu89V3HhbObIFGrfBtKJN50axVn42srsIib0DNuVRLAveUitw5qyiQ4UA c6qlax7GFDqKE/KfSyBhJjzRkuJuENlUdeTSlM41XiAcL9KwCiK968T7xEwfO0IY/oxw izJg== X-Gm-Message-State: AAQBX9d8ylefSN9HB6ZRdFlZJvLN7WzU4/SMDUPARNjNc5TLkGsVeC+v rSSTyhB2faaeCB5wSYy3UcuLWA== X-Google-Smtp-Source: AKy350aJoM9h5ui0mcPGw4CFuh/uYp1HEIXFFDYRxxO+bcpHzaMMsaRTVvl3HF7xMdWdl6S44Q76Bw== X-Received: by 2002:a17:907:8814:b0:94a:87d6:d39e with SMTP id ro20-20020a170907881400b0094a87d6d39emr430353ejc.58.1681049369395; Sun, 09 Apr 2023 07:09:29 -0700 (PDT) Received: from linaro.org ([188.25.26.161]) by smtp.gmail.com with ESMTPSA id d24-20020a50f698000000b0050299cebf6esm3923724edn.54.2023.04.09.07.09.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 09 Apr 2023 07:09:28 -0700 (PDT) Date: Sun, 9 Apr 2023 17:09:27 +0300 From: Abel Vesa To: "Peng Fan (OSS)" Cc: abelvesa@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan , Jacky Bai , Ye Li Subject: Re: [PATCH 1/5] clk: imx: imx8ulp: Fix XBAR_DIVBUS and AD_SLOW clock parents Message-ID: References: <20230331063814.2462059-1-peng.fan@oss.nxp.com> <20230331063814.2462059-2-peng.fan@oss.nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230331063814.2462059-2-peng.fan@oss.nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230409_070933_058102_DB327845 X-CRM114-Status: GOOD ( 16.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 23-03-31 14:38:10, Peng Fan (OSS) wrote: > From: Peng Fan > > XBAR_DIVBUS and AD_SLOW should set parent to XBAR_AD_DIVPLAT and > XBAR_DIVBUS respectively, not the NIC_AD. otherwise we will get > wrong clock rate. > > Fixes: c43a801a5789 ("clk: imx: Add clock driver for imx8ulp") > Reviewed-by: Jacky Bai > Signed-off-by: Ye Li > Signed-off-by: Peng Fan Reviewed-by: Abel Vesa > --- > drivers/clk/imx/clk-imx8ulp.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/clk/imx/clk-imx8ulp.c b/drivers/clk/imx/clk-imx8ulp.c > index a07df3b44703..89121037a8f0 100644 > --- a/drivers/clk/imx/clk-imx8ulp.c > +++ b/drivers/clk/imx/clk-imx8ulp.c > @@ -200,8 +200,8 @@ static int imx8ulp_clk_cgc1_init(struct platform_device *pdev) > clks[IMX8ULP_CLK_NIC_AD_DIVPLAT] = imx_clk_hw_divider_flags("nic_ad_divplat", "nic_sel", base + 0x34, 21, 6, CLK_SET_RATE_PARENT | CLK_IS_CRITICAL); > clks[IMX8ULP_CLK_NIC_PER_DIVPLAT] = imx_clk_hw_divider_flags("nic_per_divplat", "nic_ad_divplat", base + 0x34, 14, 6, CLK_SET_RATE_PARENT | CLK_IS_CRITICAL); > clks[IMX8ULP_CLK_XBAR_AD_DIVPLAT] = imx_clk_hw_divider_flags("xbar_ad_divplat", "nic_ad_divplat", base + 0x38, 14, 6, CLK_SET_RATE_PARENT | CLK_IS_CRITICAL); > - clks[IMX8ULP_CLK_XBAR_DIVBUS] = imx_clk_hw_divider_flags("xbar_divbus", "nic_ad_divplat", base + 0x38, 7, 6, CLK_SET_RATE_PARENT | CLK_IS_CRITICAL); > - clks[IMX8ULP_CLK_XBAR_AD_SLOW] = imx_clk_hw_divider_flags("xbar_ad_slow", "nic_ad_divplat", base + 0x38, 0, 6, CLK_SET_RATE_PARENT | CLK_IS_CRITICAL); > + clks[IMX8ULP_CLK_XBAR_DIVBUS] = imx_clk_hw_divider_flags("xbar_divbus", "xbar_ad_divplat", base + 0x38, 7, 6, CLK_SET_RATE_PARENT | CLK_IS_CRITICAL); > + clks[IMX8ULP_CLK_XBAR_AD_SLOW] = imx_clk_hw_divider_flags("xbar_ad_slow", "xbar_divbus", base + 0x38, 0, 6, CLK_SET_RATE_PARENT | CLK_IS_CRITICAL); > > clks[IMX8ULP_CLK_SOSC_DIV1_GATE] = imx_clk_hw_gate_dis("sosc_div1_gate", "sosc", base + 0x108, 7); > clks[IMX8ULP_CLK_SOSC_DIV2_GATE] = imx_clk_hw_gate_dis("sosc_div2_gate", "sosc", base + 0x108, 15); > -- > 2.37.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel