From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8D016C77B6E for ; Mon, 10 Apr 2023 02:31:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KAA8qIM3aeJznKOiTpc9iMso2zs9bGaowVLCEOCVMmw=; b=aZfARqiBwGvs49 ZRM7z/g4CWcmACtxCKh7Zurc5ky94dHolvzpf+4YO61tSQ0e9xy558C05MoqbrG1axERQSEvOASHw z97z8vQPrv8EhI/krXmnkuZUvnNEpKGVzfRUnf9qOBK6hKt2pgNeRnTPQUKAnaiHhoMBvPb7fFjAr M5Ju4ELtvIDuW2n93Uh8kVJObgsQZggc6cFjybXVU0918QJt/+xOVRc0GqUWzJLbBoejJhDU7gxyg PBuPTwm4Footz77I4Ggo1BUtJkXKpHjbfUyGgBK64qFLbaXsYcw4taO3HoVxcLBeUzEf/kOcZTnm0 PDlUHNqgKyCdT/pUVghw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1plhIx-00ESb7-2c; Mon, 10 Apr 2023 02:30:51 +0000 Received: from mail-pf1-x435.google.com ([2607:f8b0:4864:20::435]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1plhIu-00ESah-1H for linux-arm-kernel@lists.infradead.org; Mon, 10 Apr 2023 02:30:49 +0000 Received: by mail-pf1-x435.google.com with SMTP id d2e1a72fcca58-6346aa0a227so305116b3a.1 for ; Sun, 09 Apr 2023 19:30:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1681093847; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=91oVa4U4E752SRKAZUiXCqWTpRWldtV5m/eQGoWFvDo=; b=GvjyKFfrXQTDTegaGVK2x3sG0Ip6I3hXwmxFfOJmMEaHR3FIpZXlAWKenZDLqvBSPu puqcCBoYi4yqP7Q2ciPTlbPkpHDluTpkF7hud2O5kOk4VFK2ULK9zwJttHL/uKGfaGog BKABVer4EjKFxgiupm7RulsPxONmCa7ZRqa0D35uiB3BGDbX6SGxzSuYFXegS87cEUq5 3+hAyEhRKhiMtgQrVBGdxi22HvKUi10Z4RUlTyIkSxrwpL7FlqeB3Bh7ZTseIp/AOAI0 PAdtNlIAJSxK2ziOqKUNi8wXjnbEcUV5LaFA8ruWLlrtsFeobb1d+bArks5aVsd+sCy9 mttg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681093847; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=91oVa4U4E752SRKAZUiXCqWTpRWldtV5m/eQGoWFvDo=; b=a84xSBhr3iYVoHJFi9xIWhnTB1QNgHmWtEbnveWoHnStxJeMvZvcJxP+0JlHu7WbUl jDdcpxqPywQ9/HV/r+HOIECe4OkLzsoA2iG2inkGn5SGM6esXsFbmP4eP+dgoi0j8ipx m2++Nfb/JrPKoG0kDUruvOWgY1AdJLqtozZUPaw4v+T58wd6lGNFeoQd2jj8/OFaRLeq l/ra5sQqql5x/AicFX66KLsSZLIuE0Lx9p4ss2MenlZ5BEDOj/8UeeIOYKsHed+rA7pv EGTDScHiau7eRwmtw1cQwLHe08S4NOrcv6ri0sZUmS9gZjbkIren1fZsdCKiBC7836Hf AbCw== X-Gm-Message-State: AAQBX9fhs6IwpojdTHDdTSflb7SjbBV7fR3sS8yvBoBKgDHC0E0LiGlo UPKFB4asaM7BFMve/sBiCXk= X-Google-Smtp-Source: AKy350arnos9p4x6ClCP16vCSb7Y1qpCkhOMhsM+5TChYcKYrgNgkdmDap4qv4y7/IEV5piWIUV7pg== X-Received: by 2002:a62:1d4d:0:b0:625:fe95:f120 with SMTP id d74-20020a621d4d000000b00625fe95f120mr6471688pfd.8.1681093846702; Sun, 09 Apr 2023 19:30:46 -0700 (PDT) Received: from google.com ([2620:15c:9d:2:803c:4683:913e:ce04]) by smtp.gmail.com with ESMTPSA id i22-20020aa79096000000b005e0699464e3sm6614117pfa.206.2023.04.09.19.30.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 09 Apr 2023 19:30:45 -0700 (PDT) Date: Sun, 9 Apr 2023 19:30:42 -0700 From: Dmitry Torokhov To: "Peng Fan (OSS)" Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org, aisheng.dong@nxp.com, linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, Peng Fan Subject: Re: [PATCH 2/2] input: imx_sc_key: add wakeup support Message-ID: References: <20230323093141.4070840-1-peng.fan@oss.nxp.com> <20230323093141.4070840-2-peng.fan@oss.nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230323093141.4070840-2-peng.fan@oss.nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230409_193048_438324_0360C5D2 X-CRM114-Status: GOOD ( 18.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Mar 23, 2023 at 05:31:41PM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > Add support for waking up from system wide suspend. > > Signed-off-by: Peng Fan > --- > drivers/input/keyboard/imx_sc_key.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/input/keyboard/imx_sc_key.c b/drivers/input/keyboard/imx_sc_key.c > index d18839f1f4f6..234f23cf9990 100644 > --- a/drivers/input/keyboard/imx_sc_key.c > +++ b/drivers/input/keyboard/imx_sc_key.c > @@ -151,6 +151,8 @@ static int imx_sc_key_probe(struct platform_device *pdev) > priv->input = input; > platform_set_drvdata(pdev, priv); > > + device_init_wakeup(&pdev->dev, device_property_read_bool(&pdev->dev, "wakeup-source")); > + I wonder - could we move this to the device core? > error = imx_scu_irq_group_enable(SC_IRQ_GROUP_WAKE, SC_IRQ_BUTTON, > true); > if (error) { > -- > 2.37.1 > Thanks. -- Dmitry _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel