From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0368AC76196 for ; Mon, 10 Apr 2023 23:49:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=46xNUxKn/P2AJOSR6gn5pPKzczKEUZkpUCHnDsrwZeg=; b=hLsbj9nqBfkHn5 PftdMUyP0VkNLVIZSHFQ1YnF0AtQF5rfonylOWxVgfZe6MhPcg7C8y4Uw25YzJQ8uH2RbtgUGaYkO ZlkzHcgDEHp/2nWmJYEKaBhoFXRotbjVR5x5DQg+xqCCOaPo6A1ggR2zVXYF7EgAVChzrYiBWzAGQ VYU4/S/VkuUcs790l7nx9c7Wnv+UyoToJS97uaFEfeO9lX7AVol1/Dbi2QGSm20ochpjuYKFsPer3 ivkUkMckqkNaKMZ8bQyNhWPWTl+H7wwNX7gh89zFm1SfEiBWwUsX1TfvAJvMDu2zC/PK824beRzZA tOmCCRvafY3b0LjY4Xog==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pm1Fl-00G6zL-1Y; Mon, 10 Apr 2023 23:48:53 +0000 Received: from mga02.intel.com ([134.134.136.20]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pm1Fi-00G6yE-2n for linux-arm-kernel@lists.infradead.org; Mon, 10 Apr 2023 23:48:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1681170530; x=1712706530; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=HLABFzxIaBKdwMWhvhRoqNf4XliHa9M847b79qETyi0=; b=hAM1JxNB7w61QfBRhY/Tf0z7E5JTctxcXsh2yQMHmpzaxvipYj2X4CLY shJFK9qs+84tMObpuxuBudhU+fAYqWjcucVs9aq6SPA9s8trMzjAaamjH 6hsbHH4P8sGZMchD5h5ZD/8hV/C2nOOplp3s2E2cRqhzkZNU0XuNDqfZt KYb783eaabSOfb5A1KpbzJrIWDT+I9enVotubpIsE3jLM5xnUPaOeQP6O TGvAy2s9d9Ql/0Km5PDZvDK/V1fAIP7Jv1BRnY5GzPtcfDzdrqSKvm1hw /I2uTMuF2fxtQX4F5L6om86bEXCMY4/7JLLFKdO7gAea8poMXvx3ZLzII Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10676"; a="332160677" X-IronPort-AV: E=Sophos;i="5.98,335,1673942400"; d="scan'208";a="332160677" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Apr 2023 16:48:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10676"; a="718761257" X-IronPort-AV: E=Sophos;i="5.98,335,1673942400"; d="scan'208";a="718761257" Received: from aschofie-mobl2.amr.corp.intel.com (HELO aschofie-mobl2) ([10.212.230.103]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Apr 2023 16:48:43 -0700 Date: Mon, 10 Apr 2023 16:48:41 -0700 From: Alison Schofield To: Angel Alberto Carretero Cc: Steve Longerbeam , Philipp Zabel , Mauro Carvalho Chehab , Greg Kroah-Hartman , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] media: imx: fix macro style error Message-ID: References: <20230409200135.1033677-1-angelalbertoc.r@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230409200135.1033677-1-angelalbertoc.r@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230410_164850_967846_046D7108 X-CRM114-Status: GOOD ( 20.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Apr 09, 2023 at 10:01:36PM +0200, Angel Alberto Carretero wrote: > Wrap macro in parenthesis to fix checkpatch error. > > Tested it by compiling the driver successfully. > > Signed-off-by: Angel Alberto Carretero > --- Hi Angel, The code change looks fine. Here are a few patch style suggestions: - If you do 'git log --oneline imx-media-utils.c' you'll see that changes in utils file only, seem to have utils in the patch subject prefix. "media: imx: utils:" - Commit message is vague. How about being explicit so anyone persuing those one-liners knows exactly what change was made. "Enclose IMX_BUS_FMTS macro in parentheses" - The commit log 'why' is to conform to the kernel coding style, not to fix a checkpatch error. It is good to say Issue found by checkpatch, but that itself is not the 'why'. Alison > drivers/staging/media/imx/imx-media-utils.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/media/imx/imx-media-utils.c b/drivers/staging/media/imx/imx-media-utils.c > index 411e907b68eb..eb44c09071de 100644 > --- a/drivers/staging/media/imx/imx-media-utils.c > +++ b/drivers/staging/media/imx/imx-media-utils.c > @@ -7,7 +7,7 @@ > #include > #include "imx-media.h" > > -#define IMX_BUS_FMTS(fmt...) (const u32[]) {fmt, 0} > +#define IMX_BUS_FMTS(fmt...) ((const u32[]) {fmt, 0}) > > /* > * List of supported pixel formats for the subdevs. > -- > 2.40.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel