From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2785BC7619A for ; Tue, 11 Apr 2023 10:33:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GyuZYjt5VGhTJ1I04OWClHkhqPlQxFVnAKDtcDb0XCM=; b=xzgHaYGtV3+JdB gXD6cnQ6/ZonaN9MaalxIFzyvg9c50GEl3lSHyLcXOqCpCfkHnFigcAppwPVkmDmXntSGD4gx4stP lb8H7tzXB33PQ97irWUqWJttes959fUEjbBRvt5AtvQyk8m922OeYO7I+UFm0ns53HdSx71pmfAuH FklmshzBP9iIHk8GEiXBUzNmfF5lbi3XkzjU9r3Zm9cB+7DjzhnTk3vCprSqEd0zVjtVSTr/8Fuhu X+OcOcvnJI4FYmgxyKsVkNf6A7EBnxJvciW1G76K1J3sIXHsnFNBaMde57WLEV41D9hcjWVuOdluA sGdOFpJCAtfXyajRzuRQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pmBII-00HJQ2-14; Tue, 11 Apr 2023 10:32:10 +0000 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pmBIF-00HJMS-1b for linux-arm-kernel@lists.infradead.org; Tue, 11 Apr 2023 10:32:09 +0000 Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-3f04eb5d1a7so4429145e9.1 for ; Tue, 11 Apr 2023 03:32:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; t=1681209125; x=1683801125; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=UWlYQX4Y1ZrzJyCNGQSUMnvOvpF/Z/nFIdYNxxNfrEg=; b=czHW7oszK57m41YR1u+rD3WPMSqPt6wloedBSlnzaMzPEUQ/AHMXNTewQNCzs/8uUD IFEphUmtf6E4QUbYANlkCNzJe1Mknn9tNbRgPUXAABh8MhWaBbw1CR71cEdupmHjjTAh elfhAUeAnv6GIjWOC7PEKocqH2pcKofnzo9K8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681209125; x=1683801125; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UWlYQX4Y1ZrzJyCNGQSUMnvOvpF/Z/nFIdYNxxNfrEg=; b=h7IoeTyHsDjGGo4f/M26wqYR0W+LjkBloICx23v3G4CdcR7TN4ITdX8XWEhAGx2Hn+ opAQPz6MKgwmF9D0z6ExHw3/3BJxabDrkmr3PFnuwx6lYa7l3ZfhzIrA1mGKU/6qGz+b 6MHt+d4w0FKZkAsSh/3yjeH/KLQ/EozkHwtzTOJRgspKkYZfclWr4MRydhmsXti2OtMp j/BMKLRAgHb47viemeslULFVtziOR4zgbDqhUaNP2PKpdX++KadC0M8Gxueej17AmNwA Tkjp5gwRUIMHsT4lnX+50pLq1keXw46OZk23CoILXKo2nRB+40AlWLqlcogMr0AHOUgB o8fA== X-Gm-Message-State: AAQBX9fY91v2ZTFQE7ctRDBuJNr0Fb/Rxyi1FfZQ/eL9EwFduVl1vii8 n1cxehzfZ7AWkjFAKTSFwa1CvA== X-Google-Smtp-Source: AKy350YHW26EoAnUgqXxjoecjfwc/bqx2pfSiH62+M+X8xHeutLKJ3Eqi5SeePtTr8IKBvV/huRCow== X-Received: by 2002:a5d:50c5:0:b0:2f0:244c:2780 with SMTP id f5-20020a5d50c5000000b002f0244c2780mr4057657wrt.7.1681209125018; Tue, 11 Apr 2023 03:32:05 -0700 (PDT) Received: from phenom.ffwll.local (212-51-149-33.fiber7.init7.net. [212.51.149.33]) by smtp.gmail.com with ESMTPSA id r10-20020adfe68a000000b002c7b229b1basm14182353wrm.15.2023.04.11.03.32.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Apr 2023 03:32:04 -0700 (PDT) Date: Tue, 11 Apr 2023 12:32:02 +0200 From: Daniel Vetter To: "Nancy.Lin" Cc: Chun-Kuang Hu , Philipp Zabel , Matthias Brugger , AngeloGioacchino Del Regno , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com, singo.chang@mediatek.com, shawn.sung@mediatek.com Subject: Re: [PATCH v3 1/2] drm/mediatek: Add mdp_rdma get format function Message-ID: Mail-Followup-To: "Nancy.Lin" , Chun-Kuang Hu , Philipp Zabel , Matthias Brugger , AngeloGioacchino Del Regno , David Airlie , dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com, singo.chang@mediatek.com, shawn.sung@mediatek.com References: <20230330032614.18837-1-nancy.lin@mediatek.com> <20230330032614.18837-2-nancy.lin@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230330032614.18837-2-nancy.lin@mediatek.com> X-Operating-System: Linux phenom 6.1.0-7-amd64 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230411_033207_542909_49F328BE X-CRM114-Status: GOOD ( 19.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Mar 30, 2023 at 11:26:13AM +0800, Nancy.Lin wrote: > Add mdp_rdma get_format and get_num_formats function. > > Signed-off-by: Nancy.Lin The mtk get_formats stuff seems like a lot of midlayering for not much reasons? Is that really needed? Just a drive-by questions I had while merging the pr. -Daniel > --- > drivers/gpu/drm/mediatek/mtk_disp_drv.h | 3 +++ > drivers/gpu/drm/mediatek/mtk_mdp_rdma.c | 24 ++++++++++++++++++++++++ > 2 files changed, 27 insertions(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_disp_drv.h b/drivers/gpu/drm/mediatek/mtk_disp_drv.h > index 0d28b2e2069c..17b169530beb 100644 > --- a/drivers/gpu/drm/mediatek/mtk_disp_drv.h > +++ b/drivers/gpu/drm/mediatek/mtk_disp_drv.h > @@ -152,4 +152,7 @@ void mtk_mdp_rdma_start(struct device *dev, struct cmdq_pkt *cmdq_pkt); > void mtk_mdp_rdma_stop(struct device *dev, struct cmdq_pkt *cmdq_pkt); > void mtk_mdp_rdma_config(struct device *dev, struct mtk_mdp_rdma_cfg *cfg, > struct cmdq_pkt *cmdq_pkt); > +const u32 *mtk_mdp_rdma_get_formats(struct device *dev); > +size_t mtk_mdp_rdma_get_num_formats(struct device *dev); > + > #endif > diff --git a/drivers/gpu/drm/mediatek/mtk_mdp_rdma.c b/drivers/gpu/drm/mediatek/mtk_mdp_rdma.c > index eecfa98ff52e..e06db6e56b5f 100644 > --- a/drivers/gpu/drm/mediatek/mtk_mdp_rdma.c > +++ b/drivers/gpu/drm/mediatek/mtk_mdp_rdma.c > @@ -62,6 +62,20 @@ > #define RDMA_CSC_FULL709_TO_RGB 5 > #define RDMA_CSC_BT601_TO_RGB 6 > > +static const u32 formats[] = { > + DRM_FORMAT_XRGB8888, > + DRM_FORMAT_ARGB8888, > + DRM_FORMAT_BGRX8888, > + DRM_FORMAT_BGRA8888, > + DRM_FORMAT_ABGR8888, > + DRM_FORMAT_XBGR8888, > + DRM_FORMAT_RGB888, > + DRM_FORMAT_BGR888, > + DRM_FORMAT_RGB565, > + DRM_FORMAT_UYVY, > + DRM_FORMAT_YUYV, > +}; > + > enum rdma_format { > RDMA_INPUT_FORMAT_RGB565 = 0, > RDMA_INPUT_FORMAT_RGB888 = 1, > @@ -219,6 +233,16 @@ void mtk_mdp_rdma_config(struct device *dev, struct mtk_mdp_rdma_cfg *cfg, > MDP_RDMA_MF_CLIP_SIZE, FLD_MF_CLIP_H); > } > > +const u32 *mtk_mdp_rdma_get_formats(struct device *dev) > +{ > + return formats; > +} > + > +size_t mtk_mdp_rdma_get_num_formats(struct device *dev) > +{ > + return ARRAY_SIZE(formats); > +} > + > int mtk_mdp_rdma_clk_enable(struct device *dev) > { > struct mtk_mdp_rdma *rdma = dev_get_drvdata(dev); > -- > 2.18.0 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel