From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0464CC7619A for ; Wed, 12 Apr 2023 13:21:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zOASUlLQilexwOJTZpnMrZBUG+XidvIvrBWGDqsGDX4=; b=yK7YM85DJ1wm2Q NVPIp33coTOjqGvWfHSaghE9XtkyNCJfVd86p/bV02w6Tv6ix3A7P6L7/T64i7GPQgLVx9mZLtop0 2PvLC7aX272lmjnhpaIhUWVADOOvLXBKWJQKnjCZ4nUf5BfZSs8AkSFtggApWD44Do4qQuOuF1RCz F+FHAo4Wm+W3cDPSIg6jieIQmxjlY1mk53Uw1THYjMrRWXo6s3KgfnlVvaXRHMFdxFD57Zbo48/8l EFEqlwd1XwFVQ2TZ/jxjJbZeOS1yAXzuafoz8ve/9qUT7ExarOaHrZ+Am0m2a7+KYxaWwgfdxntO6 uk7Nlul+w2spqeVMtwiQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pmaPH-003K8x-2S; Wed, 12 Apr 2023 13:21:03 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pmaPE-003K85-07 for linux-arm-kernel@lists.infradead.org; Wed, 12 Apr 2023 13:21:01 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E0D16D75; Wed, 12 Apr 2023 06:21:40 -0700 (PDT) Received: from e120937-lin (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CB12E3F73F; Wed, 12 Apr 2023 06:20:54 -0700 (PDT) Date: Wed, 12 Apr 2023 14:20:48 +0100 From: Cristian Marussi To: Rob Herring Cc: Sudeep Holla , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, vincent.guittot@linaro.org, souvik.chakravarty@arm.com, nicola.mazzucato@arm.com, Tushar.Khandelwal@arm.com, viresh.kumar@linaro.org, jassisinghbrar@gmail.com, Krzysztof Kozlowski , devicetree@vger.kernel.org Subject: Re: [PATCH 1/2] dt-bindings: mailbox : arm,mhuv2: Allow for more RX interrupts Message-ID: References: <20230329153936.394911-1-cristian.marussi@arm.com> <20230329153936.394911-2-cristian.marussi@arm.com> <20230329174431.yga3c233sazimane@bogus> <20230412131521.GA1830888-robh@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230412131521.GA1830888-robh@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230412_062100_189102_E53ABF78 X-CRM114-Status: GOOD ( 43.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Apr 12, 2023 at 08:15:21AM -0500, Rob Herring wrote: > On Thu, Mar 30, 2023 at 09:29:23AM +0100, Cristian Marussi wrote: > > On Wed, Mar 29, 2023 at 06:44:31PM +0100, Sudeep Holla wrote: > > > On Wed, Mar 29, 2023 at 04:39:35PM +0100, Cristian Marussi wrote: > > > > The ARM MHUv2 Receiver block can indeed support more interrupts, up to the > > > > maximum number of available channels, but anyway no more than the maximum > > > > number of supported interrupt for an AMBA device. > > > > > > > > Signed-off-by: Cristian Marussi > > > > --- > > > > Cc: Rob Herring > > > > Cc: Krzysztof Kozlowski > > > > Cc: devicetree@vger.kernel.org > > > > > > > > .../devicetree/bindings/mailbox/arm,mhuv2.yaml | 13 +++++++++---- > > > > 1 file changed, 9 insertions(+), 4 deletions(-) > > > > > > > > diff --git a/Documentation/devicetree/bindings/mailbox/arm,mhuv2.yaml b/Documentation/devicetree/bindings/mailbox/arm,mhuv2.yaml > > > > index a4f1fe63659a..5a57f4e2a623 100644 > > > > --- a/Documentation/devicetree/bindings/mailbox/arm,mhuv2.yaml > > > > +++ b/Documentation/devicetree/bindings/mailbox/arm,mhuv2.yaml > > > > @@ -69,10 +69,15 @@ properties: > > > > > > > > interrupts: > > > > description: | > > > > - The MHUv2 controller always implements an interrupt in the "receiver" > > > > - mode, while the interrupt in the "sender" mode was not available in the > > > > - version MHUv2.0, but the later versions do have it. > > > > - maxItems: 1 > > > > + The MHUv2 controller always implements at least an interrupt in the > > > > + "receiver" mode, while the interrupt in the "sender" mode was not > > > > + available in the version MHUv2.0, but the later versions do have it. > > > > + In "receiver" mode, beside a single combined interrupt, there could be > > > > + multiple interrupts, up to the number of implemented channels but anyway > > > > + no more than the maximum number of interrupts potentially supported by > > > > + AMBA. > > > > + minItems: 1 > > > > + maxItems: 9 > > > > > > > Hi, > > > > > I am not sure 9 is the correct value here. IIUC it is just what Linux defines > > > as AMBA_NR_IRQS. Looking at the history it was bumped from 2 to 9 for use > > > by PL330 DMA driver. I couldn't find anything to relate this 9 in any > > > AMBA or other related specification. > > > > > > > Yes, I could not find either where the 9 comes from, but it is what > > currently each amba device is limited to, at the software level, in terms of > > interrupts that can be detected. > > IIRC, the PL330 can have an interrupt per context with up to 8 contexts > and then 1 global interrupt. > > > > > > Ideally I would say we don't know what the max here. We just have a platform > > > implementing 2 interrupts now. Do we for with 2 for now and change it if some > > > new users require more in the future ? > > > > > > > By the spec seems to me that the maximum number of interrupts are equal to > > the maximum possible channels (124), or one combined interrupt. > > > > But these in turn, as said, are capped by the AMBA_NR_IRQS and I have > > only seen one system using 2. (for which I need this series to work) > > > > > I will leave that to the DT maintainers but 9 is simply random based on Linux > > > code so I would rather choose some other random number with a better reasoning > > > than 9 as AMBA code in the kernel is limiting it to 9. > > > > > > > Agreed. Aiming to describe any possible hw in the DT, I would say 124 at > > this point. (even though implausible not to use the combined interrupt > > at that point...) > > Then use 124, but please describe how you get that in the description. > Ok, thanks, I'll do. Cristian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel