From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 70EB7C7619A for ; Wed, 12 Apr 2023 15:28:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=veuBLF2C4pLAVC24ecsOJnOEQRQDsvehnTyjBDRHnuY=; b=2WxnwJWPQvTjl5 TrwDH00vvb6vx0KOUo8qG9omDD0qN89IFg40JWv3xss4/7oAqiMkGDDi+Ar98BeNM1EWEMeGPScmA hfOSpEOfb1IjW3htnyoMTDmDx6R8M8l/rIhq2hd8eoGDvSfj/2TTlCZRmxhBI/FCrNURwryv5OHV4 GnaMoFOnsC/epzcSMlRsPCFf/UOQpjn5Q3yAjNWa+wiXAZpq6Vy1lP7ScwU/XV3RW2xb6z/9L9eFO 0HfJCgfryawILet0Ctf+Li9YIYcAdZaarVtMYNoKn82tNJNulRoYdIx7zikqMkaA0N4KkfzNNcMqj 8D8nSWPBPjwpyq4AeTzQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pmcNO-003dBe-2N; Wed, 12 Apr 2023 15:27:14 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pmcNK-003dBA-36 for linux-arm-kernel@lists.infradead.org; Wed, 12 Apr 2023 15:27:12 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681313227; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Pl6/W8hCGdRrPSVdraI8ut0BaCLlf4yrRN6pHHW/94A=; b=YlmU+fXfNfyP8FcsUE2QxMBH1+78BvJF7JWtpDuMlFoB20gtiPPRCD6ki0M1tOdNVvpaKU VwbKhoEmHEPETgfn9ctt8cm9nDjIRuuWEIwwuuu2jwI6Y3oaJBSBQZRWQmicwa3p0SCeLS y7Y/PlSGFE7JffW1BJ1VEWyuwqua7PU= Received: from mail-yb1-f200.google.com (mail-yb1-f200.google.com [209.85.219.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-393-qTCdy__hNs-a8PrgBjz3vg-1; Wed, 12 Apr 2023 11:25:23 -0400 X-MC-Unique: qTCdy__hNs-a8PrgBjz3vg-1 Received: by mail-yb1-f200.google.com with SMTP id b124-20020a253482000000b00b8f1b9d74ecso6573448yba.18 for ; Wed, 12 Apr 2023 08:25:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681313123; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Pl6/W8hCGdRrPSVdraI8ut0BaCLlf4yrRN6pHHW/94A=; b=dYvKALYj3rrGgaC+rWEpBPAeYTRMXI6yiTTaOVSaCQ4LB/laJHaXmj/LJtTxrb+7D1 L4g4XReem0y5gGZymyUrs0sdjr4RpyMxK71qb7MBxWMQ5g8/VVsEkfv1PL5ssY7qgkyL LJM0g6fVMxafKxWjOsj9HMn76NG49fKye6xMsI4qk4hyESg7FMUaL4YJKs1AJmcLvzGw lhcPwHZ3zW4GcPLyvTvRG4wCZwjWdVGdiEXpMuFe8cL+FtR6doMP6Hgah/I/Lr9d7ilX irPz/CK1jp3yPl/iwD/Hc2DCrAaACcVVW24e8T+7U3fDLUXDINz8b0ePjry5acwEtjq7 pG5A== X-Gm-Message-State: AAQBX9dszX7szDR90NsH7EFNiVT1VMOvkAkp8WsQTlKd/W5qmBmQVP2m ts7WActqO2zEGqec1Axir2mDOW8H8y4IJUURLFQPObQWGe5Swm6j5ZIm0Z+VIUFvzfh/jhoV4Yg LRgMDxBTdg1Ac7b8tb1UKPXhRoNcyKBwScKA= X-Received: by 2002:a25:ad94:0:b0:b62:d9a1:a606 with SMTP id z20-20020a25ad94000000b00b62d9a1a606mr14571420ybi.62.1681313123351; Wed, 12 Apr 2023 08:25:23 -0700 (PDT) X-Google-Smtp-Source: AKy350adNn8pbkwJ2Kq0277gghgwLXefMb+eA4EygwfbHqcH5RZ9YG9iTFp0U4fQIhM3iOy8sYtlRg== X-Received: by 2002:a25:ad94:0:b0:b62:d9a1:a606 with SMTP id z20-20020a25ad94000000b00b62d9a1a606mr14571401ybi.62.1681313123021; Wed, 12 Apr 2023 08:25:23 -0700 (PDT) Received: from x1 (c-73-214-169-22.hsd1.pa.comcast.net. [73.214.169.22]) by smtp.gmail.com with ESMTPSA id e140-20020a811e92000000b0054f8a3f6281sm686495ywe.3.2023.04.12.08.25.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Apr 2023 08:25:22 -0700 (PDT) Date: Wed, 12 Apr 2023 11:25:18 -0400 From: Brian Masney To: Andrew Halaney Cc: linux-kernel@vger.kernel.org, agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, vkoul@kernel.org, bhupesh.sharma@linaro.org, wens@csie.org, jernej.skrabec@gmail.com, samuel@sholland.org, mturquette@baylibre.com, peppe.cavallaro@st.com, alexandre.torgue@foss.st.com, joabreu@synopsys.com, mcoquelin.stm32@gmail.com, richardcochran@gmail.com, linux@armlinux.org.uk, veekhee@apple.com, tee.min.tan@linux.intel.com, mohammad.athari.ismail@intel.com, jonathanh@nvidia.com, ruppala@nvidia.com, andrey.konovalov@linaro.org, linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, ncai@quicinc.com, jsuraj@qti.qualcomm.com, hisunil@quicinc.com, echanude@redhat.com Subject: Re: [PATCH net-next v4 00/12] Add EMAC3 support for sa8540p-ride Message-ID: References: <20230411200409.455355-1-ahalaney@redhat.com> MIME-Version: 1.0 In-Reply-To: <20230411200409.455355-1-ahalaney@redhat.com> User-Agent: Mutt/2.2.7 (2022-08-07) X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230412_082711_092309_CC6CF014 X-CRM114-Status: GOOD ( 22.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Apr 11, 2023 at 03:03:57PM -0500, Andrew Halaney wrote: > This is a forward port / upstream refactor of code delivered > downstream by Qualcomm over at [0] to enable the DWMAC5 based > implementation called EMAC3 on the sa8540p-ride dev board. > > From what I can tell with the board schematic in hand, > as well as the code delivered, the main changes needed are: > > 1. A new address space layout for dwmac5/EMAC3 MTL/DMA regs > 2. A new programming sequence required for the EMAC3 based platforms > > This series makes the changes above as well as other housekeeping items > such as converting dt-bindings to yaml, etc. > > As requested[1], it has been split up by compilation deps / maintainer tree. > I will post a link to the associated devicetree changes that together > with this series get the hardware functioning. > > Patches 1-3 are clean ups of the currently supported dt-bindings and > IMO could be picked up as is independent of the rest of the series to > improve the current codebase. They've all been reviewed in prior > versions of the series. > > Patches 5-7 are also clean ups of the driver and are worth picking up > independently as well. They don't all have explicit reviews but should > be good to go (trivial changes on non-reviewed bits). > > The rest of the patches have new changes, lack review, or are specificly > being made to support the new hardware, so they should wait until the > series as a whole is deemed ready to go by the community. Looks good to me! Tested-by: Brian Masney _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel