From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 709C5C7619A for ; Thu, 13 Apr 2023 00:16:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=D+0VKF1MoMAAQPDe1D08xjlKxbAXPpZKZhaFudFWpqg=; b=oj63WlYFDcORQ3 Q/N+fc92TMGNEwQ9fbx1Y7kBkDZ+Gxk5Te3rfJji2xYV08nmalfAedTEGHSoTfyBFt1LzgsrEXq7z nqx5GzuU8pFMNEvhAALATdc+lO0bYKg60+1vr/bQijkX4Zi7yEtJF0ykrrOpIjx+0XQeEEsQiLuOO ztGmhBLTeTIyPmem2CNJYrPliaYhV+u1wbcOUYvkQjTDk5glHoriArXScFW8Eu39DLztl9fRHy2cM OxyePaAS2QaezBWu4ZMDSmlRecQADFeIqoBhxeswTgdgrUkUC0uJ4HKW+KmCMGQcYFNvh4T6xTrOv 4BxQ1AwLR/zyAuhlZhxw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pmkco-004gT1-3C; Thu, 13 Apr 2023 00:15:43 +0000 Received: from out-17.mta0.migadu.com ([2001:41d0:1004:224b::11]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pmkcl-004gSF-1W for linux-arm-kernel@lists.infradead.org; Thu, 13 Apr 2023 00:15:40 +0000 Date: Thu, 13 Apr 2023 00:15:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1681344935; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oxKqdN2d9o1rjgNqs0FzqHDIOpuH0PBhahAh2+r4yw4=; b=mo00ZAK6PrrPng6pfwi13RNopdcsOdIQYpWIg7UhZfUS+CmcM4ej/RoJevZVAE9sIjd22R lDs9e8VgSWq9lIPg+iGXN1Kgn2JEPnhldHQeU9viU33XhZfqAhcvDCIFsP6cVbCQ2EKEXD e4QmadRWlZvSCeNPMG/WwWkAfoafDIE= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: Marc Zyngier Cc: kvmarm@lists.linux.dev, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, James Morse , Suzuki K Poulose , Zenghui Yu , Will Deacon Subject: Re: [PATCH v2 5/5] KVM: arm64: vhe: Drop extra isb() on guest exit Message-ID: References: <20230408160427.10672-1-maz@kernel.org> <20230408160427.10672-6-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230408160427.10672-6-maz@kernel.org> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230412_171539_648188_2B18DC94 X-CRM114-Status: UNSURE ( 9.99 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Apr 08, 2023 at 05:04:27PM +0100, Marc Zyngier wrote: > __kvm_vcpu_run_vhe() end on VHE with an isb(). However, this > function is only reachable via kvm_call_hyp_ret(), which already > contains an isb() in order to mimick the behaviour of nVHE and > provide a context synchronisation event. > > We thus have two isb()s back to back, which is one too many. > Drop the first one and solely rely on the one in the helper. > > Signed-off-by: Marc Zyngier Reviewed-by: Oliver Upton -- Thanks, Oliver _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel