linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding@gmail.com>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: "Jerome Brunet" <jbrunet@baylibre.com>,
	"Martin Blumenstingl" <martin.blumenstingl@googlemail.com>,
	"Neil Armstrong" <narmstrong@baylibre.com>,
	"Kevin Hilman" <khilman@baylibre.com>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"open list:ARM/Amlogic Meson..."
	<linux-amlogic@lists.infradead.org>,
	linux-pwm@vger.kernel.org, "Jian Hu" <jian.hu@amlogic.com>
Subject: Re: [PATCH v2] pwm: meson: fix axg ao mux parents
Date: Thu, 13 Apr 2023 11:23:10 +0200	[thread overview]
Message-ID: <ZDfJ_iaRXlXzd0PL@orome> (raw)
In-Reply-To: <ffc3e4e7-b2ea-1a56-4fff-6554ad3775c0@gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 1657 bytes --]

On Sun, Apr 09, 2023 at 05:15:52PM +0200, Heiner Kallweit wrote:
> This fix is basically the same as 9bce02ef0dfa ("pwm: meson: Fix the
> G12A AO clock parents order"). Vendor driver referenced there has
> xtal as first parent also for axg ao. In addition fix the name
> of the aoclk81 clock. Apparently name aoclk81 as used by the vendor
> driver was changed when mainlining the axg clock driver.
> 
> Fixes: bccaa3f917c9 ("pwm: meson: Add clock source configuration for Meson-AXG")
> Cc: stable@vger.kernel.org
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
>  drivers/pwm/pwm-meson.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

This looks like it supersedes this one:

	https://patchwork.ozlabs.org/project/linux-pwm/patch/e7a95baf-5f9d-be56-93dc-82ca83b69c7a@gmail.com/

I don't see any discussion on on that one, nor does v2 here have a
changelog and the commit subject is slightly changed, so you're making
it more difficult than necessary to correlate the two.

Anyway, since both patches conflict, I've picked up v2. Let me know if
that's not what you intended.

Thierry

> 
> diff --git a/drivers/pwm/pwm-meson.c b/drivers/pwm/pwm-meson.c
> index b5c746fab..0fe0400c2 100644
> --- a/drivers/pwm/pwm-meson.c
> +++ b/drivers/pwm/pwm-meson.c
> @@ -381,7 +381,7 @@ static const struct meson_pwm_data pwm_axg_ee_data = {
>  };
>  
>  static const char * const pwm_axg_ao_parent_names[] = {
> -	"aoclk81", "xtal", "fclk_div4", "fclk_div5"
> +	"xtal", "axg_ao_clk81", "fclk_div4", "fclk_div5"
>  };
>  
>  static const struct meson_pwm_data pwm_axg_ao_data = {
> -- 
> 2.40.0
> 

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

      parent reply	other threads:[~2023-04-13  9:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-09 15:15 [PATCH v2] pwm: meson: fix axg ao mux parents Heiner Kallweit
2023-04-10 21:17 ` Martin Blumenstingl
2023-04-13  9:23 ` Thierry Reding [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZDfJ_iaRXlXzd0PL@orome \
    --to=thierry.reding@gmail.com \
    --cc=hkallweit1@gmail.com \
    --cc=jbrunet@baylibre.com \
    --cc=jian.hu@amlogic.com \
    --cc=khilman@baylibre.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=narmstrong@baylibre.com \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).