From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Ryan Chen <ryan_chen@aspeedtech.com>
Cc: Brendan Higgins <brendan.higgins@linux.dev>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Joel Stanley <joel@jms.id.au>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Andrew Jeffery <andrew@aj.id.au>,
Philipp Zabel <p.zabel@pengutronix.de>,
Wolfram Sang <wsa@kernel.org>,
linux-i2c@vger.kernel.org,
Florian Fainelli <f.fainelli@gmail.com>,
Jean Delvare <jdelvare@suse.de>,
William Zhang <william.zhang@broadcom.com>,
Tyrone Ting <kfting@nuvoton.com>,
Tharun Kumar P <tharunkumar.pasumarthi@microchip.com>,
Conor Dooley <conor.dooley@microchip.com>,
Phil Edworthy <phil.edworthy@renesas.com>,
openbmc@lists.ozlabs.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v9 2/2 RESEND] i2c: aspeed: support ast2600 i2c new register mode driver
Date: Thu, 13 Apr 2023 19:12:13 +0300 [thread overview]
Message-ID: <ZDgp3VrjW1YdC16z@smile.fi.intel.com> (raw)
In-Reply-To: <ZDgpkK/Dv3y1LUe2@smile.fi.intel.com>
On Thu, Apr 13, 2023 at 07:10:56PM +0300, Andy Shevchenko wrote:
> On Thu, Apr 13, 2023 at 03:53:27PM +0800, Ryan Chen wrote:
> > Add i2c new register mode driver to support AST2600 i2c
> > new register mode. AST2600 i2c controller have legacy and
> > new register mode. The new register mode have global register
> > support 4 base clock for scl clock selection, and new clock
> > divider mode. The i2c new register mode have separate register
> > set to control i2c master and slave.
>
> There is already i2c-aspeed.c in the kernel. Can you elaborate what's wrong
> with the extending existing driver? (It seems to me that so called "legacy"
> mode is exactly what is being serviced by that driver.)
Okay, it seems the answer is in cover letter.
--
With Best Regards,
Andy Shevchenko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2023-04-13 16:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-13 7:53 [PATCH v9 0/2 RESEND] Add ASPEED AST2600 I2Cv2 controller driver Ryan Chen
2023-04-13 7:53 ` [PATCH v9 1/2 RESEND] dt-bindings: i2c: aspeed: support for AST2600-i2cv2 Ryan Chen
2023-04-13 16:17 ` Krzysztof Kozlowski
2023-04-13 7:53 ` [PATCH v9 2/2 RESEND] i2c: aspeed: support ast2600 i2c new register mode driver Ryan Chen
2023-04-13 16:10 ` Andy Shevchenko
2023-04-13 16:12 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZDgp3VrjW1YdC16z@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=andrew@aj.id.au \
--cc=benh@kernel.crashing.org \
--cc=brendan.higgins@linux.dev \
--cc=conor.dooley@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=jdelvare@suse.de \
--cc=joel@jms.id.au \
--cc=kfting@nuvoton.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=p.zabel@pengutronix.de \
--cc=phil.edworthy@renesas.com \
--cc=robh+dt@kernel.org \
--cc=ryan_chen@aspeedtech.com \
--cc=tharunkumar.pasumarthi@microchip.com \
--cc=william.zhang@broadcom.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).