From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 414B8C77B61 for ; Thu, 13 Apr 2023 16:13:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pCUTEDbnfAMTIkJfQE9GSevxvpy+GhnRp61Kpt3rGw8=; b=02ykYCZ67VNZqx w4yrgLev1pjCGyZ91L0XZDCb4IvSS3cgJTNlYxPAttYD745NB4u8sPVwVGEsCC78wK/Ki4bpGqLmT BMfWzHiwSbG0bG146q/wFUkVRM7IzAFmBxIzPlVr6T4Ma9JrJMTDmV7kfdhBntlithHnwgKaxlAXo LKZmvu0bDA9Gzhhp4UUQ1+3L+HfXeHw6mLeJqlpu9SJZjooCEtAINJxbSoCyaB6ga07Fn8dAJADG5 Kn6d6hjdox/couoQ5/CwSXOL9zT6huPWrZImw54bvlCsptInEw2BkiKMsviLrYApmJjgWHohlCDwX 6TBxHkjDizy4ImHwdJlQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pmzYl-006bmN-2l; Thu, 13 Apr 2023 16:12:31 +0000 Received: from mga12.intel.com ([192.55.52.136]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pmzYj-006bkI-2A for linux-arm-kernel@lists.infradead.org; Thu, 13 Apr 2023 16:12:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1681402349; x=1712938349; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=u3In46KoV7jrlPQBLlMpa2pfQ3+DhOK7gwXj89ZvQh0=; b=eU02+zidTAEJcAahaIBEtWHIE4NtAr+rLHqnxUqXFzKelMc3EPltaNBN qnP5f/lufWIryKiSRqnQIKiB8Dwa+Lr6SJHQk8sAmAxo/52uAZR/EfOTz BgF7DCadHo64QwZaM6iSo86S4zhy/5mb899B/X9S+FDFjxhaH1xEvQw25 3PS+ms2bm/6A+ECUm8Ff/5sp5ewMbm6s97zCL4W14Waa1htYAKKy65vg4 uib4EJ/akeUkP+uHeLKBPDfi5mj2Ofq5nlefc8dsprtEwWJrx26d1CNj4 BsjAhUiYPSuNe3Fun+ZdRIFx9L/yZwqg5gTZ6s56HpnarOYJlGUfaGdKf A==; X-IronPort-AV: E=McAfee;i="6600,9927,10679"; a="323853013" X-IronPort-AV: E=Sophos;i="5.99,194,1677571200"; d="scan'208";a="323853013" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Apr 2023 09:12:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10679"; a="758753815" X-IronPort-AV: E=Sophos;i="5.99,194,1677571200"; d="scan'208";a="758753815" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga004.fm.intel.com with ESMTP; 13 Apr 2023 09:12:16 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1pmzYT-00GchC-2q; Thu, 13 Apr 2023 19:12:13 +0300 Date: Thu, 13 Apr 2023 19:12:13 +0300 From: Andy Shevchenko To: Ryan Chen Cc: Brendan Higgins , Benjamin Herrenschmidt , Joel Stanley , Rob Herring , Krzysztof Kozlowski , Andrew Jeffery , Philipp Zabel , Wolfram Sang , linux-i2c@vger.kernel.org, Florian Fainelli , Jean Delvare , William Zhang , Tyrone Ting , Tharun Kumar P , Conor Dooley , Phil Edworthy , openbmc@lists.ozlabs.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v9 2/2 RESEND] i2c: aspeed: support ast2600 i2c new register mode driver Message-ID: References: <20230413075327.1397306-1-ryan_chen@aspeedtech.com> <20230413075327.1397306-3-ryan_chen@aspeedtech.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230413_091229_761520_E902FCDD X-CRM114-Status: GOOD ( 14.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Apr 13, 2023 at 07:10:56PM +0300, Andy Shevchenko wrote: > On Thu, Apr 13, 2023 at 03:53:27PM +0800, Ryan Chen wrote: > > Add i2c new register mode driver to support AST2600 i2c > > new register mode. AST2600 i2c controller have legacy and > > new register mode. The new register mode have global register > > support 4 base clock for scl clock selection, and new clock > > divider mode. The i2c new register mode have separate register > > set to control i2c master and slave. > > There is already i2c-aspeed.c in the kernel. Can you elaborate what's wrong > with the extending existing driver? (It seems to me that so called "legacy" > mode is exactly what is being serviced by that driver.) Okay, it seems the answer is in cover letter. -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel